New issue
Advanced search Search tips

Issue 842296 link

Starred by 6 users
Status: Untriaged
Owner: ----
EstimatedDays: ----
NextAction: 2019-07-09
OS: ----
Pri: 3
Type: Task

Blocked on: View detail
issue 842354
issue 842387
issue 842346
issue 850774
Restricted
  • Only users with EditIssue permission may comment.



Sign in to add a comment

Avoid the racially-charged terms "blacklist" and "whitelist".

Project Member Reported by jyasskin@chromium.org, May 11 2018 
Chromium's source code uses "blacklist" and "whitelist" a lot. Ideally we wouldn't do that since it unnecessarily reinforces the notion that black==bad and white==good. https://mcwriting11.blogspot.com/2014/06/that-word-black-by-langston-hughes.html illustrates this problem in a lighthearted, if somewhat pointed way.

These terms can usually be replaced by "blocklist" and "allowlist" without changing their meanings, but particular instances may need other replacements. (Defining an exhaustive set of replacements is not within the scope of this bug - let's focus on improving instead of perfection.)

Places that are visible to users affect more people and so are higher priority than instances internal to the code, but both should be fixed eventually. New code should definitely not use the terms.
Project Member

Comment 1 by bugdroid1@chromium.org, May 11 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7eaa5cca0f0d88ae89cba41eaf50cc053b72b418

commit 7eaa5cca0f0d88ae89cba41eaf50cc053b72b418
Author: Jeffrey Yasskin <jyasskin@chromium.org>
Date: Fri May 11 21:45:32 2018

"Blacklist"->"Blocklist" in interventions-internals UI.

BUG=842296

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I7af43a396e06bbb662154401a3b90cedbf2477c2
Reviewed-on: https://chromium-review.googlesource.com/1055905
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Jeffrey Yasskin <jyasskin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558029}
[modify] https://crrev.com/7eaa5cca0f0d88ae89cba41eaf50cc053b72b418/chrome/browser/resources/interventions_internals/index.html

Comment 2 by jyasskin@chromium.org, May 11 2018

Blockedon: 842354

Comment 3 by jyasskin@chromium.org, May 11 2018

Blockedon: 842346

Comment 4 by rdevlin....@chromium.org, May 12 2018

Blockedon: 842387
Project Member

Comment 5 by bugdroid1@chromium.org, May 14 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a4a5823d02ae60315f9adc287940545ad68a2863

commit a4a5823d02ae60315f9adc287940545ad68a2863
Author: Jeffrey Yasskin <jyasskin@chromium.org>
Date: Mon May 14 18:06:48 2018

Remove "whitelist" and "blacklist" from extension docs.

I left one instance of "whitelist" in shared_modules, where it's
actually part of the public API.

BUG=842296

Change-Id: I63c8533c88801c283af5a6ddca710c2a246ce6bf
Reviewed-on: https://chromium-review.googlesource.com/1056027
Commit-Queue: Jeffrey Yasskin <jyasskin@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558375}
[modify] https://crrev.com/a4a5823d02ae60315f9adc287940545ad68a2863/chrome/common/extensions/docs/templates/articles/app_codelab_images.html
[modify] https://crrev.com/a4a5823d02ae60315f9adc287940545ad68a2863/chrome/common/extensions/docs/templates/articles/app_external.html
[modify] https://crrev.com/a4a5823d02ae60315f9adc287940545ad68a2863/chrome/common/extensions/docs/templates/articles/app_identity.html
[modify] https://crrev.com/a4a5823d02ae60315f9adc287940545ad68a2863/chrome/common/extensions/docs/templates/articles/contentSecurityPolicy.html
[modify] https://crrev.com/a4a5823d02ae60315f9adc287940545ad68a2863/chrome/common/extensions/docs/templates/articles/external_extensions.html
[modify] https://crrev.com/a4a5823d02ae60315f9adc287940545ad68a2863/chrome/common/extensions/docs/templates/articles/manifest/storage.html
[modify] https://crrev.com/a4a5823d02ae60315f9adc287940545ad68a2863/chrome/common/extensions/docs/templates/articles/manifest/web_accessible_resources.html
[modify] https://crrev.com/a4a5823d02ae60315f9adc287940545ad68a2863/chrome/common/extensions/docs/templates/articles/manifestVersion.html
[modify] https://crrev.com/a4a5823d02ae60315f9adc287940545ad68a2863/chrome/common/extensions/docs/templates/articles/messaging.html
[modify] https://crrev.com/a4a5823d02ae60315f9adc287940545ad68a2863/chrome/common/extensions/docs/templates/articles/nativeMessaging.html
[modify] https://crrev.com/a4a5823d02ae60315f9adc287940545ad68a2863/chrome/common/extensions/docs/templates/articles/tut_migration_to_manifest_v2.html
[modify] https://crrev.com/a4a5823d02ae60315f9adc287940545ad68a2863/chrome/common/extensions/docs/templates/intros/feedbackPrivate.html
[modify] https://crrev.com/a4a5823d02ae60315f9adc287940545ad68a2863/chrome/common/extensions/docs/templates/intros/networkingPrivate.html

Comment 6 by karandeepb@chromium.org, Jun 8 2018

Blockedon: 850774
Project Member

Comment 7 by bugdroid1@chromium.org, Jun 16 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2860433068296b76190c08acdf857a0a5d4cabc3

commit 2860433068296b76190c08acdf857a0a5d4cabc3
Author: karandeepb <karandeepb@chromium.org>
Date: Sat Jun 16 01:47:19 2018

Declarative Net Request: Replace usages of 'blacklist' and 'whitelist'.

This CL replaces the usages of 'blacklist' and 'whitelist' in the Declarative
Net Request code. It introduces the following changes to the public API:
  - RuleActionType blacklist -> RuleActionType block
  - RuleActionType whitelist -> RuleActionType allow
  - MAX_NUMBER_OF_WHITELISTED_PAGES -> MAX_NUMBER_OF_ALLOWED_PAGES
  - addWhitelistedPages -> addAllowedPages
  - removeWhitelistedPages -> removeAllowedPages
  - getWhitelistedPages -> getAllowedPages

As a result of this change, existing extensions using the Declarative Net
Request API will need to be updated. Usages of these terms in enums and
preference keys are kept as-is.

BUG= 850774 , 842296

Change-Id: Id4aaac5ec3123fd56a1591e22025a455d7cb6941
Reviewed-on: https://chromium-review.googlesource.com/1094141
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567858}
[modify] https://crrev.com/2860433068296b76190c08acdf857a0a5d4cabc3/chrome/browser/extensions/api/declarative_net_request/declarative_net_request_apitest.cc
[modify] https://crrev.com/2860433068296b76190c08acdf857a0a5d4cabc3/chrome/browser/extensions/api/declarative_net_request/declarative_net_request_browsertest.cc
[modify] https://crrev.com/2860433068296b76190c08acdf857a0a5d4cabc3/chrome/browser/extensions/api/declarative_net_request/ruleset_manager_unittest.cc
[modify] https://crrev.com/2860433068296b76190c08acdf857a0a5d4cabc3/chrome/test/data/extensions/api_test/declarative_net_request/extension_with_no_ruleset/background.js
[rename] https://crrev.com/2860433068296b76190c08acdf857a0a5d4cabc3/chrome/test/data/extensions/api_test/declarative_net_request/page_allowing_api/background.js
[rename] https://crrev.com/2860433068296b76190c08acdf857a0a5d4cabc3/chrome/test/data/extensions/api_test/declarative_net_request/page_allowing_api/manifest.json
[rename] https://crrev.com/2860433068296b76190c08acdf857a0a5d4cabc3/chrome/test/data/extensions/api_test/declarative_net_request/page_allowing_api/rules_file_empty.json
[rename] https://crrev.com/2860433068296b76190c08acdf857a0a5d4cabc3/chrome/test/data/extensions/declarative_net_request/allowing_api.html
[modify] https://crrev.com/2860433068296b76190c08acdf857a0a5d4cabc3/extensions/browser/api/declarative_net_request/declarative_net_request_api.cc
[modify] https://crrev.com/2860433068296b76190c08acdf857a0a5d4cabc3/extensions/browser/api/declarative_net_request/declarative_net_request_api.h
[modify] https://crrev.com/2860433068296b76190c08acdf857a0a5d4cabc3/extensions/browser/api/declarative_net_request/flat/extension_ruleset.fbs
[modify] https://crrev.com/2860433068296b76190c08acdf857a0a5d4cabc3/extensions/browser/api/declarative_net_request/flat_ruleset_indexer.cc
[modify] https://crrev.com/2860433068296b76190c08acdf857a0a5d4cabc3/extensions/browser/api/declarative_net_request/flat_ruleset_indexer.h
[modify] https://crrev.com/2860433068296b76190c08acdf857a0a5d4cabc3/extensions/browser/api/declarative_net_request/flat_ruleset_indexer_unittest.cc
[modify] https://crrev.com/2860433068296b76190c08acdf857a0a5d4cabc3/extensions/browser/api/declarative_net_request/indexed_rule.cc
[modify] https://crrev.com/2860433068296b76190c08acdf857a0a5d4cabc3/extensions/browser/api/declarative_net_request/indexed_rule_unittest.cc
[modify] https://crrev.com/2860433068296b76190c08acdf857a0a5d4cabc3/extensions/browser/api/declarative_net_request/rules_monitor_service.cc
[modify] https://crrev.com/2860433068296b76190c08acdf857a0a5d4cabc3/extensions/browser/api/declarative_net_request/ruleset_manager.cc
[modify] https://crrev.com/2860433068296b76190c08acdf857a0a5d4cabc3/extensions/browser/api/declarative_net_request/ruleset_manager.h
[modify] https://crrev.com/2860433068296b76190c08acdf857a0a5d4cabc3/extensions/browser/api/declarative_net_request/ruleset_matcher.cc
[modify] https://crrev.com/2860433068296b76190c08acdf857a0a5d4cabc3/extensions/browser/api/declarative_net_request/ruleset_matcher.h
[modify] https://crrev.com/2860433068296b76190c08acdf857a0a5d4cabc3/extensions/browser/extension_function_histogram_value.h
[modify] https://crrev.com/2860433068296b76190c08acdf857a0a5d4cabc3/extensions/browser/extension_prefs.cc
[modify] https://crrev.com/2860433068296b76190c08acdf857a0a5d4cabc3/extensions/browser/extension_prefs.h
[modify] https://crrev.com/2860433068296b76190c08acdf857a0a5d4cabc3/extensions/common/api/declarative_net_request.idl
[modify] https://crrev.com/2860433068296b76190c08acdf857a0a5d4cabc3/extensions/common/api/declarative_net_request/test_utils.cc
[modify] https://crrev.com/2860433068296b76190c08acdf857a0a5d4cabc3/tools/metrics/histograms/enums.xml

Comment 8 by benhenry@google.com, Jan 10

Labels: Pri-3
NextAction: 2019-07-09
Downgrading P2s that haven't been modified in more than 6 months, which have no component or owner.
►

Sign in to add a comment