New issue
Advanced search Search tips

Issue 842295 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

MoveEventHandler should be --mash specific

Project Member Reported by msw@chromium.org, May 11 2018

Issue description

Wire up non-client cursors in window-service as a library

I'm stubbing out this behavior from the original window service for now in:
 https://chromium-review.googlesource.com/c/chromium/src/+/1055658/6/ash/wm/move_event_handler.cc
We'll need something to replace the WindowManagerClient::SetNonClientCursor.
 

Comment 1 by msw@chromium.org, May 14 2018

Cc: est...@chromium.org
This may be related to  Issue 837705  (not sure if dup or blocked/blocking). SetCursor vs SetNonClientCursor...
TODO in the code: https://cs.chromium.org/chromium/src/ash/wm/move_event_handler.cc?rcl=bbe58f93e0108fc144d296b20efb94f31c6a80d8&l=119

Comment 2 by sky@chromium.org, Jun 5 2018

Blocking: -837684
Owner: sky@chromium.org
Status: Started (was: Available)
Summary: MoveEventHandler should be --mash specific (was: Wire up non-client cursors in window-service as a library)
In looking at this a bit more, we shouldn't need MoveEventHandler at all for ws2. I'll make this bug become that.
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3af7b2a2028fc9d5f128a06e2b0174c107f29242

commit 3af7b2a2028fc9d5f128a06e2b0174c107f29242
Author: Scott Violet <sky@chromium.org>
Date: Wed Jun 06 14:52:13 2018

chromeos: makes MoveEventHandler --mash specific

It's not applicable to ws2 (because the pre-target handlers installed by
ash take care of it).

BUG= 842295 
TEST=none

Change-Id: I57ae1c684580233233bff13186560c2790f56c79
Reviewed-on: https://chromium-review.googlesource.com/1088128
Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564888}
[modify] https://crrev.com/3af7b2a2028fc9d5f128a06e2b0174c107f29242/ash/wm/move_event_handler.cc
[modify] https://crrev.com/3af7b2a2028fc9d5f128a06e2b0174c107f29242/ash/wm/non_client_frame_controller.cc

Comment 4 by sky@chromium.org, Jun 6 2018

Status: Fixed (was: Started)

Sign in to add a comment