New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 842293 link

Starred by 3 users

Issue metadata

Status: WontFix
Owner:
Closed: Nov 7
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug
Proj-XR
Proj-XR-VR



Sign in to add a comment

Replace UI gl_initialized_ system with a blocking mechanism

Project Member Reported by cjgrant@chromium.org, May 11 2018

Issue description

Michael's tab work posted a CL that made GL initialization synchronous, so the UI can always assume it's initialized.  The CL was temporarily abandoned, but we should still land the GL init rework because it simplifies the UI startup.

Basically, instead of the UI starting, and later being told about its GL context, the UI thread will simply block until the context is ready, and can then proceed to initialize.  Then we can:

- Have VrShell supply a callback to VrShellGL to grab the surface (not give it a pointer on which to call a public method).
- Remove all remaining artifacts of gl_initialized_ (eg. from the background element)
 
Summary: Replace UI gl_initialized_ system with a blocking mechanism (was: Clean up gl_initialized_ cruft in UI)
Description: Show this description
Labels: M-69
Owner: yuqinganniesun@chromium.org
Cc: -mthiesse@chromium.org yuqinganniesun@chromium.org
Owner: mthiesse@chromium.org
CL is here, forgot to add the bug link. https://chromium-review.googlesource.com/c/chromium/src/+/1099610

Leaving this open for now to do the cleanup followup.
Labels: -M-69 Target-70
Status: WontFix (was: Assigned)
Turned out this wasn't easy and maybe not possible due to initialization order issues.

Sign in to add a comment