New issue
Advanced search Search tips

Issue 842292 link

Starred by 1 user

Issue metadata

Status: Duplicate
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

DCHECK in IdentityManager

Project Member Reported by est...@chromium.org, May 11 2018

Issue description

steps:
1. run chrome on linux with --login-manager and google client secret, client id, api key
2. attempt to log into GAIA account with a period in it
3. trip DCHECK

[13551:13551:0511/134854.103082:FATAL:identity_manager.cc(58)] Check failed: signin_manager_->GetAuthenticatedAccountInfo().email == primary_account_info_.email (estade.test@gmail.com vs. estadetest@gmail.com)

This used to work. P1 because it's blocking work from being done, although I can work around it by just removing the DCHECKs.
 

Comment 1 by treib@chromium.org, May 14 2018

Cc: -blundell@chromium.org
Owner: blundell@chromium.org
Status: Assigned (was: Untriaged)
Looks like some kind of canonicalization is happening on one side of the DCHECK but not the other. I think it's fine to just remove that DCHECK for now - we're still verifying that account_id and gaia_id match, which should be good enough. blundell@, WDYT?
Mergedinto: 842041
Status: Duplicate (was: Assigned)
Thanks for reporting this, Evan, and thanks for looking at it, Marc! Your assessment is correct, Marc. Duping this against crbug.com/842041, which was noticed at basically the same time.

Evan: I'll be looking at fixing this with extremely high priority, but in case I don't get in the fix before you start working again, I think that an even easier workaround should be to just input your email address in the canonical form, unless there's some reason that that would defeat the point of what you're working on/testing.
Re: comment #2, the suggestion there should be "just input the email address that the CHECK is expecting to see".

Comment 4 by est...@chromium.org, May 14 2018

FWIW, I tried inputting my email in both forms and it hit the same DCHECK.
Oops, thanks for the correction. The issue is whether Gaia's normalized form of the email matches the form in which the user entered it when creating the account. If the answer is no, it doesn't matter how the user enters it when logging into ChromeOS.

Sign in to add a comment