New issue
Advanced search Search tips

Issue 842282 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Closed: Dec 18
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 2
Type: Bug

Blocking:
issue 581518



Sign in to add a comment

JankTracker: consider tracking per-transform-space

Project Member Reported by skobes@chromium.org, May 11 2018

Issue description

The JankTracker class in http://crrev.com/c/1046155 intersects FragmentData::visual_rect_ with the viewport, but this isn't quite right because visual rects are in the coordinate space of the nearest transform ancestor.  We should figure out how to do the conversion properly.
 

Comment 1 by skobes@chromium.org, May 28 2018

Update: r560283 accounts for transforms by doing coordinate mapping with GeometryMapper.  However, it might be better to track jank scores per transform space.  We should re-examine this idea once we have a better idea of how we're going to handle iframes.

Comment 2 by skobes@chromium.org, May 28 2018

Summary: JankTracker: consider tracking per-transform-space (was: JankTracker should account for transforms)
Ping as it's getting stale.
I don't have any updates here, but I'd consider this low priority since we aren't seeing significant perf cost from JankTracker based on the benchmarks (see  issue 847252 ).
Status: WontFix (was: Assigned)
JankTracker has been at 50% dev/canary for a while and we don't see significant real-world perf impact.

It has also been in the field trial testing config and we have only seen one regression on the perf bots (issue 909795), and I've verified that this issue is not caused by JankTracker's use of GeometryMapper (https://pinpoint-dot-chromeperf.appspot.com/job/16a434e9140000).

I initially thought we might do something similar to this for iframes, which would argue for generalizing.  But we want a page-level UKM that aggregates jank scores from iframes, including OOPIFs.  Therefore this aggregation needs to happen in the browser process.  We are already plumbing jank scores into the browser for each frame separately.  It doesn't make sense to add a separate path to aggregate same-origin iframes on the Blink side.  So iframes aren't a good reason to track separate jank scores per transform space.

Based on the above analysis I am going to close this bug.

Sign in to add a comment