New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 842276 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Mojo DecoderFactory does not accept |target_color_space|

Project Member Reported by sande...@chromium.org, May 11 2018

Issue description

This appears to have been skipped when |target_color_space| was plumbed to software decoders and GpuVideoDecoder.
 

Comment 1 by xhw...@chromium.org, May 11 2018

Cc: xhw...@chromium.org hubbe@chromium.org
I talked to hubbe@ briefly. It seems the target color space comes from the OS and browser, not from the video or demuxer. It can change whenever user changes the device's color profile. Therefore, in most cases it seems fairly reasonable to assume the color space won't change during a playback. If we do want to handle the target color space change, a demuxer config change seems the wrong place to signal it.

With that, I wonder whether it make sense to just pass the target color space when we create our media::Renderer, or media::VideoDecoder, instead of passing it to VideoDecoder::Initialize() as part of VideoDecoderConfig.
Cc: tmathmeyer@chromium.org
+tmathmeyer FYI.
Project Member

Comment 3 by bugdroid1@chromium.org, May 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bc62ef727730eea20834cef443fb35d623a34124

commit bc62ef727730eea20834cef443fb35d623a34124
Author: Dan Sanders <sandersd@chromium.org>
Date: Mon May 14 23:09:50 2018

[media] Plumb |target_color_space| to VdaVideoDecoder.

Bug:  842276 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ibbbca8f7714b644034aa4b95fa444c9c51f973c7
Reviewed-on: https://chromium-review.googlesource.com/1056364
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Dan Sanders <sandersd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558514}
[modify] https://crrev.com/bc62ef727730eea20834cef443fb35d623a34124/media/base/decoder_factory.cc
[modify] https://crrev.com/bc62ef727730eea20834cef443fb35d623a34124/media/base/decoder_factory.h
[modify] https://crrev.com/bc62ef727730eea20834cef443fb35d623a34124/media/gpu/ipc/service/vda_video_decoder.cc
[modify] https://crrev.com/bc62ef727730eea20834cef443fb35d623a34124/media/gpu/ipc/service/vda_video_decoder.h
[modify] https://crrev.com/bc62ef727730eea20834cef443fb35d623a34124/media/gpu/ipc/service/vda_video_decoder_unittest.cc
[modify] https://crrev.com/bc62ef727730eea20834cef443fb35d623a34124/media/mojo/clients/mojo_decoder_factory.cc
[modify] https://crrev.com/bc62ef727730eea20834cef443fb35d623a34124/media/mojo/clients/mojo_decoder_factory.h
[modify] https://crrev.com/bc62ef727730eea20834cef443fb35d623a34124/media/mojo/clients/mojo_video_decoder.cc
[modify] https://crrev.com/bc62ef727730eea20834cef443fb35d623a34124/media/mojo/clients/mojo_video_decoder.h
[modify] https://crrev.com/bc62ef727730eea20834cef443fb35d623a34124/media/mojo/interfaces/BUILD.gn
[modify] https://crrev.com/bc62ef727730eea20834cef443fb35d623a34124/media/mojo/interfaces/video_decoder.mojom
[modify] https://crrev.com/bc62ef727730eea20834cef443fb35d623a34124/media/mojo/services/gpu_mojo_media_client.cc
[modify] https://crrev.com/bc62ef727730eea20834cef443fb35d623a34124/media/mojo/services/gpu_mojo_media_client.h
[modify] https://crrev.com/bc62ef727730eea20834cef443fb35d623a34124/media/mojo/services/mojo_media_client.cc
[modify] https://crrev.com/bc62ef727730eea20834cef443fb35d623a34124/media/mojo/services/mojo_media_client.h
[modify] https://crrev.com/bc62ef727730eea20834cef443fb35d623a34124/media/mojo/services/mojo_video_decoder_service.cc
[modify] https://crrev.com/bc62ef727730eea20834cef443fb35d623a34124/media/mojo/services/mojo_video_decoder_service.h
[modify] https://crrev.com/bc62ef727730eea20834cef443fb35d623a34124/media/mojo/test/mojo_video_decoder_integration_test.cc
[modify] https://crrev.com/bc62ef727730eea20834cef443fb35d623a34124/media/renderers/default_renderer_factory.cc

Status: Fixed (was: Assigned)

Sign in to add a comment