New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 842267 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Feature



Sign in to add a comment

Update the logic in header.js to account for N-up printing

Project Member Reported by xlou@chromium.org, May 11 2018

Issue description

Update the logic in header.js to take N-up parameter into consideration.  For example, if user prints a document with total pages of 4, single sided, and 2-up, the UI element "sheet of paper" will be: Total: 2 sheet of paper.

 

Comment 1 by xlou@chromium.org, May 14 2018

Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, May 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b11094787b7d5e35439c4e8c666335b6942b1a26

commit b11094787b7d5e35439c4e8c666335b6942b1a26
Author: xlou <xlou@chromium.org>
Date: Fri May 18 01:33:53 2018

Update print header message when N-up > 1.

Added support to change the total number of sheets needed for a print
job when N-up > 1.

The Pages Per Sheet feature UI components were added in this CL:
https://chromium-review.googlesource.com/c/chromium/src/+/1050933

Please find N-up chromium feature design doc here:
https://docs.google.com/document/d/1rA91PzWDLh6CFrAupgUwv7XYSIqbSpffEnDEQrpEdEQ/

Bug:  842267 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I9918efe9e664c28cee52734f0757dc25ecac98a7
Reviewed-on: https://chromium-review.googlesource.com/1056494
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Shirleen Lou <xlou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559768}
[modify] https://crrev.com/b11094787b7d5e35439c4e8c666335b6942b1a26/chrome/browser/resources/print_preview/new/header.html
[modify] https://crrev.com/b11094787b7d5e35439c4e8c666335b6942b1a26/chrome/browser/resources/print_preview/new/header.js

Comment 3 by xlou@chromium.org, May 21 2018

Status: Fixed (was: Started)

Sign in to add a comment