New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 842259 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Feature



Sign in to add a comment

Add automated tests for N-up printing feature to preview_generation_test.js and settings_section_test.js

Project Member Reported by xlou@chromium.org, May 11 2018

Issue description

need to add automated tests for N-up printing feature in preview_generation_test.js and settings_section_test.js. This needs to be done as soon as possible, as this UI is being updated fairly regularly and the feature is disabled by default.
 

Comment 1 by xlou@chromium.org, May 21 2018

Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, May 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ef82360a357dff8a1319077295fbf821bf53970e

commit ef82360a357dff8a1319077295fbf821bf53970e
Author: xlou <xlou@chromium.org>
Date: Mon May 21 23:09:27 2018

Add automated tests for newly added Pages Per Sheet feature.

Added test cases in settings_section_tests.js and
preview_generation_test.js.

Added tests in new_print_preview_ui_browsertest.js.

The Pages Per Sheet feature UI components were added in this CL:
https://chromium-review.googlesource.com/c/chromium/src/+/1050933

Bug:  842259 
Change-Id: I16d79548d3fd877a91c4a186e0ef7b9c401eed37
Reviewed-on: https://chromium-review.googlesource.com/1064746
Commit-Queue: Shirleen Lou <xlou@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560396}
[modify] https://crrev.com/ef82360a357dff8a1319077295fbf821bf53970e/chrome/test/data/webui/print_preview/new_print_preview_ui_browsertest.js
[modify] https://crrev.com/ef82360a357dff8a1319077295fbf821bf53970e/chrome/test/data/webui/print_preview/preview_generation_test.js
[modify] https://crrev.com/ef82360a357dff8a1319077295fbf821bf53970e/chrome/test/data/webui/print_preview/settings_section_test.js

Comment 3 by xlou@chromium.org, May 21 2018

Status: Fixed (was: Started)

Sign in to add a comment