Color correction looks wrong with night light enabled |
||
Issue descriptionChrome Version: ToT OS: ChromeOS (Eve) What steps will reproduce the problem? (1) Login to account. (2) Go to chrome://flags and enable "Night Light" What is the expected result? Redish output due to night light. What happens instead? See attached screenshot. Note, I also tested with https://chromium-review.googlesource.com/c/chromium/src/+/1045867 applied to ensure the CTM is reset correctly, though disabling night light doesn't fix it even though the CTM was set to the identity matrix. Though the colors in the image have updated, it still looks like the colors have been inverted.
,
May 14 2018
I'm experiencing the same issue on Eve. Night light on other Chromebooks seem to be working fine.
,
May 14 2018
I can't repro on my eve with ToT. Daniel, do you mind attaching the output of modetest when you see the inverted colors?
,
May 14 2018
It's attached in initial post. I did another test with drm-tests (wrote another custom test) and that seemed to be correct. I'll upload the test since it is useful. I'll try to sync again and see if I can reproduce it again with Chrome.
,
May 14 2018
,
May 14 2018
Can't reproduce it anymore. Now I'm wondering if gamma was set by something else I was running (atomictest). We don't have anything to reset gamma/degamma. We'll need to do something better for setting CTM without setting gamma/degamma and reset gamma/degamma if we're passing in empty gamma/degamma LUT. Daniele shall we close this and file a new bug for resetting state?
,
May 14 2018
Confirmed, this is caused by running gamma_test. Killing it early then running chrome.
,
May 14 2018
Nice find, yes, we need to set that.
,
May 14 2018
afakhry@ is already looking into setting the gamma/degamma every time we set a CTM. Should we set a gamma/degamma when the ui starts? In practice this issue is never going to affect users. |
||
►
Sign in to add a comment |
||
Comment 1 by dnicoara@chromium.org
, May 11 2018