New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 842250 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Answers without an image are layed out as if one was expected

Project Member Reported by jdonnelly@chromium.org, May 11 2018

Issue description

This issue is present in Canary. See attached screenshot.
 
sports-answer.PNG
8.2 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, May 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/935cc6fd5801d13308e3fba535059dd941c6b622

commit 935cc6fd5801d13308e3fba535059dd941c6b622
Author: Dave Schuyler <dschuyler@chromium.org>
Date: Tue May 15 01:59:16 2018

[Omnibox] fix blank space for answer image

This CL doesn't show a blank space for answers that will not have images
(for example a stock price) while still showing for those that do (such
as a weather result).

Bug:  842250 
Change-Id: Ia53e28124321267cd520407fb97cbac4dded0f06
Reviewed-on: https://chromium-review.googlesource.com/1055853
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558582}
[modify] https://crrev.com/935cc6fd5801d13308e3fba535059dd941c6b622/chrome/browser/ui/views/omnibox/omnibox_match_cell_view.cc
[modify] https://crrev.com/935cc6fd5801d13308e3fba535059dd941c6b622/chrome/browser/ui/views/omnibox/omnibox_result_view.cc

Status: Fixed (was: Assigned)
Cc: phanindra.mandapaka@chromium.org
Labels: TE-Verified-68.0.3432.0 TE-Verified-M68
Able to reproduce the issue on chrome version 68.0.3430.0(build without fix)
Verified the fix on Windows 10, Mac 10.13.3 and Ubuntu 14.04 using Chrome version #68.0.3432.0 as per the comment #0.
Attaching screenshot for reference.
Observed that "there is no blank space for answer image."
Hence, the fix is working as expected, adding Verified labels

Thanks...!
842250.png
105 KB View Download

Sign in to add a comment