Pinpoint should stop cc-ing reviewers on bugs |
||
Issue descriptionIn the postmortem for bug 739133 , we decided to cc CL reviewers when pinpoint finds the root cause of the regression. The intention was that the reviewers are the people most able to understand the performance of the code, and help if the author is OOO (as the author was in the case of that bug). But it turns out that this is causing a lot of additional bug mail for people who review many mass refactorings. Note that we're working on pinpoint posting a comment on the original CL instead in https://github.com/catapult-project/catapult/issues/4356.
,
May 12 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a5d0a26402764d6d578092c1d9b92bee947aa9a1 commit a5d0a26402764d6d578092c1d9b92bee947aa9a1 Author: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Sat May 12 09:08:01 2018 Roll src/third_party/catapult/ 1d2e7600b..b424d15a6 (6 commits) https://chromium.googlesource.com/catapult.git/+log/1d2e7600b0b4..b424d15a6070 $ git log 1d2e7600b..b424d15a6 --date=short --no-merges --format='%ad %ae %s' 2018-05-11 sammiequon Disable cache_temperature tests on chromeos. 2018-05-11 sullivan Update bug assigns to autorollers to assign to sheriff. 2018-05-11 simonhatch Dashboard - Remove some old logging from graph_data. 2018-05-11 dtu [pinpoint] Don't CC reviewers on bug comments. 2018-05-10 simonhatch Dashboard - Add some logging around /add_histograms. 2018-05-11 simonhatch Pinpoint - Update results2 generator for job format. Created with: roll-dep src/third_party/catapult BUG= chromium:830667 , chromium:842248 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: I6cfe1c7f4f7b7be60b505b4cae00b27cef8a66fc Reviewed-on: https://chromium-review.googlesource.com/1056471 Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#558127} [modify] https://crrev.com/a5d0a26402764d6d578092c1d9b92bee947aa9a1/DEPS
,
May 22 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, May 11 2018