Fix frame viewer tracing |
|||||||||
Issue descriptionFrame viewer tracing (https://www.chromium.org/developers/how-tos/trace-event-profiling-tool/frame-viewer) seems very broken for now, at least: - Unable to show the contents of a frame. When a cc::LayerTreeHostImpl is selected, the viewer area shows nothing but "No tree". - Invalidation annotation doesn't work because GraphicsLayerDebugInfo::AppendAnnotatedInvalidateRect() is not called in SPv175. - The documentation needs update.
,
May 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/81f6c4d7972a3cb982b8fbb05026b96d8d2467f2 commit 81f6c4d7972a3cb982b8fbb05026b96d8d2467f2 Author: Xianzhu Wang <wangxianzhu@chromium.org> Date: Thu May 17 19:23:54 2018 [PE] Cleanup cc::Layer debug info - Remove blink::GraphicsLayerDebugInfo::main_thread_scrolling_reasons_ and its plumbing (cc::LayerClient::didUpdateMainThreadScrollingReasons()). Now we get it directly from cc::LayerImpl. - Change the return value of cc::LayerClient::TakeDebugInfo() to std::unique_ptr<base::trace_event::TracedValue> to simplify handling of the debug info which is now added into the layer's traced value with a new name "debug_info" instead of merging into the layer's traced value. - Remove the broken annotated invalidation tracking from blink::GraphicsLayerDebugInfo. Will fix the feature later. Also removed blink::FirstPaintInvalidationTracking. The change won't break existing features because for now the debug info data is either not used by the trace viewer or is used in a feature that is not working properly. --show-repaint-rects feature won't be affected because it uses data in cc instead of GraphicsLayerDebugInfo. See https://cs.chromium.org/chromium/src/third_party/catapult/tracing/tracing/extras/chrome/cc/layer_impl.html?q=layer_impl.html&sq=package:chromium&g=0&l=1 and https://cs.chromium.org/chromium/src/third_party/catapult/tracing/tracing/ui/extras/chrome/cc/layer_picker.html?rcl=03db8a6e5bb1eabfcbd88becac24c967597ed5bb&l=156 for the current usages of the debug info data in trace viewer. Bug: 842238 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I0bbb2c99842b0b22589a10d27d70e41eb1a6dc4a Reviewed-on: https://chromium-review.googlesource.com/1055813 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by: Ian Vollick <vollick@chromium.org> Reviewed-by: David Bokan <bokan@chromium.org> Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#559637} [modify] https://crrev.com/81f6c4d7972a3cb982b8fbb05026b96d8d2467f2/cc/BUILD.gn [add] https://crrev.com/81f6c4d7972a3cb982b8fbb05026b96d8d2467f2/cc/input/main_thread_scrolling_reason.cc [modify] https://crrev.com/81f6c4d7972a3cb982b8fbb05026b96d8d2467f2/cc/input/main_thread_scrolling_reason.h [add] https://crrev.com/81f6c4d7972a3cb982b8fbb05026b96d8d2467f2/cc/input/main_thread_scrolling_reason_unittest.cc [modify] https://crrev.com/81f6c4d7972a3cb982b8fbb05026b96d8d2467f2/cc/layers/layer.cc [modify] https://crrev.com/81f6c4d7972a3cb982b8fbb05026b96d8d2467f2/cc/layers/layer.h [modify] https://crrev.com/81f6c4d7972a3cb982b8fbb05026b96d8d2467f2/cc/layers/layer_client.h [modify] https://crrev.com/81f6c4d7972a3cb982b8fbb05026b96d8d2467f2/cc/layers/layer_impl.cc [modify] https://crrev.com/81f6c4d7972a3cb982b8fbb05026b96d8d2467f2/cc/layers/layer_impl.h [modify] https://crrev.com/81f6c4d7972a3cb982b8fbb05026b96d8d2467f2/cc/test/mock_layer_client.h [modify] https://crrev.com/81f6c4d7972a3cb982b8fbb05026b96d8d2467f2/third_party/blink/renderer/core/exported/web_view_impl.cc [modify] https://crrev.com/81f6c4d7972a3cb982b8fbb05026b96d8d2467f2/third_party/blink/renderer/core/frame/local_frame_view.cc [modify] https://crrev.com/81f6c4d7972a3cb982b8fbb05026b96d8d2467f2/third_party/blink/renderer/platform/BUILD.gn [delete] https://crrev.com/d7a51a3ace14ef6cf2d90ccd8377a6b754a0e975/third_party/blink/renderer/platform/graphics/first_paint_invalidation_tracking.cc [delete] https://crrev.com/d7a51a3ace14ef6cf2d90ccd8377a6b754a0e975/third_party/blink/renderer/platform/graphics/first_paint_invalidation_tracking.h [modify] https://crrev.com/81f6c4d7972a3cb982b8fbb05026b96d8d2467f2/third_party/blink/renderer/platform/graphics/graphics_layer.cc [modify] https://crrev.com/81f6c4d7972a3cb982b8fbb05026b96d8d2467f2/third_party/blink/renderer/platform/graphics/graphics_layer.h [delete] https://crrev.com/d7a51a3ace14ef6cf2d90ccd8377a6b754a0e975/third_party/blink/renderer/platform/graphics/graphics_layer_debug_info.cc [delete] https://crrev.com/d7a51a3ace14ef6cf2d90ccd8377a6b754a0e975/third_party/blink/renderer/platform/graphics/graphics_layer_debug_info.h [modify] https://crrev.com/81f6c4d7972a3cb982b8fbb05026b96d8d2467f2/third_party/blink/renderer/platform/graphics/paint/scroll_paint_property_node.cc [modify] https://crrev.com/81f6c4d7972a3cb982b8fbb05026b96d8d2467f2/ui/compositor/layer.cc [modify] https://crrev.com/81f6c4d7972a3cb982b8fbb05026b96d8d2467f2/ui/compositor/layer.h [modify] https://crrev.com/81f6c4d7972a3cb982b8fbb05026b96d8d2467f2/ui/compositor/overscroll/scroll_input_handler.h
,
May 18 2018
,
May 18 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/91515b6df3aea22c8e7e09091a8f7e4c83752c51 commit 91515b6df3aea22c8e7e09091a8f7e4c83752c51 Author: Xianzhu Wang <wangxianzhu@chromium.org> Date: Fri May 18 21:41:10 2018 [SPv175+] Fix raster invalidation rect plumbing for trace viewer Bug: 842238 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I05e248f2f5f417d32d75adb8f05a4853d22f4106 Reviewed-on: https://chromium-review.googlesource.com/1063550 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#560055} [modify] https://crrev.com/91515b6df3aea22c8e7e09091a8f7e4c83752c51/cc/layers/layer.h [modify] https://crrev.com/91515b6df3aea22c8e7e09091a8f7e4c83752c51/third_party/blink/renderer/core/BUILD.gn [add] https://crrev.com/91515b6df3aea22c8e7e09091a8f7e4c83752c51/third_party/blink/renderer/core/paint/raster_invalidation_test.cc [modify] https://crrev.com/91515b6df3aea22c8e7e09091a8f7e4c83752c51/third_party/blink/renderer/platform/graphics/compositing/composited_layer_raster_invalidator.cc [modify] https://crrev.com/91515b6df3aea22c8e7e09091a8f7e4c83752c51/third_party/blink/renderer/platform/graphics/compositing/content_layer_client_impl.cc [modify] https://crrev.com/91515b6df3aea22c8e7e09091a8f7e4c83752c51/third_party/blink/renderer/platform/graphics/compositing/content_layer_client_impl.h [modify] https://crrev.com/91515b6df3aea22c8e7e09091a8f7e4c83752c51/third_party/blink/renderer/platform/graphics/graphics_layer.cc [modify] https://crrev.com/91515b6df3aea22c8e7e09091a8f7e4c83752c51/third_party/blink/renderer/platform/graphics/paint/paint_controller.cc [modify] https://crrev.com/91515b6df3aea22c8e7e09091a8f7e4c83752c51/third_party/blink/renderer/platform/graphics/paint/raster_invalidation_tracking.cc [modify] https://crrev.com/91515b6df3aea22c8e7e09091a8f7e4c83752c51/third_party/blink/renderer/platform/graphics/paint/raster_invalidation_tracking.h
,
May 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6df3d98af9b360383e7fbc0e5cf3c4319a187c7d commit 6df3d98af9b360383e7fbc0e5cf3c4319a187c7d Author: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Sat May 19 01:39:00 2018 Roll src/third_party/catapult/ 18ba341db..669dcb14a (2 commits) https://chromium.googlesource.com/catapult.git/+log/18ba341dbc65..669dcb14ae89 $ git log 18ba341db..669dcb14a --date=short --no-merges --format='%ad %ae %s' 2018-05-18 wangxianzhu [trace-viewer] Fix "no tree" error in layer quad stack view 2018-05-18 wangxianzhu [trace-viewer] Fix exception when rasterizing zero-sized picture Created with: roll-dep src/third_party/catapult BUG= chromium:842238 , chromium:842238 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: I101bb0f8fb104d8f69aaf0e96bc5b8ac75c7e9ab Reviewed-on: https://chromium-review.googlesource.com/1066930 Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#560139} [modify] https://crrev.com/6df3d98af9b360383e7fbc0e5cf3c4319a187c7d/DEPS
,
May 21 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7437045138faa8fb24b881a4a125555e775f8b2c commit 7437045138faa8fb24b881a4a125555e775f8b2c Author: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Mon May 21 21:47:47 2018 Roll src/third_party/catapult/ 5b4ef865e..5926c612e (2 commits) https://chromium.googlesource.com/catapult.git/+log/5b4ef865e888..5926c612e546 $ git log 5b4ef865e..5926c612e --date=short --no-merges --format='%ad %ae %s' 2018-05-18 dtu [pinpoint] Store `comparison_mode` in JobState. 2018-05-21 wangxianzhu [trace-viewer] Update according to chrome side Frame Viewer trace format Created with: roll-dep src/third_party/catapult BUG= chromium:842238 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: I276a53c887b39261686e2c0922c94b6dda906bb0 Reviewed-on: https://chromium-review.googlesource.com/1067777 Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#560346} [modify] https://crrev.com/7437045138faa8fb24b881a4a125555e775f8b2c/DEPS
,
May 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a015aab1bbb8e85f09b279bfb1d7d616d947c030 commit a015aab1bbb8e85f09b279bfb1d7d616d947c030 Author: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Wed May 23 23:59:05 2018 Roll src/third_party/catapult/ 8dd790d49..f1e34db09 (1 commit) https://chromium.googlesource.com/catapult.git/+log/8dd790d49a52..f1e34db090a1 $ git log 8dd790d49..f1e34db09 --date=short --no-merges --format='%ad %ae %s' 2018-05-23 wangxianzhu Fix frame viewer ui issues Created with: roll-dep src/third_party/catapult BUG= chromium:842238 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I9df8041171da342c420309e0267c3103c4b87267 Reviewed-on: https://chromium-review.googlesource.com/1070651 Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#561318} [modify] https://crrev.com/a015aab1bbb8e85f09b279bfb1d7d616d947c030/DEPS
,
May 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c867cf2ebb5f4fda36a5fe8f6dfd938fa9d9794b commit c867cf2ebb5f4fda36a5fe8f6dfd938fa9d9794b Author: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Fri May 25 18:59:51 2018 Roll src/third_party/catapult/ 0e9738361..0ceb1ecce (1 commit) https://chromium.googlesource.com/catapult.git/+log/0e97383613e5..0ceb1eccef76 $ git log 0e9738361..0ceb1ecce --date=short --no-merges --format='%ad %ae %s' 2018-05-23 wangxianzhu [Tracing UI] Fix drag_handle when there are size constraints Created with: roll-dep src/third_party/catapult BUG= chromium:842238 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Ic57d0a62391b55de1ac459e9bbc2ce6da95ca4f5 Reviewed-on: https://chromium-review.googlesource.com/1072459 Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#561961} [modify] https://crrev.com/c867cf2ebb5f4fda36a5fe8f6dfd938fa9d9794b/DEPS
,
May 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4a160f0705332ca10dd0baa009e9880c437f9ca4 commit 4a160f0705332ca10dd0baa009e9880c437f9ca4 Author: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Fri May 25 21:33:29 2018 Roll src/third_party/catapult/ 0ceb1ecce..393b0fd9c (1 commit) https://chromium.googlesource.com/catapult.git/+log/0ceb1eccef76..393b0fd9c739 $ git log 0ceb1ecce..393b0fd9c --date=short --no-merges --format='%ad %ae %s' 2018-05-23 wangxianzhu [Tracing UI] Use ResizeObserver for picture chart resizing Created with: roll-dep src/third_party/catapult BUG= chromium:842238 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I1a64cd37f4324f1a7e07e206129016c8dca424c0 Reviewed-on: https://chromium-review.googlesource.com/1073644 Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#562019} [modify] https://crrev.com/4a160f0705332ca10dd0baa009e9880c437f9ca4/DEPS
,
May 26 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e31fcbd21d51905371112cfd552a352b0c598a93 commit e31fcbd21d51905371112cfd552a352b0c598a93 Author: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Sat May 26 01:11:26 2018 Roll src/third_party/catapult/ 393b0fd9c..0043a4a25 (2 commits) https://chromium.googlesource.com/catapult.git/+log/393b0fd9c739..0043a4a25462 $ git log 393b0fd9c..0043a4a25 --date=short --no-merges --format='%ad %ae %s' 2018-05-25 wangxianzhu [Tracing UI] Fix raster task view 2018-05-25 wangxianzhu [Tracing UI] Don't show "View in Picture Debugger" when not available Created with: roll-dep src/third_party/catapult BUG= chromium:842238 , chromium:842238 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I0bebab1c91c57f8723cfdd833b7cafdd6fc97521 Reviewed-on: https://chromium-review.googlesource.com/1074272 Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#562092} [modify] https://crrev.com/e31fcbd21d51905371112cfd552a352b0c598a93/DEPS
,
May 26 2018
Most of the fixes were landed before the M68 branch point, but several missed. It's good to let M68 have all of the fixes.
,
May 27 2018
This bug requires manual review: DEPS changes referenced in bugdroid comments. Please contact the milestone owner if you have questions. Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 27 2018
All of the CLs in third_party/catapult rolled into chromium after the branch point are for this bug only: commit 4a160f0705332ca10dd0baa009e9880c437f9ca4 Author: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Fri May 25 21:33:29 2018 +0000 Roll src/third_party/catapult/ 0ceb1ecce..393b0fd9c (1 commit) https://chromium.googlesource.com/catapult.git/+log/0ceb1eccef76..393b0fd9c739 $ git log 0ceb1ecce..393b0fd9c --date=short --no-merges --format='%ad %ae %s' 2018-05-23 wangxianzhu [Tracing UI] Use ResizeObserver for picture chart resizing Cr-Commit-Position: refs/heads/master@{#562019} commit c867cf2ebb5f4fda36a5fe8f6dfd938fa9d9794b Author: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Fri May 25 18:59:51 2018 +0000 Roll src/third_party/catapult/ 0e9738361..0ceb1ecce (1 commit) https://chromium.googlesource.com/catapult.git/+log/0e97383613e5..0ceb1eccef76 $ git log 0e9738361..0ceb1ecce --date=short --no-merges --format='%ad %ae %s' 2018-05-23 wangxianzhu [Tracing UI] Fix drag_handle when there are size constraints Cr-Commit-Position: refs/heads/master@{#561961} commit d7792e6bf0408c55cb3063beca829604e9ea2185 Author: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Fri May 25 03:10:07 2018 +0000 Roll src/third_party/catapult/ c02f8a850..0e9738361 (1 commit) https://chromium.googlesource.com/catapult.git/+log/c02f8a85059d..0e97383613e5 $ git log c02f8a850..0e9738361 --date=short --no-merges --format='%ad %ae %s' 2018-05-24 wangxianzhu [Tracing] Remove unused resize_sensor.html and css-element-queries Cr-Commit-Position: refs/heads/master@{#561751}
,
May 29 2018
,
May 29 2018
Approving merge to M68. Branch:3440
,
May 29 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e16458cef55ae2734d17a5e23e2bfe0b4da833f7 commit e16458cef55ae2734d17a5e23e2bfe0b4da833f7 Author: Xianzhu Wang <wangxianzhu@chromium.org> Date: Tue May 29 20:25:58 2018 Roll src/third_party/catapult/ c02f8a850..0e9738361 (1 commit) https://chromium.googlesource.com/catapult.git/+log/c02f8a85059d..0e97383613e5 $ git log c02f8a850..0e9738361 --date=short --no-merges --format='%ad %ae %s' 2018-05-24 wangxianzhu [Tracing] Remove unused resize_sensor.html and css-element-queries Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com, sullivan@chromium.org (cherry picked from commit d7792e6bf0408c55cb3063beca829604e9ea2185) Change-Id: I0b40463945f848bec8bd0677cd054a2400191428 Reviewed-on: https://chromium-review.googlesource.com/1072960 Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Original-Commit-Position: refs/heads/master@{#561751} Bug: 842238 Reviewed-on: https://chromium-review.googlesource.com/1077086 Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/branch-heads/3440@{#35} Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733} [modify] https://crrev.com/e16458cef55ae2734d17a5e23e2bfe0b4da833f7/DEPS
,
May 29 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5cb6ed5925048f82b86ef257b51ddc3e06acbb98 commit 5cb6ed5925048f82b86ef257b51ddc3e06acbb98 Author: Xianzhu Wang <wangxianzhu@chromium.org> Date: Tue May 29 20:27:16 2018 Roll src/third_party/catapult/ 0e9738361..0ceb1ecce (1 commit) https://chromium.googlesource.com/catapult.git/+log/0e97383613e5..0ceb1eccef76 $ git log 0e9738361..0ceb1ecce --date=short --no-merges --format='%ad %ae %s' 2018-05-23 wangxianzhu [Tracing UI] Fix drag_handle when there are size constraints Created with: roll-dep src/third_party/catapult BUG= chromium:842238 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com, sullivan@chromium.org (cherry picked from commit c867cf2ebb5f4fda36a5fe8f6dfd938fa9d9794b) Change-Id: Ic57d0a62391b55de1ac459e9bbc2ce6da95ca4f5 Reviewed-on: https://chromium-review.googlesource.com/1072459 Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Original-Commit-Position: refs/heads/master@{#561961} Reviewed-on: https://chromium-review.googlesource.com/1077167 Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/branch-heads/3440@{#36} Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733} [modify] https://crrev.com/5cb6ed5925048f82b86ef257b51ddc3e06acbb98/DEPS
,
May 29 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c93c9adc2840f9cd04313d0b3b73bc8aedf1fedc commit c93c9adc2840f9cd04313d0b3b73bc8aedf1fedc Author: Xianzhu Wang <wangxianzhu@chromium.org> Date: Tue May 29 20:28:13 2018 Roll src/third_party/catapult/ 0ceb1ecce..393b0fd9c (1 commit) https://chromium.googlesource.com/catapult.git/+log/0ceb1eccef76..393b0fd9c739 $ git log 0ceb1ecce..393b0fd9c --date=short --no-merges --format='%ad %ae %s' 2018-05-23 wangxianzhu [Tracing UI] Use ResizeObserver for picture chart resizing Created with: roll-dep src/third_party/catapult BUG= chromium:842238 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com, sullivan@chromium.org (cherry picked from commit 4a160f0705332ca10dd0baa009e9880c437f9ca4) Change-Id: I1a64cd37f4324f1a7e07e206129016c8dca424c0 Reviewed-on: https://chromium-review.googlesource.com/1073644 Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Original-Commit-Position: refs/heads/master@{#562019} Reviewed-on: https://chromium-review.googlesource.com/1077169 Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/branch-heads/3440@{#37} Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733} [modify] https://crrev.com/c93c9adc2840f9cd04313d0b3b73bc8aedf1fedc/DEPS
,
May 29 2018
,
Jun 4 2018
,
Jun 4 2018
Issue 663533 has been merged into this issue. |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by wangxianzhu@chromium.org
, May 17 2018For the attached test case, Frame Viewer stuck for a while and print the following errors when clicking on a cc::LayerTreeHostImpl circle in the captured Frame Viewer trace: ncaught DOMException: Failed to execute 'createImageData' on 'CanvasRenderingContext2D': The source width is 0. at Picture.rasterize (chrome://tracing/tracing.js:5518:384) at DisplayItemListSnapshot.rasterize (chrome://tracing/tracing.js:5545:605) at HTMLElement.computePictureLoadingStatus_ (chrome://tracing/tracing.js:5725:207) at HTMLElement.updateContents_ (chrome://tracing/tracing.js:5709:19) at HTMLElement.set howToShowTiles [as howToShowTiles] (chrome://tracing/tracing.js:5706:31) at Object.createSelector (chrome://tracing/tracing.js:1374:292) at HTMLElement.updateTilesSelector_ (chrome://tracing/tracing.js:5723:27) at HTMLElement.regenerateContent (chrome://tracing/tracing.js:5706:409) at HTMLElement.regenerateContent (chrome://tracing/tracing.js:5766:2145) at HTMLElement.set objectSnapshot [as objectSnapshot] (chrome://tracing/tracing.js:5772:97) RangeError: Failed to execute 'createImageData' on 'CanvasRenderingContext2D': Out of memory at ImageData creation at Picture.rasterize (tracing.js:5518) at DisplayItemListSnapshot.rasterize (tracing.js:5545) at HTMLElement.computePictureLoadingStatus_ (tracing.js:5725) at HTMLElement.updateContents_ (tracing.js:5709) at runTask (tracing.js:2175) at processRequests (tracing.js:2177)983 bytes
983 bytes View Download