[MD-Refresh] Background Tab Title issue |
|||
Issue descriptionChrome Version: Canary 68.0.3427.0 OS: macOS 10.12 & 10.13 (Not sure if this is also the case on other platforms.) What steps will reproduce the problem? (1) Enable MacViews-Browser & MD-Refresh (2) Open some tabs and visit pages with long tab titles (3) Shrink the window to a smaller state (4) Hover over a background tab, so that the close button appears (5) Hover away from that tab, so that the close button disappears again Actual: In Step (4) the title has no reserved space for the close button until you hover over it. In Step (5) the title keeps in shrinked state and shows the reserved space. Expeced: In Step (5) the title goes back to the full tab width or it could always (also in Step (4)) show a reserved space. This happened after https://chromium-review.googlesource.com/1052382. A screencast is attached. Resizing the window fixes the problem, until you hover again over a background tab. Thanks, Mehmet
,
May 18 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cfb3bc151e15c5fae869268f5d11a143726733ec commit cfb3bc151e15c5fae869268f5d11a143726733ec Author: Allen Bauer <kylixrd@chromium.org> Date: Fri May 18 17:47:21 2018 Material Refresh - Call Layout() instead of SchedulePaint() on animation end. Bug: 842237 Change-Id: Ie031fbf3518a49e50de74621f98b474b8a103e21 Reviewed-on: https://chromium-review.googlesource.com/1060393 Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Commit-Queue: Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#559948} [modify] https://crrev.com/cfb3bc151e15c5fae869268f5d11a143726733ec/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/cfb3bc151e15c5fae869268f5d11a143726733ec/chrome/browser/ui/ash/tab_scrubber.cc [rename] https://crrev.com/cfb3bc151e15c5fae869268f5d11a143726733ec/chrome/browser/ui/views/tabs/glow_hover_controller.cc [rename] https://crrev.com/cfb3bc151e15c5fae869268f5d11a143726733ec/chrome/browser/ui/views/tabs/glow_hover_controller.h [modify] https://crrev.com/cfb3bc151e15c5fae869268f5d11a143726733ec/chrome/browser/ui/views/tabs/tab.cc [modify] https://crrev.com/cfb3bc151e15c5fae869268f5d11a143726733ec/chrome/browser/ui/views/tabs/tab.h [modify] https://crrev.com/cfb3bc151e15c5fae869268f5d11a143726733ec/ui/views/BUILD.gn
,
May 18 2018
,
May 21 2018
Tested the issue on Mac 10.13 using Chrome version M68 - 68.0.3436.0 as per the issue mentioned in original comment. Observed that issue is working as intended (After close button 'X' is dismissed the emptied space is covered with tab name - the title goes back to the full tab width as earlier). Hence adding TE-Verified label. Attached the screencast for reference. Thank you! |
|||
►
Sign in to add a comment |
|||
Comment 1 by spqc...@chromium.org
, May 12 2018