New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 842233 link

Starred by 6 users
Status: Fixed
Owner:
ryansturm@chromium.org
Closed: Nov 29
Cc:
robertogden@chromium.org
jam@chromium.org
reillyg@chromium.org
clamy@chromium.org
cduvall@chromium.org
sclit...@chromium.org
ryansturm@chromium.org
bengr@chromium.org
█ jcivelli@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 827531
issue 755626
issue 864187
issue 891752



Sign in to add a comment

Servicification of Previews

Project Member Reported by ryansturm@chromium.org, May 11 2018 
Previews relies on having an URLRequest in a lot of APIs. It relies on getting the URL as well as storing UserData on the request. The former is easy for s13n, but the latter is a little more complicated. To fully understand this problem, we'd need to understand data_reduction_proxy servicification. Likely, all of the decision making could occur earlier in the navigation lifetime on the UI thread, but coordinating those decisions and getting them to the actual implementors may be more complex.

Comment 1 by bengr@chromium.org, May 11 2018

Cc: reillyg@chromium.org
Status: Available (was: Untriaged)
I cc'd Reilly, who hopefully can tell us the plan for replacing UserData.

Comment 2 by reillyg@chromium.org, May 15 2018

Cc: jcivelli@chromium.org
How much of of the Previews feature can be moved into Blink, built on top of public Blink APIs or otherwise implemented in content/renderer before a URLLoader is created to send the request to the Network Service? Waiting until a net::URLRequest has been created seems like a layering violation.

The work I've been doing has been working towards the goal of allowing the browser process to configure the Network Service with the information it needs for making the appropriate network requests (like whether to try to use the Data Reduction Proxy) while leaving all other policy decisions up to the code making the request.

Comment 3 by ryansturm@chromium.org, May 15 2018

Cc: robertogden@chromium.org
Right now, Previews mostly acts on navigations, so I think the Previews decisions would likely be in the browser process (not in the network service though). Unless Browser-side navigation is being removed, we likely would need to move the previews decisions to earlier in the navigation pathway, and during a redirect, we'd add new checks for whether the preview is still allowed based on URL. The previews decision for a main frame request affect the data reduction proxy headers (and whether we use an offline page URLLoader instead of the net URLLoader -- I believe this is the plan at least for offline pages). However, other Preview types like no-script of LoFi affect things only in blink/ so those previews should be completely separate from the network service.

+robertogden

Robert is working on a post-s13n approach to a new type of preview that also cares about redirects (and re-writes the URL when it triggers), but likely would follow the same pattern as the previews described above.

Comment 4 by reillyg@chromium.org, May 15 2018 

Sorry, I forgot to mention browser-side navigation. For requests from browser-side navigation as was as sub-resource requests we have a mechanism called URLLoaderThrottle. These objects are owned by the request so if you need per-request state this is the right place to put it.

Comment 5 by ryansturm@chromium.org, May 15 2018 

I suspected that might be the case. I think that will work for us as long as we can rewrite headers from there (DRP dependent headers), and we can re-write the URL for the new stuff Robertogden is adding.

Comment 6 by robertogden@chromium.org, May 15 2018 

@reillyg it looks like URLLoaderThrottle::WillStartRequest doesn't get called for redirects (eg http://facebook.com -> https://www.facebook.com)

Is that something that can/will be changed or should we be looking in a different place to intervene on navigations and have visibility into redirects?

Comment 7 by reillyg@chromium.org, May 15 2018 

To intervene on navigations what you're looking for is content::NavigationThrottle.

Comment 8 by reillyg@chromium.org, May 15 2018 

Also URLLoaderThrottle::WillRedirectRequest is called for redirects.

Comment 9 by jianli@chromium.org, Jun 4 2018 

FYI, the network servicification of offline pages has been landed. The preview support at OfflinePageURLLoader::ShouldAllowPreview needs to be implemented.
Project Member

Comment 10 by bugdroid1@chromium.org, Jul 6 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b26bb7aa1b0d87c7fb69d1f41b66137cf6fd67e9

commit b26bb7aa1b0d87c7fb69d1f41b66137cf6fd67e9
Author: Ryan Sturm <ryansturm@chromium.org>
Date: Fri Jul 06 18:32:11 2018

Rename: PreviewsIOData -> PreviewsDeciderImpl

This change is part of a larger refactor that will move all
functionality of PreviewsIOData to the UI thread, and move previews
decisions to an earlier point in the navigation path (on the UI thread).

Bug:  842233 
Change-Id: Ia2a1aeb001fb223535089ccae5410f5611927e7a
Reviewed-on: https://chromium-review.googlesource.com/1125292
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573022}
[modify] https://crrev.com/b26bb7aa1b0d87c7fb69d1f41b66137cf6fd67e9/chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc
[modify] https://crrev.com/b26bb7aa1b0d87c7fb69d1f41b66137cf6fd67e9/chrome/browser/previews/previews_infobar_delegate_unittest.cc
[modify] https://crrev.com/b26bb7aa1b0d87c7fb69d1f41b66137cf6fd67e9/chrome/browser/previews/previews_service.cc
[modify] https://crrev.com/b26bb7aa1b0d87c7fb69d1f41b66137cf6fd67e9/chrome/browser/previews/previews_service.h
[modify] https://crrev.com/b26bb7aa1b0d87c7fb69d1f41b66137cf6fd67e9/chrome/browser/previews/previews_service_unittest.cc
[modify] https://crrev.com/b26bb7aa1b0d87c7fb69d1f41b66137cf6fd67e9/chrome/browser/profiles/profile_impl_io_data.cc
[modify] https://crrev.com/b26bb7aa1b0d87c7fb69d1f41b66137cf6fd67e9/chrome/browser/profiles/profile_io_data.cc
[modify] https://crrev.com/b26bb7aa1b0d87c7fb69d1f41b66137cf6fd67e9/chrome/browser/profiles/profile_io_data.h
[modify] https://crrev.com/b26bb7aa1b0d87c7fb69d1f41b66137cf6fd67e9/chrome/browser/ui/webui/interventions_internals/interventions_internals_page_handler_unittest.cc
[modify] https://crrev.com/b26bb7aa1b0d87c7fb69d1f41b66137cf6fd67e9/components/previews/content/BUILD.gn
[rename] https://crrev.com/b26bb7aa1b0d87c7fb69d1f41b66137cf6fd67e9/components/previews/content/previews_decider_impl.cc
[rename] https://crrev.com/b26bb7aa1b0d87c7fb69d1f41b66137cf6fd67e9/components/previews/content/previews_decider_impl.h
[rename] https://crrev.com/b26bb7aa1b0d87c7fb69d1f41b66137cf6fd67e9/components/previews/content/previews_decider_impl_unittest.cc
[modify] https://crrev.com/b26bb7aa1b0d87c7fb69d1f41b66137cf6fd67e9/components/previews/content/previews_ui_service.cc
[modify] https://crrev.com/b26bb7aa1b0d87c7fb69d1f41b66137cf6fd67e9/components/previews/content/previews_ui_service.h
[modify] https://crrev.com/b26bb7aa1b0d87c7fb69d1f41b66137cf6fd67e9/components/previews/content/previews_ui_service_unittest.cc
[modify] https://crrev.com/b26bb7aa1b0d87c7fb69d1f41b66137cf6fd67e9/components/previews/core/previews_logger.h
Project Member

Comment 11 by bugdroid1@chromium.org, Jul 6 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/51c6c9e19f9b598d5a46c0c2b180d08562752fc1

commit 51c6c9e19f9b598d5a46c0c2b180d08562752fc1
Author: Ryan Sturm <ryansturm@chromium.org>
Date: Fri Jul 06 21:20:02 2018

Revert "Rename: PreviewsIOData -> PreviewsDeciderImpl"

This reverts commit b26bb7aa1b0d87c7fb69d1f41b66137cf6fd67e9.

Reason for revert: missed a change behind offline pages flag.

Original change's description:
> Rename: PreviewsIOData -> PreviewsDeciderImpl
> 
> This change is part of a larger refactor that will move all
> functionality of PreviewsIOData to the UI thread, and move previews
> decisions to an earlier point in the navigation path (on the UI thread).
> 
> Bug:  842233 
> Change-Id: Ia2a1aeb001fb223535089ccae5410f5611927e7a
> Reviewed-on: https://chromium-review.googlesource.com/1125292
> Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
> Reviewed-by: Tarun Bansal <tbansal@chromium.org>
> Reviewed-by: Matt Menke <mmenke@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#573022}

TBR=mmenke@chromium.org,tbansal@chromium.org,ryansturm@chromium.org

Change-Id: I203f23b743caf9f44e681f56be7e892ddafb162d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  842233 
Reviewed-on: https://chromium-review.googlesource.com/1128299
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573074}
[modify] https://crrev.com/51c6c9e19f9b598d5a46c0c2b180d08562752fc1/chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc
[modify] https://crrev.com/51c6c9e19f9b598d5a46c0c2b180d08562752fc1/chrome/browser/previews/previews_infobar_delegate_unittest.cc
[modify] https://crrev.com/51c6c9e19f9b598d5a46c0c2b180d08562752fc1/chrome/browser/previews/previews_service.cc
[modify] https://crrev.com/51c6c9e19f9b598d5a46c0c2b180d08562752fc1/chrome/browser/previews/previews_service.h
[modify] https://crrev.com/51c6c9e19f9b598d5a46c0c2b180d08562752fc1/chrome/browser/previews/previews_service_unittest.cc
[modify] https://crrev.com/51c6c9e19f9b598d5a46c0c2b180d08562752fc1/chrome/browser/profiles/profile_impl_io_data.cc
[modify] https://crrev.com/51c6c9e19f9b598d5a46c0c2b180d08562752fc1/chrome/browser/profiles/profile_io_data.cc
[modify] https://crrev.com/51c6c9e19f9b598d5a46c0c2b180d08562752fc1/chrome/browser/profiles/profile_io_data.h
[modify] https://crrev.com/51c6c9e19f9b598d5a46c0c2b180d08562752fc1/chrome/browser/ui/webui/interventions_internals/interventions_internals_page_handler_unittest.cc
[modify] https://crrev.com/51c6c9e19f9b598d5a46c0c2b180d08562752fc1/components/previews/content/BUILD.gn
[rename] https://crrev.com/51c6c9e19f9b598d5a46c0c2b180d08562752fc1/components/previews/content/previews_io_data.cc
[rename] https://crrev.com/51c6c9e19f9b598d5a46c0c2b180d08562752fc1/components/previews/content/previews_io_data.h
[rename] https://crrev.com/51c6c9e19f9b598d5a46c0c2b180d08562752fc1/components/previews/content/previews_io_data_unittest.cc
[modify] https://crrev.com/51c6c9e19f9b598d5a46c0c2b180d08562752fc1/components/previews/content/previews_ui_service.cc
[modify] https://crrev.com/51c6c9e19f9b598d5a46c0c2b180d08562752fc1/components/previews/content/previews_ui_service.h
[modify] https://crrev.com/51c6c9e19f9b598d5a46c0c2b180d08562752fc1/components/previews/content/previews_ui_service_unittest.cc
[modify] https://crrev.com/51c6c9e19f9b598d5a46c0c2b180d08562752fc1/components/previews/core/previews_logger.h

Comment 12 by ryansturm@chromium.org, Jul 6

Owner: ryansturm@chromium.org
Status: Started (was: Available)
This will land over a few CLs.
Project Member

Comment 13 by bugdroid1@chromium.org, Jul 6 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fa9d12d8a84168a8d776f30f933635a224a6c1f2

commit fa9d12d8a84168a8d776f30f933635a224a6c1f2
Author: Ryan Sturm <ryansturm@chromium.org>
Date: Fri Jul 06 22:48:44 2018

Reland "Rename: PreviewsIOData -> PreviewsDeciderImpl"

This is a reland of b26bb7aa1b0d87c7fb69d1f41b66137cf6fd67e9

Original change's description:
> Rename: PreviewsIOData -> PreviewsDeciderImpl
>
> This change is part of a larger refactor that will move all
> functionality of PreviewsIOData to the UI thread, and move previews
> decisions to an earlier point in the navigation path (on the UI thread).
>
> Bug:  842233 
> Change-Id: Ia2a1aeb001fb223535089ccae5410f5611927e7a
> Reviewed-on: https://chromium-review.googlesource.com/1125292
> Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
> Reviewed-by: Tarun Bansal <tbansal@chromium.org>
> Reviewed-by: Matt Menke <mmenke@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#573022}

Bug:  842233 
Change-Id: Ide3be7f885d53bd295273b64f067d02c8f24e05c

TBR=mmenke@chromium.org, tbansal@chromium.org

Change-Id: Ide3be7f885d53bd295273b64f067d02c8f24e05c
Reviewed-on: https://chromium-review.googlesource.com/1128300
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573101}
[modify] https://crrev.com/fa9d12d8a84168a8d776f30f933635a224a6c1f2/chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc
[modify] https://crrev.com/fa9d12d8a84168a8d776f30f933635a224a6c1f2/chrome/browser/previews/previews_infobar_delegate_unittest.cc
[modify] https://crrev.com/fa9d12d8a84168a8d776f30f933635a224a6c1f2/chrome/browser/previews/previews_service.cc
[modify] https://crrev.com/fa9d12d8a84168a8d776f30f933635a224a6c1f2/chrome/browser/previews/previews_service.h
[modify] https://crrev.com/fa9d12d8a84168a8d776f30f933635a224a6c1f2/chrome/browser/previews/previews_service_unittest.cc
[modify] https://crrev.com/fa9d12d8a84168a8d776f30f933635a224a6c1f2/chrome/browser/profiles/profile_impl_io_data.cc
[modify] https://crrev.com/fa9d12d8a84168a8d776f30f933635a224a6c1f2/chrome/browser/profiles/profile_io_data.cc
[modify] https://crrev.com/fa9d12d8a84168a8d776f30f933635a224a6c1f2/chrome/browser/profiles/profile_io_data.h
[modify] https://crrev.com/fa9d12d8a84168a8d776f30f933635a224a6c1f2/chrome/browser/ui/webui/interventions_internals/interventions_internals_page_handler_unittest.cc
[modify] https://crrev.com/fa9d12d8a84168a8d776f30f933635a224a6c1f2/components/previews/content/BUILD.gn
[rename] https://crrev.com/fa9d12d8a84168a8d776f30f933635a224a6c1f2/components/previews/content/previews_decider_impl.cc
[rename] https://crrev.com/fa9d12d8a84168a8d776f30f933635a224a6c1f2/components/previews/content/previews_decider_impl.h
[rename] https://crrev.com/fa9d12d8a84168a8d776f30f933635a224a6c1f2/components/previews/content/previews_decider_impl_unittest.cc
[modify] https://crrev.com/fa9d12d8a84168a8d776f30f933635a224a6c1f2/components/previews/content/previews_ui_service.cc
[modify] https://crrev.com/fa9d12d8a84168a8d776f30f933635a224a6c1f2/components/previews/content/previews_ui_service.h
[modify] https://crrev.com/fa9d12d8a84168a8d776f30f933635a224a6c1f2/components/previews/content/previews_ui_service_unittest.cc
[modify] https://crrev.com/fa9d12d8a84168a8d776f30f933635a224a6c1f2/components/previews/core/previews_logger.h
Project Member

Comment 14 by bugdroid1@chromium.org, Jul 11 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3154b813745fb84c61dabf48dc7e75cf5d1973f9

commit 3154b813745fb84c61dabf48dc7e75cf5d1973f9
Author: Ryan Sturm <ryansturm@chromium.org>
Date: Wed Jul 11 23:02:45 2018

Moving Offline Previews triggering to be pre-computed

As part of moving previews to an earlier decision point, this CL moves
the triggering of offline previews to be consistent with other preview
types.

Follow-up Cls will move this decision point earlier on the UI thread so
the new offline page implementation will also be able to use it. The
temporary dependency on PreviewsUserData will also not be needed once
the offline tab helper is accessible (the impl is on the UI thread).

Bug:  842233 
Change-Id: If2969a109434270659dcf723b39a7627bb8c8ecd
Reviewed-on: https://chromium-review.googlesource.com/1128332
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Jian Li <jianli@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574393}
[modify] https://crrev.com/3154b813745fb84c61dabf48dc7e75cf5d1973f9/chrome/browser/offline_pages/offline_page_request_handler_unittest.cc
[modify] https://crrev.com/3154b813745fb84c61dabf48dc7e75cf5d1973f9/chrome/browser/offline_pages/offline_page_request_interceptor.cc
[modify] https://crrev.com/3154b813745fb84c61dabf48dc7e75cf5d1973f9/chrome/browser/offline_pages/offline_page_request_interceptor.h
[modify] https://crrev.com/3154b813745fb84c61dabf48dc7e75cf5d1973f9/chrome/browser/offline_pages/offline_page_request_job.cc
[modify] https://crrev.com/3154b813745fb84c61dabf48dc7e75cf5d1973f9/chrome/browser/offline_pages/offline_page_request_job.h
[modify] https://crrev.com/3154b813745fb84c61dabf48dc7e75cf5d1973f9/chrome/browser/previews/previews_infobar_tab_helper.cc
[modify] https://crrev.com/3154b813745fb84c61dabf48dc7e75cf5d1973f9/chrome/browser/previews/previews_infobar_tab_helper_unittest.cc
[modify] https://crrev.com/3154b813745fb84c61dabf48dc7e75cf5d1973f9/chrome/browser/profiles/profile_impl_io_data.cc
[modify] https://crrev.com/3154b813745fb84c61dabf48dc7e75cf5d1973f9/components/previews/content/previews_content_util.cc
[modify] https://crrev.com/3154b813745fb84c61dabf48dc7e75cf5d1973f9/components/previews/content/previews_content_util_unittest.cc
[modify] https://crrev.com/3154b813745fb84c61dabf48dc7e75cf5d1973f9/components/previews/core/previews_user_data.h
[modify] https://crrev.com/3154b813745fb84c61dabf48dc7e75cf5d1973f9/content/public/common/previews_state.h
[modify] https://crrev.com/3154b813745fb84c61dabf48dc7e75cf5d1973f9/third_party/blink/public/platform/web_url_request.h
Project Member

Comment 15 by bugdroid1@chromium.org, Jul 20 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/64315a952b57d687788f7277ff9512a2c0ac508b

commit 64315a952b57d687788f7277ff9512a2c0ac508b
Author: Ryan Sturm <ryansturm@chromium.org>
Date: Fri Jul 20 06:25:28 2018

Removing PreviewsState from network ResourceResponseInfo

PreviewsState is maintained in a content pathway (ResourceRequestInfo ->
common_params) and does not need to be kept in ResourceResponseInfo as
well.

For context, PreviewsState is mostly a Navigation level concept. The
browser allows certain states for certain hosts, and communicates the
state to content to push to blink. There is really no reason for
previews_state to be in the network response, but was there for
historical reasons.

There is still PreviewsState in the Network Request due to ClientLoFi
and ServerLoFi. ClientLoFi uses the state for metrics and there is a
solution for addressing that by using a new data use metrics framework
that goes through the renderer (see page_load_metrics/renderer). Server
LoFi will be deprecated and replaced with Client LoFi, but certain work
is required before that is possible.

In a set of follow-up CLs, PreviewsState will be modified on the UI thread
instead of the IO thread simplifying this even further.

Bug:  842233 
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I949fc71089367afefa8c9e2880b0aa19d8ad99ac
Reviewed-on: https://chromium-review.googlesource.com/1135922
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576798}
[modify] https://crrev.com/64315a952b57d687788f7277ff9512a2c0ac508b/chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc
[modify] https://crrev.com/64315a952b57d687788f7277ff9512a2c0ac508b/content/browser/frame_host/navigation_request.cc
[modify] https://crrev.com/64315a952b57d687788f7277ff9512a2c0ac508b/content/browser/frame_host/navigation_request.h
[modify] https://crrev.com/64315a952b57d687788f7277ff9512a2c0ac508b/content/browser/loader/navigation_url_loader_delegate.h
[modify] https://crrev.com/64315a952b57d687788f7277ff9512a2c0ac508b/content/browser/loader/navigation_url_loader_impl.cc
[modify] https://crrev.com/64315a952b57d687788f7277ff9512a2c0ac508b/content/browser/loader/navigation_url_loader_impl.h
[modify] https://crrev.com/64315a952b57d687788f7277ff9512a2c0ac508b/content/browser/loader/resource_loader.cc
[modify] https://crrev.com/64315a952b57d687788f7277ff9512a2c0ac508b/content/browser/loader/resource_request_info_impl.cc
[modify] https://crrev.com/64315a952b57d687788f7277ff9512a2c0ac508b/content/browser/loader/resource_request_info_impl.h
[modify] https://crrev.com/64315a952b57d687788f7277ff9512a2c0ac508b/content/public/browser/resource_request_info.h
[modify] https://crrev.com/64315a952b57d687788f7277ff9512a2c0ac508b/content/renderer/loader/web_url_loader_impl.cc
[modify] https://crrev.com/64315a952b57d687788f7277ff9512a2c0ac508b/content/renderer/loader/weburlresponse_extradata_impl.h
[modify] https://crrev.com/64315a952b57d687788f7277ff9512a2c0ac508b/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/64315a952b57d687788f7277ff9512a2c0ac508b/content/renderer/render_frame_impl_browsertest.cc
[modify] https://crrev.com/64315a952b57d687788f7277ff9512a2c0ac508b/content/test/test_navigation_url_loader.cc
[modify] https://crrev.com/64315a952b57d687788f7277ff9512a2c0ac508b/content/test/test_navigation_url_loader_delegate.cc
[modify] https://crrev.com/64315a952b57d687788f7277ff9512a2c0ac508b/content/test/test_navigation_url_loader_delegate.h
[modify] https://crrev.com/64315a952b57d687788f7277ff9512a2c0ac508b/services/network/public/cpp/network_ipc_param_traits.h
[modify] https://crrev.com/64315a952b57d687788f7277ff9512a2c0ac508b/services/network/public/cpp/resource_response.cc
[modify] https://crrev.com/64315a952b57d687788f7277ff9512a2c0ac508b/services/network/public/cpp/resource_response_info.cc
[modify] https://crrev.com/64315a952b57d687788f7277ff9512a2c0ac508b/services/network/public/cpp/resource_response_info.h
Project Member

Comment 16 by bugdroid1@chromium.org, Jul 23 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/912ebabb08969cd06b61dbc0db58ebf3c08e1a90

commit 912ebabb08969cd06b61dbc0db58ebf3c08e1a90
Author: Ryan Sturm <ryansturm@chromium.org>
Date: Mon Jul 23 19:13:49 2018

Moving NoScript savings from CDUA to PLM

NoScript savings was previously recorded on the IO thread using
ChromeDataUseAscriber framework. This framework is being deprecated and
this change is blocking parts of previews servification. The results
from looking at this on real no script pages was not far off from the
results using CDUA, and I believe it is accurate enough.

Bug:  842233 
Change-Id: I70057574554fd6717e0837be1a46cb6afa05ce4b
Reviewed-on: https://chromium-review.googlesource.com/1139081
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: rajendrant <rajendrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577216}
[modify] https://crrev.com/912ebabb08969cd06b61dbc0db58ebf3c08e1a90/chrome/browser/page_load_metrics/observers/noscript_preview_page_load_metrics_observer.cc
[modify] https://crrev.com/912ebabb08969cd06b61dbc0db58ebf3c08e1a90/chrome/browser/page_load_metrics/observers/noscript_preview_page_load_metrics_observer.h
[modify] https://crrev.com/912ebabb08969cd06b61dbc0db58ebf3c08e1a90/chrome/browser/page_load_metrics/observers/noscript_preview_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/912ebabb08969cd06b61dbc0db58ebf3c08e1a90/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc
[modify] https://crrev.com/912ebabb08969cd06b61dbc0db58ebf3c08e1a90/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.h
[modify] https://crrev.com/912ebabb08969cd06b61dbc0db58ebf3c08e1a90/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_tester.cc
[modify] https://crrev.com/912ebabb08969cd06b61dbc0db58ebf3c08e1a90/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_tester.h
[modify] https://crrev.com/912ebabb08969cd06b61dbc0db58ebf3c08e1a90/chrome/browser/page_load_metrics/page_load_metrics_update_dispatcher.cc
[modify] https://crrev.com/912ebabb08969cd06b61dbc0db58ebf3c08e1a90/components/data_reduction_proxy/core/browser/BUILD.gn
[modify] https://crrev.com/912ebabb08969cd06b61dbc0db58ebf3c08e1a90/components/data_reduction_proxy/core/browser/data_reduction_proxy_data_use_observer.cc
[delete] https://crrev.com/e30459183c69b37f4857e92a069230ac7a2e1603/components/data_reduction_proxy/core/browser/data_reduction_proxy_data_use_observer_unittest.cc

Comment 17 by ryansturm@chromium.org, Aug 8

Cc: clamy@chromium.org sclit...@chromium.org ryansturm@chromium.org jam@chromium.org
 Issue 820060  has been merged into this issue.

Comment 18 by tbansal@chromium.org, Sep 5

Blocking: 864187
Labels: -Pri-3 M-71 Pri-2
Project Member

Comment 19 by bugdroid1@chromium.org, Sep 6 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5da8d81218a1a4031dda613ca2eac11c16f08c78

commit 5da8d81218a1a4031dda613ca2eac11c16f08c78
Author: Ryan Sturm <ryansturm@chromium.org>
Date: Thu Sep 06 23:23:38 2018

Removing unused previews_decider and associated setter

DataReductionProxyIOData historically added previews_decider_ member to
support AMP redirection, but this is not longer used.

Bug:  842233 
Change-Id: If4b5a9a9a7c259fc0552de20a15e4d723a52e773
Reviewed-on: https://chromium-review.googlesource.com/1211842
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Stefan Kuhne <skuhne@chromium.org>
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589361}
[modify] https://crrev.com/5da8d81218a1a4031dda613ca2eac11c16f08c78/chrome/browser/profiles/profile_impl_io_data.cc
[modify] https://crrev.com/5da8d81218a1a4031dda613ca2eac11c16f08c78/components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data.cc
[modify] https://crrev.com/5da8d81218a1a4031dda613ca2eac11c16f08c78/components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data.h

Comment 20 by jam@chromium.org, Sep 7

Blocking: 827531

Comment 21 by cduvall@chromium.org, Sep 8

Cc: cduvall@chromium.org

Comment 22 by tbansal@chromium.org, Sep 20 

Any updates here?

Comment 23 by tbansal@chromium.org, Sep 21

Blocking: 755626

Comment 24 by dougarnett@chromium.org, Oct 3

Blocking: 891752
Project Member

Comment 25 by bugdroid1@chromium.org, Oct 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3764afed669afcba8bb9f05be1c22510090b4e6a

commit 3764afed669afcba8bb9f05be1c22510090b4e6a
Author: Ryan Sturm <ryansturm@chromium.org>
Date: Wed Oct 03 19:49:03 2018

Moving ownership of DRP blacklist skipping to Previews

This CL moves the state of whether DRP can skip the long term blacklist
checks for Previews from DRPConfig to PreviewsDecider. This happens
through some thread Posts, and will eventually move to one thread
PostTask instead of 2 when Previews is on the UI thread.

Bug:  842233 
Change-Id: Id8129338eeb1b2401f8f70ab2d02aebcbbd5c0e1
Reviewed-on: https://chromium-review.googlesource.com/c/1252783
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596331}
[modify] https://crrev.com/3764afed669afcba8bb9f05be1c22510090b4e6a/chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc
[modify] https://crrev.com/3764afed669afcba8bb9f05be1c22510090b4e6a/chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.cc
[modify] https://crrev.com/3764afed669afcba8bb9f05be1c22510090b4e6a/chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.h
[modify] https://crrev.com/3764afed669afcba8bb9f05be1c22510090b4e6a/chrome/browser/previews/previews_infobar_delegate_unittest.cc
[modify] https://crrev.com/3764afed669afcba8bb9f05be1c22510090b4e6a/chrome/browser/previews/previews_ui_tab_helper_unittest.cc
[modify] https://crrev.com/3764afed669afcba8bb9f05be1c22510090b4e6a/chrome/browser/profiles/profile_impl_io_data.cc
[modify] https://crrev.com/3764afed669afcba8bb9f05be1c22510090b4e6a/chrome/browser/renderer_context_menu/render_view_context_menu_unittest.cc
[modify] https://crrev.com/3764afed669afcba8bb9f05be1c22510090b4e6a/components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc
[modify] https://crrev.com/3764afed669afcba8bb9f05be1c22510090b4e6a/components/data_reduction_proxy/core/browser/data_reduction_proxy_config.h
[modify] https://crrev.com/3764afed669afcba8bb9f05be1c22510090b4e6a/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client.cc
[modify] https://crrev.com/3764afed669afcba8bb9f05be1c22510090b4e6a/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client_unittest.cc
[modify] https://crrev.com/3764afed669afcba8bb9f05be1c22510090b4e6a/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_unittest.cc
[modify] https://crrev.com/3764afed669afcba8bb9f05be1c22510090b4e6a/components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data.cc
[modify] https://crrev.com/3764afed669afcba8bb9f05be1c22510090b4e6a/components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data.h
[modify] https://crrev.com/3764afed669afcba8bb9f05be1c22510090b4e6a/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate_unittest.cc
[modify] https://crrev.com/3764afed669afcba8bb9f05be1c22510090b4e6a/components/data_reduction_proxy/core/browser/data_reduction_proxy_service.cc
[modify] https://crrev.com/3764afed669afcba8bb9f05be1c22510090b4e6a/components/data_reduction_proxy/core/browser/data_reduction_proxy_service.h
[modify] https://crrev.com/3764afed669afcba8bb9f05be1c22510090b4e6a/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.h
[modify] https://crrev.com/3764afed669afcba8bb9f05be1c22510090b4e6a/components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.cc
[modify] https://crrev.com/3764afed669afcba8bb9f05be1c22510090b4e6a/components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.h
[modify] https://crrev.com/3764afed669afcba8bb9f05be1c22510090b4e6a/components/previews/content/previews_decider_impl.cc
[modify] https://crrev.com/3764afed669afcba8bb9f05be1c22510090b4e6a/components/previews/content/previews_decider_impl.h
[modify] https://crrev.com/3764afed669afcba8bb9f05be1c22510090b4e6a/components/previews/content/previews_decider_impl_unittest.cc
[modify] https://crrev.com/3764afed669afcba8bb9f05be1c22510090b4e6a/components/previews/content/previews_ui_service.cc
[modify] https://crrev.com/3764afed669afcba8bb9f05be1c22510090b4e6a/components/previews/content/previews_ui_service.h
[modify] https://crrev.com/3764afed669afcba8bb9f05be1c22510090b4e6a/components/previews/core/previews_decider.h
[modify] https://crrev.com/3764afed669afcba8bb9f05be1c22510090b4e6a/components/previews/core/test_previews_decider.cc
[modify] https://crrev.com/3764afed669afcba8bb9f05be1c22510090b4e6a/components/previews/core/test_previews_decider.h
[modify] https://crrev.com/3764afed669afcba8bb9f05be1c22510090b4e6a/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/3764afed669afcba8bb9f05be1c22510090b4e6a/tools/metrics/histograms/histograms.xml
Project Member

Comment 26 by bugdroid1@chromium.org, Oct 5 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/02001900790138209c4cd6254d76e9808d01cd1b

commit 02001900790138209c4cd6254d76e9808d01cd1b
Author: Ryan Sturm <ryansturm@chromium.org>
Date: Fri Oct 05 20:42:23 2018

Removing URLRequest dependencies from Previews triggering code

This CL aims to move URLRequest dependencies out of Previews triggering
code (and into CRDHD methods) to allow for a much smaller CL when moving
to the UI thread. Ultimately, these methods will be called from the
content/ Navigation stack using delegates there
(ChromeContentBrowserClient). This will allow Previews decisions to
occur slightly earlier in the Navigation pathway, and it will allow
Previews to operate strictly on the UI thread.

However, PreviewsState will still be plumbed to the IO thread until DRP
is moved out of Net Delegate classes.

Instead of passing URLRequest to Previews code, the PreviewsUserData is
passed along with request information (i.e., reload, URL). These will be
available on the UI thread, so the previews methods themselves should be
able to be consumed post thread switch.

Bug:  842233 , 892448 
Change-Id: I0f7ab5d23aeb34e89bad5d027d685c348d94569a
Reviewed-on: https://chromium-review.googlesource.com/c/1259621
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597282}
[modify] https://crrev.com/02001900790138209c4cd6254d76e9808d01cd1b/chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc
[modify] https://crrev.com/02001900790138209c4cd6254d76e9808d01cd1b/chrome/browser/previews/previews_infobar_delegate_unittest.cc
[modify] https://crrev.com/02001900790138209c4cd6254d76e9808d01cd1b/chrome/browser/previews/previews_service.cc
[modify] https://crrev.com/02001900790138209c4cd6254d76e9808d01cd1b/chrome/browser/previews/previews_service_unittest.cc
[modify] https://crrev.com/02001900790138209c4cd6254d76e9808d01cd1b/chrome/browser/ui/webui/interventions_internals/interventions_internals_page_handler_unittest.cc
[modify] https://crrev.com/02001900790138209c4cd6254d76e9808d01cd1b/components/data_reduction_proxy/content/browser/content_lofi_decider.cc
[modify] https://crrev.com/02001900790138209c4cd6254d76e9808d01cd1b/components/data_reduction_proxy/content/browser/content_lofi_decider.h
[modify] https://crrev.com/02001900790138209c4cd6254d76e9808d01cd1b/components/data_reduction_proxy/content/browser/content_lofi_decider_unittest.cc
[modify] https://crrev.com/02001900790138209c4cd6254d76e9808d01cd1b/components/previews/content/BUILD.gn
[modify] https://crrev.com/02001900790138209c4cd6254d76e9808d01cd1b/components/previews/content/DEPS
[modify] https://crrev.com/02001900790138209c4cd6254d76e9808d01cd1b/components/previews/content/previews_content_util.cc
[modify] https://crrev.com/02001900790138209c4cd6254d76e9808d01cd1b/components/previews/content/previews_content_util.h
[modify] https://crrev.com/02001900790138209c4cd6254d76e9808d01cd1b/components/previews/content/previews_content_util_unittest.cc
[modify] https://crrev.com/02001900790138209c4cd6254d76e9808d01cd1b/components/previews/content/previews_decider_impl.cc
[modify] https://crrev.com/02001900790138209c4cd6254d76e9808d01cd1b/components/previews/content/previews_decider_impl.h
[modify] https://crrev.com/02001900790138209c4cd6254d76e9808d01cd1b/components/previews/content/previews_decider_impl_unittest.cc
[modify] https://crrev.com/02001900790138209c4cd6254d76e9808d01cd1b/components/previews/content/previews_optimization_guide.cc
[modify] https://crrev.com/02001900790138209c4cd6254d76e9808d01cd1b/components/previews/content/previews_optimization_guide.h
[modify] https://crrev.com/02001900790138209c4cd6254d76e9808d01cd1b/components/previews/content/previews_optimization_guide_unittest.cc
[modify] https://crrev.com/02001900790138209c4cd6254d76e9808d01cd1b/components/previews/content/previews_ui_service.cc
[modify] https://crrev.com/02001900790138209c4cd6254d76e9808d01cd1b/components/previews/content/previews_ui_service.h
[modify] https://crrev.com/02001900790138209c4cd6254d76e9808d01cd1b/components/previews/content/previews_ui_service_unittest.cc
[modify] https://crrev.com/02001900790138209c4cd6254d76e9808d01cd1b/components/previews/content/previews_user_data.cc
[modify] https://crrev.com/02001900790138209c4cd6254d76e9808d01cd1b/components/previews/content/previews_user_data.h
[modify] https://crrev.com/02001900790138209c4cd6254d76e9808d01cd1b/components/previews/content/previews_user_data_unittest.cc
[modify] https://crrev.com/02001900790138209c4cd6254d76e9808d01cd1b/components/previews/core/previews_decider.h
[modify] https://crrev.com/02001900790138209c4cd6254d76e9808d01cd1b/components/previews/core/test_previews_decider.cc
[modify] https://crrev.com/02001900790138209c4cd6254d76e9808d01cd1b/components/previews/core/test_previews_decider.h
Project Member

Comment 27 by bugdroid1@chromium.org, Oct 19 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/310c6fa1909da00f001303a6498878e987487b8a

commit 310c6fa1909da00f001303a6498878e987487b8a
Author: Ryan Sturm <ryansturm@chromium.org>
Date: Fri Oct 19 21:16:38 2018

Switching Previews triggering from the IO thread to the UI thread

This CL moves previews triggering from the IO thread
(ChromeResourceDispatcherHostDelegate) to the UI thread
(ChromeContentBrowserClient). The new call sites occur in
NavigationRequest and update the previews_state in
CommonNavigationParams held by the NavigationRequest directly. This
means PreviewsDeciderImpl is being moved to the UI thread.

Significant changes:
- PreviewsDeciderImpl is now owned by the PreviewsUIService instead of
profile IO data.
- PreviewsUserData is now entirely a UI thread notion. For now, we use
PreviewsUITabHelper to manage its lifetime, but it could move to
NavigationHandle (if NavigationHandle already supported UserData,
that solution would be ideal).
- ChromeNavigationData is update to remove PreviewsUserData and
PreviewsState (the latter has moved into PreviewsUserData and there is a
notion of Allowed PreviewsState and committed PreviewsState)
- Offline Previews committed checks use the OfflinePreviewsTabHelper
instead of PreviewsUserData now that we are on the same thread.
- Cleanup on ResourceRequestInfo to remove PreviewsState setter as well
as cleanup to remove PreviewsState from being passed back out of the
loader code into NavigationRequest.
- There is a TODO to re-evaluate PreviewsState during redirects, which
will *not* be plumbed into the network service, so DataReductionProxy
Previews will not be updated.

Bug:  842233 
Change-Id: I80a3044a4c84734b877f8ebcbe5a4bb2c2900dbb
Reviewed-on: https://chromium-review.googlesource.com/c/1266196
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Jian Li <jianli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601298}
[modify] https://crrev.com/310c6fa1909da00f001303a6498878e987487b8a/chrome/browser/browser_process_impl.cc
[modify] https://crrev.com/310c6fa1909da00f001303a6498878e987487b8a/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/310c6fa1909da00f001303a6498878e987487b8a/chrome/browser/chrome_content_browser_client.h
[modify] https://crrev.com/310c6fa1909da00f001303a6498878e987487b8a/chrome/browser/loader/chrome_navigation_data.cc
[modify] https://crrev.com/310c6fa1909da00f001303a6498878e987487b8a/chrome/browser/loader/chrome_navigation_data.h
[modify] https://crrev.com/310c6fa1909da00f001303a6498878e987487b8a/chrome/browser/loader/chrome_navigation_data_unittest.cc
[modify] https://crrev.com/310c6fa1909da00f001303a6498878e987487b8a/chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc
[modify] https://crrev.com/310c6fa1909da00f001303a6498878e987487b8a/chrome/browser/loader/chrome_resource_dispatcher_host_delegate.h
[modify] https://crrev.com/310c6fa1909da00f001303a6498878e987487b8a/chrome/browser/loader/chrome_resource_dispatcher_host_delegate_unittest.cc
[modify] https://crrev.com/310c6fa1909da00f001303a6498878e987487b8a/chrome/browser/offline_pages/background_loader_offliner.cc
[modify] https://crrev.com/310c6fa1909da00f001303a6498878e987487b8a/chrome/browser/offline_pages/background_loader_offliner_unittest.cc
[modify] https://crrev.com/310c6fa1909da00f001303a6498878e987487b8a/chrome/browser/offline_pages/offline_page_request_handler_unittest.cc
[modify] https://crrev.com/310c6fa1909da00f001303a6498878e987487b8a/chrome/browser/offline_pages/offline_page_request_job.cc
[modify] https://crrev.com/310c6fa1909da00f001303a6498878e987487b8a/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer.cc
[modify] https://crrev.com/310c6fa1909da00f001303a6498878e987487b8a/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer_unittest.cc
[modify] https://crrev.com/310c6fa1909da00f001303a6498878e987487b8a/chrome/browser/page_load_metrics/observers/previews_page_load_metrics_observer.cc
[modify] https://crrev.com/310c6fa1909da00f001303a6498878e987487b8a/chrome/browser/page_load_metrics/observers/previews_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/310c6fa1909da00f001303a6498878e987487b8a/chrome/browser/page_load_metrics/observers/previews_ukm_observer.cc
[modify] https://crrev.com/310c6fa1909da00f001303a6498878e987487b8a/chrome/browser/page_load_metrics/observers/previews_ukm_observer_unittest.cc
[modify] https://crrev.com/310c6fa1909da00f001303a6498878e987487b8a/chrome/browser/previews/previews_infobar_delegate_unittest.cc
[modify] https://crrev.com/310c6fa1909da00f001303a6498878e987487b8a/chrome/browser/previews/previews_service.cc
[modify] https://crrev.com/310c6fa1909da00f001303a6498878e987487b8a/chrome/browser/previews/previews_service.h
[modify] https://crrev.com/310c6fa1909da00f001303a6498878e987487b8a/chrome/browser/previews/previews_service_unittest.cc
[modify] https://crrev.com/310c6fa1909da00f001303a6498878e987487b8a/chrome/browser/previews/previews_ui_tab_helper.cc
[modify] https://crrev.com/310c6fa1909da00f001303a6498878e987487b8a/chrome/browser/previews/previews_ui_tab_helper.h
[modify] https://crrev.com/310c6fa1909da00f001303a6498878e987487b8a/chrome/browser/previews/previews_ui_tab_helper_unittest.cc
[modify] https://crrev.com/310c6fa1909da00f001303a6498878e987487b8a/chrome/browser/previews/resource_loading_hints/resource_loading_hints_web_contents_observer.cc
[modify] https://crrev.com/310c6fa1909da00f001303a6498878e987487b8a/chrome/browser/profiles/profile_impl_io_data.cc
[modify] https://crrev.com/310c6fa1909da00f001303a6498878e987487b8a/chrome/browser/profiles/profile_io_data.cc
[modify] https://crrev.com/310c6fa1909da00f001303a6498878e987487b8a/chrome/browser/profiles/profile_io_data.h
[modify] https://crrev.com/310c6fa1909da00f001303a6498878e987487b8a/chrome/browser/ui/webui/interventions_internals/interventions_internals_page_handler_unittest.cc
[modify] https://crrev.com/310c6fa1909da00f001303a6498878e987487b8a/components/optimization_guide/optimization_guide_service.cc
[modify] https://crrev.com/310c6fa1909da00f001303a6498878e987487b8a/components/optimization_guide/optimization_guide_service.h
[modify] https://crrev.com/310c6fa1909da00f001303a6498878e987487b8a/components/previews/content/previews_content_util.cc
[modify] https://crrev.com/310c6fa1909da00f001303a6498878e987487b8a/components/previews/content/previews_content_util.h
[modify] https://crrev.com/310c6fa1909da00f001303a6498878e987487b8a/components/previews/content/previews_content_util_unittest.cc
[modify] https://crrev.com/310c6fa1909da00f001303a6498878e987487b8a/components/previews/content/previews_decider_impl.cc
[modify] https://crrev.com/310c6fa1909da00f001303a6498878e987487b8a/components/previews/content/previews_decider_impl.h
[modify] https://crrev.com/310c6fa1909da00f001303a6498878e987487b8a/components/previews/content/previews_decider_impl_unittest.cc
[modify] https://crrev.com/310c6fa1909da00f001303a6498878e987487b8a/components/previews/content/previews_ui_service.cc
[modify] https://crrev.com/310c6fa1909da00f001303a6498878e987487b8a/components/previews/content/previews_ui_service.h
[modify] https://crrev.com/310c6fa1909da00f001303a6498878e987487b8a/components/previews/content/previews_ui_service_unittest.cc
[modify] https://crrev.com/310c6fa1909da00f001303a6498878e987487b8a/components/previews/content/previews_user_data.cc
[modify] https://crrev.com/310c6fa1909da00f001303a6498878e987487b8a/components/previews/content/previews_user_data.h
[modify] https://crrev.com/310c6fa1909da00f001303a6498878e987487b8a/components/previews/content/previews_user_data_unittest.cc
[modify] https://crrev.com/310c6fa1909da00f001303a6498878e987487b8a/content/browser/frame_host/navigation_controller_impl.cc
[modify] https://crrev.com/310c6fa1909da00f001303a6498878e987487b8a/content/browser/frame_host/navigation_request.cc
[modify] https://crrev.com/310c6fa1909da00f001303a6498878e987487b8a/content/browser/frame_host/navigation_request.h
[modify] https://crrev.com/310c6fa1909da00f001303a6498878e987487b8a/content/browser/loader/loader_browsertest.cc
[modify] https://crrev.com/310c6fa1909da00f001303a6498878e987487b8a/content/browser/loader/mojo_async_resource_handler_unittest.cc
[modify] https://crrev.com/310c6fa1909da00f001303a6498878e987487b8a/content/browser/loader/navigation_url_loader_delegate.h
[modify] https://crrev.com/310c6fa1909da00f001303a6498878e987487b8a/content/browser/loader/navigation_url_loader_impl.cc
[modify] https://crrev.com/310c6fa1909da00f001303a6498878e987487b8a/content/browser/loader/navigation_url_loader_impl.h
[modify] https://crrev.com/310c6fa1909da00f001303a6498878e987487b8a/content/browser/loader/resource_dispatcher_host_impl.cc
[modify] https://crrev.com/310c6fa1909da00f001303a6498878e987487b8a/content/browser/loader/resource_request_info_impl.cc
[modify] https://crrev.com/310c6fa1909da00f001303a6498878e987487b8a/content/browser/loader/resource_request_info_impl.h
[modify] https://crrev.com/310c6fa1909da00f001303a6498878e987487b8a/content/browser/navigation_browsertest.cc
[modify] https://crrev.com/310c6fa1909da00f001303a6498878e987487b8a/content/public/browser/content_browser_client.cc
[modify] https://crrev.com/310c6fa1909da00f001303a6498878e987487b8a/content/public/browser/content_browser_client.h
[modify] https://crrev.com/310c6fa1909da00f001303a6498878e987487b8a/content/public/browser/resource_dispatcher_host_delegate.cc
[modify] https://crrev.com/310c6fa1909da00f001303a6498878e987487b8a/content/public/browser/resource_dispatcher_host_delegate.h
[modify] https://crrev.com/310c6fa1909da00f001303a6498878e987487b8a/content/public/browser/resource_request_info.h
[modify] https://crrev.com/310c6fa1909da00f001303a6498878e987487b8a/content/test/test_navigation_url_loader.cc
[modify] https://crrev.com/310c6fa1909da00f001303a6498878e987487b8a/content/test/test_navigation_url_loader_delegate.cc
[modify] https://crrev.com/310c6fa1909da00f001303a6498878e987487b8a/content/test/test_navigation_url_loader_delegate.h

Comment 28 by ryansturm@chromium.org, Oct 19 

The previously landed CL has functionally completed moving Previews Triggering to work with Network Servicification, but there are some follow up CLs to change HTTPS server previews to use PreviewsState, and coordination with DRP servicification.

Comment 29 by ryansturm@chromium.org, Oct 19

Labels: -M-71 M-72
Project Member

Comment 30 by bugdroid1@chromium.org, Oct 20 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7c671009807b7565c5d0c8eef6fa46f8236f9d55

commit 7c671009807b7565c5d0c8eef6fa46f8236f9d55
Author: Ryan Sturm <ryansturm@chromium.org>
Date: Sat Oct 20 00:52:02 2018

Revert "Switching Previews triggering from the IO thread to the UI thread"

This reverts commit 310c6fa1909da00f001303a6498878e987487b8a.

Reason for revert: flaky previews test

Original change's description:
> Switching Previews triggering from the IO thread to the UI thread
> 
> This CL moves previews triggering from the IO thread
> (ChromeResourceDispatcherHostDelegate) to the UI thread
> (ChromeContentBrowserClient). The new call sites occur in
> NavigationRequest and update the previews_state in
> CommonNavigationParams held by the NavigationRequest directly. This
> means PreviewsDeciderImpl is being moved to the UI thread.
> 
> Significant changes:
> - PreviewsDeciderImpl is now owned by the PreviewsUIService instead of
> profile IO data.
> - PreviewsUserData is now entirely a UI thread notion. For now, we use
> PreviewsUITabHelper to manage its lifetime, but it could move to
> NavigationHandle (if NavigationHandle already supported UserData,
> that solution would be ideal).
> - ChromeNavigationData is update to remove PreviewsUserData and
> PreviewsState (the latter has moved into PreviewsUserData and there is a
> notion of Allowed PreviewsState and committed PreviewsState)
> - Offline Previews committed checks use the OfflinePreviewsTabHelper
> instead of PreviewsUserData now that we are on the same thread.
> - Cleanup on ResourceRequestInfo to remove PreviewsState setter as well
> as cleanup to remove PreviewsState from being passed back out of the
> loader code into NavigationRequest.
> - There is a TODO to re-evaluate PreviewsState during redirects, which
> will *not* be plumbed into the network service, so DataReductionProxy
> Previews will not be updated.
> 
> Bug:  842233 
> Change-Id: I80a3044a4c84734b877f8ebcbe5a4bb2c2900dbb
> Reviewed-on: https://chromium-review.googlesource.com/c/1266196
> Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
> Reviewed-by: Jochen Eisinger <jochen@chromium.org>
> Reviewed-by: Camille Lamy <clamy@chromium.org>
> Reviewed-by: Tarun Bansal <tbansal@chromium.org>
> Reviewed-by: Matt Menke <mmenke@chromium.org>
> Reviewed-by: Jian Li <jianli@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#601298}

TBR=clamy@chromium.org,jianli@chromium.org,mmenke@chromium.org,tbansal@chromium.org,robertogden@chromium.org,ryansturm@chromium.org,jochen@chromium.org

Change-Id: I176df103620910300297ce0fb9bc6d233b4ebb2f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  842233 
Reviewed-on: https://chromium-review.googlesource.com/c/1292836
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601380}
[modify] https://crrev.com/7c671009807b7565c5d0c8eef6fa46f8236f9d55/chrome/browser/browser_process_impl.cc
[modify] https://crrev.com/7c671009807b7565c5d0c8eef6fa46f8236f9d55/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/7c671009807b7565c5d0c8eef6fa46f8236f9d55/chrome/browser/chrome_content_browser_client.h
[modify] https://crrev.com/7c671009807b7565c5d0c8eef6fa46f8236f9d55/chrome/browser/loader/chrome_navigation_data.cc
[modify] https://crrev.com/7c671009807b7565c5d0c8eef6fa46f8236f9d55/chrome/browser/loader/chrome_navigation_data.h
[modify] https://crrev.com/7c671009807b7565c5d0c8eef6fa46f8236f9d55/chrome/browser/loader/chrome_navigation_data_unittest.cc
[modify] https://crrev.com/7c671009807b7565c5d0c8eef6fa46f8236f9d55/chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc
[modify] https://crrev.com/7c671009807b7565c5d0c8eef6fa46f8236f9d55/chrome/browser/loader/chrome_resource_dispatcher_host_delegate.h
[modify] https://crrev.com/7c671009807b7565c5d0c8eef6fa46f8236f9d55/chrome/browser/loader/chrome_resource_dispatcher_host_delegate_unittest.cc
[modify] https://crrev.com/7c671009807b7565c5d0c8eef6fa46f8236f9d55/chrome/browser/offline_pages/background_loader_offliner.cc
[modify] https://crrev.com/7c671009807b7565c5d0c8eef6fa46f8236f9d55/chrome/browser/offline_pages/background_loader_offliner_unittest.cc
[modify] https://crrev.com/7c671009807b7565c5d0c8eef6fa46f8236f9d55/chrome/browser/offline_pages/offline_page_request_handler_unittest.cc
[modify] https://crrev.com/7c671009807b7565c5d0c8eef6fa46f8236f9d55/chrome/browser/offline_pages/offline_page_request_job.cc
[modify] https://crrev.com/7c671009807b7565c5d0c8eef6fa46f8236f9d55/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer.cc
[modify] https://crrev.com/7c671009807b7565c5d0c8eef6fa46f8236f9d55/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer_unittest.cc
[modify] https://crrev.com/7c671009807b7565c5d0c8eef6fa46f8236f9d55/chrome/browser/page_load_metrics/observers/previews_page_load_metrics_observer.cc
[modify] https://crrev.com/7c671009807b7565c5d0c8eef6fa46f8236f9d55/chrome/browser/page_load_metrics/observers/previews_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/7c671009807b7565c5d0c8eef6fa46f8236f9d55/chrome/browser/page_load_metrics/observers/previews_ukm_observer.cc
[modify] https://crrev.com/7c671009807b7565c5d0c8eef6fa46f8236f9d55/chrome/browser/page_load_metrics/observers/previews_ukm_observer_unittest.cc
[modify] https://crrev.com/7c671009807b7565c5d0c8eef6fa46f8236f9d55/chrome/browser/previews/previews_infobar_delegate_unittest.cc
[modify] https://crrev.com/7c671009807b7565c5d0c8eef6fa46f8236f9d55/chrome/browser/previews/previews_service.cc
[modify] https://crrev.com/7c671009807b7565c5d0c8eef6fa46f8236f9d55/chrome/browser/previews/previews_service.h
[modify] https://crrev.com/7c671009807b7565c5d0c8eef6fa46f8236f9d55/chrome/browser/previews/previews_service_unittest.cc
[modify] https://crrev.com/7c671009807b7565c5d0c8eef6fa46f8236f9d55/chrome/browser/previews/previews_ui_tab_helper.cc
[modify] https://crrev.com/7c671009807b7565c5d0c8eef6fa46f8236f9d55/chrome/browser/previews/previews_ui_tab_helper.h
[modify] https://crrev.com/7c671009807b7565c5d0c8eef6fa46f8236f9d55/chrome/browser/previews/previews_ui_tab_helper_unittest.cc
[modify] https://crrev.com/7c671009807b7565c5d0c8eef6fa46f8236f9d55/chrome/browser/previews/resource_loading_hints/resource_loading_hints_web_contents_observer.cc
[modify] https://crrev.com/7c671009807b7565c5d0c8eef6fa46f8236f9d55/chrome/browser/profiles/profile_impl_io_data.cc
[modify] https://crrev.com/7c671009807b7565c5d0c8eef6fa46f8236f9d55/chrome/browser/profiles/profile_io_data.cc
[modify] https://crrev.com/7c671009807b7565c5d0c8eef6fa46f8236f9d55/chrome/browser/profiles/profile_io_data.h
[modify] https://crrev.com/7c671009807b7565c5d0c8eef6fa46f8236f9d55/chrome/browser/ui/webui/interventions_internals/interventions_internals_page_handler_unittest.cc
[modify] https://crrev.com/7c671009807b7565c5d0c8eef6fa46f8236f9d55/components/optimization_guide/optimization_guide_service.cc
[modify] https://crrev.com/7c671009807b7565c5d0c8eef6fa46f8236f9d55/components/optimization_guide/optimization_guide_service.h
[modify] https://crrev.com/7c671009807b7565c5d0c8eef6fa46f8236f9d55/components/previews/content/previews_content_util.cc
[modify] https://crrev.com/7c671009807b7565c5d0c8eef6fa46f8236f9d55/components/previews/content/previews_content_util.h
[modify] https://crrev.com/7c671009807b7565c5d0c8eef6fa46f8236f9d55/components/previews/content/previews_content_util_unittest.cc
[modify] https://crrev.com/7c671009807b7565c5d0c8eef6fa46f8236f9d55/components/previews/content/previews_decider_impl.cc
[modify] https://crrev.com/7c671009807b7565c5d0c8eef6fa46f8236f9d55/components/previews/content/previews_decider_impl.h
[modify] https://crrev.com/7c671009807b7565c5d0c8eef6fa46f8236f9d55/components/previews/content/previews_decider_impl_unittest.cc
[modify] https://crrev.com/7c671009807b7565c5d0c8eef6fa46f8236f9d55/components/previews/content/previews_ui_service.cc
[modify] https://crrev.com/7c671009807b7565c5d0c8eef6fa46f8236f9d55/components/previews/content/previews_ui_service.h
[modify] https://crrev.com/7c671009807b7565c5d0c8eef6fa46f8236f9d55/components/previews/content/previews_ui_service_unittest.cc
[modify] https://crrev.com/7c671009807b7565c5d0c8eef6fa46f8236f9d55/components/previews/content/previews_user_data.cc
[modify] https://crrev.com/7c671009807b7565c5d0c8eef6fa46f8236f9d55/components/previews/content/previews_user_data.h
[modify] https://crrev.com/7c671009807b7565c5d0c8eef6fa46f8236f9d55/components/previews/content/previews_user_data_unittest.cc
[modify] https://crrev.com/7c671009807b7565c5d0c8eef6fa46f8236f9d55/content/browser/frame_host/navigation_controller_impl.cc
[modify] https://crrev.com/7c671009807b7565c5d0c8eef6fa46f8236f9d55/content/browser/frame_host/navigation_request.cc
[modify] https://crrev.com/7c671009807b7565c5d0c8eef6fa46f8236f9d55/content/browser/frame_host/navigation_request.h
[modify] https://crrev.com/7c671009807b7565c5d0c8eef6fa46f8236f9d55/content/browser/loader/loader_browsertest.cc
[modify] https://crrev.com/7c671009807b7565c5d0c8eef6fa46f8236f9d55/content/browser/loader/mojo_async_resource_handler_unittest.cc
[modify] https://crrev.com/7c671009807b7565c5d0c8eef6fa46f8236f9d55/content/browser/loader/navigation_url_loader_delegate.h
[modify] https://crrev.com/7c671009807b7565c5d0c8eef6fa46f8236f9d55/content/browser/loader/navigation_url_loader_impl.cc
[modify] https://crrev.com/7c671009807b7565c5d0c8eef6fa46f8236f9d55/content/browser/loader/navigation_url_loader_impl.h
[modify] https://crrev.com/7c671009807b7565c5d0c8eef6fa46f8236f9d55/content/browser/loader/resource_dispatcher_host_impl.cc
[modify] https://crrev.com/7c671009807b7565c5d0c8eef6fa46f8236f9d55/content/browser/loader/resource_request_info_impl.cc
[modify] https://crrev.com/7c671009807b7565c5d0c8eef6fa46f8236f9d55/content/browser/loader/resource_request_info_impl.h
[modify] https://crrev.com/7c671009807b7565c5d0c8eef6fa46f8236f9d55/content/browser/navigation_browsertest.cc
[modify] https://crrev.com/7c671009807b7565c5d0c8eef6fa46f8236f9d55/content/public/browser/content_browser_client.cc
[modify] https://crrev.com/7c671009807b7565c5d0c8eef6fa46f8236f9d55/content/public/browser/content_browser_client.h
[modify] https://crrev.com/7c671009807b7565c5d0c8eef6fa46f8236f9d55/content/public/browser/resource_dispatcher_host_delegate.cc
[modify] https://crrev.com/7c671009807b7565c5d0c8eef6fa46f8236f9d55/content/public/browser/resource_dispatcher_host_delegate.h
[modify] https://crrev.com/7c671009807b7565c5d0c8eef6fa46f8236f9d55/content/public/browser/resource_request_info.h
[modify] https://crrev.com/7c671009807b7565c5d0c8eef6fa46f8236f9d55/content/test/test_navigation_url_loader.cc
[modify] https://crrev.com/7c671009807b7565c5d0c8eef6fa46f8236f9d55/content/test/test_navigation_url_loader_delegate.cc
[modify] https://crrev.com/7c671009807b7565c5d0c8eef6fa46f8236f9d55/content/test/test_navigation_url_loader_delegate.h
Project Member

Comment 31 by bugdroid1@chromium.org, Oct 21 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aa05092ff325c9ff71f215499c28f6f26a06707c

commit aa05092ff325c9ff71f215499c28f6f26a06707c
Author: Ryan Sturm <ryansturm@chromium.org>
Date: Sun Oct 21 03:56:54 2018

Reland "Switching Previews triggering from the IO thread to the UI thread"

This is a reland of 310c6fa1909da00f001303a6498878e987487b8a

This was caused by a CL that landed on Friday morning that was missing a
RunUntilIdle (that was added for the rest of the tests in the file).

https://chromium-review.googlesource.com/c/chromium/src/+/1289086 added
the failing test. The delta for the reland is adding a RunUntilIdle.

Original change's description:
> Switching Previews triggering from the IO thread to the UI thread
>
> This CL moves previews triggering from the IO thread
> (ChromeResourceDispatcherHostDelegate) to the UI thread
> (ChromeContentBrowserClient). The new call sites occur in
> NavigationRequest and update the previews_state in
> CommonNavigationParams held by the NavigationRequest directly. This
> means PreviewsDeciderImpl is being moved to the UI thread.
>
> Significant changes:
> - PreviewsDeciderImpl is now owned by the PreviewsUIService instead of
> profile IO data.
> - PreviewsUserData is now entirely a UI thread notion. For now, we use
> PreviewsUITabHelper to manage its lifetime, but it could move to
> NavigationHandle (if NavigationHandle already supported UserData,
> that solution would be ideal).
> - ChromeNavigationData is update to remove PreviewsUserData and
> PreviewsState (the latter has moved into PreviewsUserData and there is a
> notion of Allowed PreviewsState and committed PreviewsState)
> - Offline Previews committed checks use the OfflinePreviewsTabHelper
> instead of PreviewsUserData now that we are on the same thread.
> - Cleanup on ResourceRequestInfo to remove PreviewsState setter as well
> as cleanup to remove PreviewsState from being passed back out of the
> loader code into NavigationRequest.
> - There is a TODO to re-evaluate PreviewsState during redirects, which
> will *not* be plumbed into the network service, so DataReductionProxy
> Previews will not be updated.
>
> Bug:  842233 
> Change-Id: I80a3044a4c84734b877f8ebcbe5a4bb2c2900dbb
> Reviewed-on: https://chromium-review.googlesource.com/c/1266196
> Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
> Reviewed-by: Jochen Eisinger <jochen@chromium.org>
> Reviewed-by: Camille Lamy <clamy@chromium.org>
> Reviewed-by: Tarun Bansal <tbansal@chromium.org>
> Reviewed-by: Matt Menke <mmenke@chromium.org>
> Reviewed-by: Jian Li <jianli@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#601298}

Bug:  842233 , 897385 
Change-Id: I4ff029a45edf3a1ac84f409fb3326d6767f03fd8

TBR=jochen@chromium.org,clamy@chromium.org,tbansal@chromium.org,mmenke@chromium.org,jianli@chromium.org

Change-Id: I4ff029a45edf3a1ac84f409fb3326d6767f03fd8
Reviewed-on: https://chromium-review.googlesource.com/c/1292955
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601426}
[modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/chrome/browser/browser_process_impl.cc
[modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/chrome/browser/chrome_content_browser_client.h
[modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/chrome/browser/loader/chrome_navigation_data.cc
[modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/chrome/browser/loader/chrome_navigation_data.h
[modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/chrome/browser/loader/chrome_navigation_data_unittest.cc
[modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc
[modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/chrome/browser/loader/chrome_resource_dispatcher_host_delegate.h
[modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/chrome/browser/loader/chrome_resource_dispatcher_host_delegate_unittest.cc
[modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/chrome/browser/offline_pages/background_loader_offliner.cc
[modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/chrome/browser/offline_pages/background_loader_offliner_unittest.cc
[modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/chrome/browser/offline_pages/offline_page_request_handler_unittest.cc
[modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/chrome/browser/offline_pages/offline_page_request_job.cc
[modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer.cc
[modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer_unittest.cc
[modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/chrome/browser/page_load_metrics/observers/previews_page_load_metrics_observer.cc
[modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/chrome/browser/page_load_metrics/observers/previews_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/chrome/browser/page_load_metrics/observers/previews_ukm_observer.cc
[modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/chrome/browser/page_load_metrics/observers/previews_ukm_observer_unittest.cc
[modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/chrome/browser/previews/previews_infobar_delegate_unittest.cc
[modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/chrome/browser/previews/previews_service.cc
[modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/chrome/browser/previews/previews_service.h
[modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/chrome/browser/previews/previews_service_unittest.cc
[modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/chrome/browser/previews/previews_ui_tab_helper.cc
[modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/chrome/browser/previews/previews_ui_tab_helper.h
[modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/chrome/browser/previews/previews_ui_tab_helper_unittest.cc
[modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/chrome/browser/previews/resource_loading_hints/resource_loading_hints_web_contents_observer.cc
[modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/chrome/browser/profiles/profile_impl_io_data.cc
[modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/chrome/browser/profiles/profile_io_data.cc
[modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/chrome/browser/profiles/profile_io_data.h
[modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/chrome/browser/ui/webui/interventions_internals/interventions_internals_page_handler_unittest.cc
[modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/components/optimization_guide/optimization_guide_service.cc
[modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/components/optimization_guide/optimization_guide_service.h
[modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/components/previews/content/previews_content_util.cc
[modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/components/previews/content/previews_content_util.h
[modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/components/previews/content/previews_content_util_unittest.cc
[modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/components/previews/content/previews_decider_impl.cc
[modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/components/previews/content/previews_decider_impl.h
[modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/components/previews/content/previews_decider_impl_unittest.cc
[modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/components/previews/content/previews_ui_service.cc
[modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/components/previews/content/previews_ui_service.h
[modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/components/previews/content/previews_ui_service_unittest.cc
[modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/components/previews/content/previews_user_data.cc
[modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/components/previews/content/previews_user_data.h
[modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/components/previews/content/previews_user_data_unittest.cc
[modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/content/browser/frame_host/navigation_controller_impl.cc
[modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/content/browser/frame_host/navigation_request.cc
[modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/content/browser/frame_host/navigation_request.h
[modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/content/browser/loader/loader_browsertest.cc
[modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/content/browser/loader/mojo_async_resource_handler_unittest.cc
[modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/content/browser/loader/navigation_url_loader_delegate.h
[modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/content/browser/loader/navigation_url_loader_impl.cc
[modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/content/browser/loader/navigation_url_loader_impl.h
[modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/content/browser/loader/resource_dispatcher_host_impl.cc
[modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/content/browser/loader/resource_request_info_impl.cc
[modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/content/browser/loader/resource_request_info_impl.h
[modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/content/browser/navigation_browsertest.cc
[modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/content/public/browser/content_browser_client.cc
[modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/content/public/browser/content_browser_client.h
[modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/content/public/browser/resource_dispatcher_host_delegate.cc
[modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/content/public/browser/resource_dispatcher_host_delegate.h
[modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/content/public/browser/resource_request_info.h
[modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/content/test/test_navigation_url_loader.cc
[modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/content/test/test_navigation_url_loader_delegate.cc
[modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/content/test/test_navigation_url_loader_delegate.h
Project Member

Comment 32 by bugdroid1@chromium.org, Oct 24 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/598b6bee70958df45ba9862a7add2ea2ad820c35

commit 598b6bee70958df45ba9862a7add2ea2ad820c35
Author: Ryan Sturm <ryansturm@chromium.org>
Date: Wed Oct 24 23:17:47 2018

Adding a previews state check to offline s13n

This allows Offline previews to work after network s13n is turned on.

Bug:  842233 
Change-Id: I9cc97a29308b25490a5ea1b97b353aada82cccf0
Reviewed-on: https://chromium-review.googlesource.com/c/1297472
Reviewed-by: Jian Li <jianli@chromium.org>
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602515}
[modify] https://crrev.com/598b6bee70958df45ba9862a7add2ea2ad820c35/chrome/browser/offline_pages/offline_page_request_handler_unittest.cc
[modify] https://crrev.com/598b6bee70958df45ba9862a7add2ea2ad820c35/chrome/browser/offline_pages/offline_page_url_loader.cc
[modify] https://crrev.com/598b6bee70958df45ba9862a7add2ea2ad820c35/chrome/browser/offline_pages/offline_page_url_loader.h

Comment 33 by tbansal@chromium.org, Nov 29 

Ryan, is this fixed?

Comment 34 by ryansturm@google.com, Nov 29

Status: Fixed (was: Started)
Project Member

Comment 35 by bugdroid1@chromium.org, Dec 13 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dc0b1bae56b5b5ba73cb94830172d03f795e3893

commit dc0b1bae56b5b5ba73cb94830172d03f795e3893
Author: John Abd-El-Malek <jam@chromium.org>
Date: Thu Dec 13 01:18:18 2018

Update network service content_browsertests filter with now-passing previews tests

Bug:  842233 
Change-Id: I7844cb7c709b2121ada3803cc3a46c50094fe33f
Reviewed-on: https://chromium-review.googlesource.com/c/1374440
Reviewed-by: Clark DuVall <cduvall@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616143}
[modify] https://crrev.com/dc0b1bae56b5b5ba73cb94830172d03f795e3893/testing/buildbot/filters/mojo.fyi.network_content_browsertests.filter

Comment 36 by ryansturm@chromium.org, Dec 18 

Issue 755626 has been merged into this issue.
►

Sign in to add a comment