New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 842232 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature



Sign in to add a comment

Revise the bot health sheriff docs to better reflect reality

Project Member Reported by charliea@chromium.org, May 11 2018

Issue description

This is a tracking bug for Project Elixir, which is an effort to rewrite the bot health sheriff documentation to better reflect the work that sheriffs actually do. This is necessary because we need to onboard more sheriffs in order to reduce the frequency of our sheriff shifts and thus the overall workload on each of our sheriffs.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e17628398e7bbaa36ca5945e66434257af0d7210

commit e17628398e7bbaa36ca5945e66434257af0d7210
Author: Charlie Andrews <charliea@chromium.org>
Date: Fri May 11 17:49:18 2018

Adds a doc about how to identify what stories are failing

R=nednguyen@chromium.org

Bug:  842232 
Change-Id: Iacafeec6abed7d36ef2a2cb06c0bd7919f9eab94
Reviewed-on: https://chromium-review.googlesource.com/1055730
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Charlie Andrews <charliea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557926}
[add] https://crrev.com/e17628398e7bbaa36ca5945e66434257af0d7210/docs/speed/bot_health_sheriffing/flakiness_dashboard.png
[add] https://crrev.com/e17628398e7bbaa36ca5945e66434257af0d7210/docs/speed/bot_health_sheriffing/what_test_is_failing.md

Project Member

Comment 3 by bugdroid1@chromium.org, May 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/292b1d6642352d95fe32d06dd1614d12954057dd

commit 292b1d6642352d95fe32d06dd1614d12954057dd
Author: Charlie Andrews <charliea@chromium.org>
Date: Mon May 14 18:54:32 2018

Add a doc on how to disable a failing benchmark or story in Telemetry

This is the markdown version of https://goo.gl/KfgF2h

R=eyaich@chromium.org

Bug:  842232 
Change-Id: Id59e233071b1a7d1fe424ace4ea1f23aae47d7c8
Reviewed-on: https://chromium-review.googlesource.com/1057840
Reviewed-by: Emily Hanley <eyaich@chromium.org>
Commit-Queue: Charlie Andrews <charliea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558393}
[add] https://crrev.com/292b1d6642352d95fe32d06dd1614d12954057dd/docs/speed/bot_health_sheriffing/how_to_disable_a_story.md

Project Member

Comment 5 by bugdroid1@chromium.org, May 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8e9e6b398dde4401ee40c58619356471ad0e1ca1

commit 8e9e6b398dde4401ee40c58619356471ad0e1ca1
Author: Charlie Andrews <charliea@chromium.org>
Date: Tue May 15 19:23:10 2018

Add doc on how to follow up with an alert

Bug:  842232 
Change-Id: I6c00da413a8e1138f62ff578224aa0d1a2e2f599
Reviewed-on: https://chromium-review.googlesource.com/1060122
Commit-Queue: Charlie Andrews <charliea@chromium.org>
Reviewed-by: Emily Hanley <eyaich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558804}
[add] https://crrev.com/8e9e6b398dde4401ee40c58619356471ad0e1ca1/docs/speed/bot_health_sheriffing/how_to_follow_up_on_an_alert.md

Project Member

Comment 6 by bugdroid1@chromium.org, May 16 2018

Project Member

Comment 7 by bugdroid1@chromium.org, May 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3156913e47bc977103363ebc19219bd88ab4872e

commit 3156913e47bc977103363ebc19219bd88ab4872e
Author: Charlie Andrews <charliea@chromium.org>
Date: Wed May 16 18:25:06 2018

Move all bot health images into an images/ directory

TBR=eyaich@chromium.org

Bug:  842232 
Change-Id: I01d6db483807f9e7840434f586e608b8d92a490a
Reviewed-on: https://chromium-review.googlesource.com/1062285
Reviewed-by: Charlie Andrews <charliea@chromium.org>
Commit-Queue: Charlie Andrews <charliea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559191}
[modify] https://crrev.com/3156913e47bc977103363ebc19219bd88ab4872e/docs/speed/bot_health_sheriffing/how_to_access_test_logs.md
[modify] https://crrev.com/3156913e47bc977103363ebc19219bd88ab4872e/docs/speed/bot_health_sheriffing/how_to_address_duplicate_alerts.md
[modify] https://crrev.com/3156913e47bc977103363ebc19219bd88ab4872e/docs/speed/bot_health_sheriffing/how_to_snooze_an_alert.md
[rename] https://crrev.com/3156913e47bc977103363ebc19219bd88ab4872e/docs/speed/bot_health_sheriffing/images/bulk_ungroup.png
[rename] https://crrev.com/3156913e47bc977103363ebc19219bd88ab4872e/docs/speed/bot_health_sheriffing/images/change_group_name.png
[rename] https://crrev.com/3156913e47bc977103363ebc19219bd88ab4872e/docs/speed/bot_health_sheriffing/images/flakiness_dashboard.png
[rename] https://crrev.com/3156913e47bc977103363ebc19219bd88ab4872e/docs/speed/bot_health_sheriffing/images/group_all.png
[rename] https://crrev.com/3156913e47bc977103363ebc19219bd88ab4872e/docs/speed/bot_health_sheriffing/images/snooze_alert.png
[rename] https://crrev.com/3156913e47bc977103363ebc19219bd88ab4872e/docs/speed/bot_health_sheriffing/images/snooze_alert_dialog.png
[rename] https://crrev.com/3156913e47bc977103363ebc19219bd88ab4872e/docs/speed/bot_health_sheriffing/images/som_choose_build_number.png
[rename] https://crrev.com/3156913e47bc977103363ebc19219bd88ab4872e/docs/speed/bot_health_sheriffing/images/som_choose_non_green_only.png
[rename] https://crrev.com/3156913e47bc977103363ebc19219bd88ab4872e/docs/speed/bot_health_sheriffing/images/som_examine.png
[rename] https://crrev.com/3156913e47bc977103363ebc19219bd88ab4872e/docs/speed/bot_health_sheriffing/images/som_examine_choose_bot.png
[rename] https://crrev.com/3156913e47bc977103363ebc19219bd88ab4872e/docs/speed/bot_health_sheriffing/images/som_shard_0.png
[rename] https://crrev.com/3156913e47bc977103363ebc19219bd88ab4872e/docs/speed/bot_health_sheriffing/images/som_test_steps_shard_0.png
[rename] https://crrev.com/3156913e47bc977103363ebc19219bd88ab4872e/docs/speed/bot_health_sheriffing/images/ungroup_all.png
[modify] https://crrev.com/3156913e47bc977103363ebc19219bd88ab4872e/docs/speed/bot_health_sheriffing/what_test_is_failing.md

Project Member

Comment 8 by bugdroid1@chromium.org, May 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fd35b20e4389fa63c77f823b250950122c2c84d1

commit fd35b20e4389fa63c77f823b250950122c2c84d1
Author: Charlie Andrews <charliea@chromium.org>
Date: Fri May 18 14:38:26 2018

Add a new doc on how to launch a functional bisect and interpet results

R=eyaich@chromium.org

Bug:  842232 
Change-Id: I97320db313f78da70ecb9ca4dc1a55ce7ffc19e5
Reviewed-on: https://chromium-review.googlesource.com/1062833
Commit-Queue: Charlie Andrews <charliea@chromium.org>
Reviewed-by: Emily Hanley <eyaich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559887}
[add] https://crrev.com/fd35b20e4389fa63c77f823b250950122c2c84d1/docs/speed/bot_health_sheriffing/how_to_launch_a_functional_bisect.md
[add] https://crrev.com/fd35b20e4389fa63c77f823b250950122c2c84d1/docs/speed/bot_health_sheriffing/images/flakiness_flaky_test.png
[add] https://crrev.com/fd35b20e4389fa63c77f823b250950122c2c84d1/docs/speed/bot_health_sheriffing/images/flakiness_flaky_test_good_bad_revisions.png
[add] https://crrev.com/fd35b20e4389fa63c77f823b250950122c2c84d1/docs/speed/bot_health_sheriffing/images/flakiness_revision_bad.png
[add] https://crrev.com/fd35b20e4389fa63c77f823b250950122c2c84d1/docs/speed/bot_health_sheriffing/images/flakiness_revision_good.png
[add] https://crrev.com/fd35b20e4389fa63c77f823b250950122c2c84d1/docs/speed/bot_health_sheriffing/images/flakiness_simple.png
[add] https://crrev.com/fd35b20e4389fa63c77f823b250950122c2c84d1/docs/speed/bot_health_sheriffing/images/perf_dashboard_graph.png
[add] https://crrev.com/fd35b20e4389fa63c77f823b250950122c2c84d1/docs/speed/bot_health_sheriffing/images/perf_dashboard_revision.png
[add] https://crrev.com/fd35b20e4389fa63c77f823b250950122c2c84d1/docs/speed/bot_health_sheriffing/images/perf_dashboard_start_bisect.png
[add] https://crrev.com/fd35b20e4389fa63c77f823b250950122c2c84d1/docs/speed/bot_health_sheriffing/images/pinpoint_bug_comment.png
[add] https://crrev.com/fd35b20e4389fa63c77f823b250950122c2c84d1/docs/speed/bot_health_sheriffing/images/pinpoint_graph.png
[add] https://crrev.com/fd35b20e4389fa63c77f823b250950122c2c84d1/docs/speed/bot_health_sheriffing/images/pinpoint_run_info.png
[add] https://crrev.com/fd35b20e4389fa63c77f823b250950122c2c84d1/docs/speed/bot_health_sheriffing/images/pinpoint_run_info_logs.png

Project Member

Comment 10 by bugdroid1@chromium.org, May 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3c060ba7e9b01936e00c36ea7f190ed0007db715

commit 3c060ba7e9b01936e00c36ea7f190ed0007db715
Author: Charlie Andrews <charliea@chromium.org>
Date: Fri May 18 20:03:21 2018

Add a new bot health sheriff glossary doc

TBR=eyaich@chromium.org

Bug:  842232 
Change-Id: I18fc2d9e9bc4377d190cfb92fdfe9bc627086ec1
Reviewed-on: https://chromium-review.googlesource.com/1066490
Reviewed-by: Charlie Andrews <charliea@chromium.org>
Commit-Queue: Charlie Andrews <charliea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560000}
[add] https://crrev.com/3c060ba7e9b01936e00c36ea7f190ed0007db715/docs/speed/bot_health_sheriffing/glossary.md

Project Member

Comment 12 by bugdroid1@chromium.org, May 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/01ce72edb648ed9295f00c97afbe5eda1619c422

commit 01ce72edb648ed9295f00c97afbe5eda1619c422
Author: Charlie Andrews <charliea@chromium.org>
Date: Fri May 18 20:19:43 2018

Modify all old docs to refer to new bot health documentation

TBR=sullivan@chromium.org

Bug:  842232 
Change-Id: If557fca2355175cd980780e08e82c1f7269f645e
Reviewed-on: https://chromium-review.googlesource.com/1066592
Reviewed-by: Charlie Andrews <charliea@chromium.org>
Commit-Queue: Charlie Andrews <charliea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560008}
[modify] https://crrev.com/01ce72edb648ed9295f00c97afbe5eda1619c422/docs/speed/perf_bot_sheriffing.md
[modify] https://crrev.com/01ce72edb648ed9295f00c97afbe5eda1619c422/docs/speed/perf_waterfall.md

Project Member

Comment 13 by bugdroid1@chromium.org, May 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c6e4b59a852fbfb07b7f5625e4096143ab183d63

commit c6e4b59a852fbfb07b7f5625e4096143ab183d63
Author: Charlie Andrews <charliea@chromium.org>
Date: Fri May 18 20:48:54 2018

Fix a typo in the main doc

TBR=sullivan@chromium.org

Bug:  842232 
Change-Id: I158e1f0814e2311057067bb4287f91dab53c5794
Reviewed-on: https://chromium-review.googlesource.com/1066631
Reviewed-by: Charlie Andrews <charliea@chromium.org>
Commit-Queue: Charlie Andrews <charliea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560018}
[modify] https://crrev.com/c6e4b59a852fbfb07b7f5625e4096143ab183d63/docs/speed/bot_health_sheriffing/main.md

Project Member

Comment 15 by bugdroid1@chromium.org, May 31 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5e1d85fb27dcf639b2773d6a11b7ad576e375314

commit 5e1d85fb27dcf639b2773d6a11b7ad576e375314
Author: Emily Hanley <eyaich@google.com>
Date: Thu May 31 18:05:40 2018

Updating docs for failing test for new perf recipe

Bug:  842232 
Change-Id: I7b1bb376b0cfb4a738712f99c44d706a59cce3d3
Reviewed-on: https://chromium-review.googlesource.com/1071771
Reviewed-by: Charlie Andrews <charliea@chromium.org>
Commit-Queue: Emily Hanley <eyaich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563314}
[add] https://crrev.com/5e1d85fb27dcf639b2773d6a11b7ad576e375314/docs/speed/bot_health_sheriffing/images/flakiness_dashboard_new_recipe.png
[modify] https://crrev.com/5e1d85fb27dcf639b2773d6a11b7ad576e375314/docs/speed/bot_health_sheriffing/what_test_is_failing.md

Status: Fixed (was: Assigned)
Marking this as "fixed" given that the major rewrite is done.
Project Member

Comment 17 by bugdroid1@chromium.org, Jun 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9165a6ed6de8d9ebd4efd4d6d541dded9c1a2163

commit 9165a6ed6de8d9ebd4efd4d6d541dded9c1a2163
Author: Juan Antonio Navarro Perez <perezju@chromium.org>
Date: Fri Jun 15 17:53:55 2018

[tools/perf] Update link to story disabling documentation

The link from the expectations.config file itself was outdated.

Bug:  842232 
Change-Id: I8260c338b1cc176136cf24bea0adc921b442a87b
Reviewed-on: https://chromium-review.googlesource.com/1102323
Commit-Queue: Charlie Andrews <charliea@chromium.org>
Reviewed-by: Charlie Andrews <charliea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567726}
[modify] https://crrev.com/9165a6ed6de8d9ebd4efd4d6d541dded9c1a2163/tools/perf/expectations.config

Cc: sullivan@chromium.org benhenry@chromium.org charliea@chromium.org
 Issue 739872  has been merged into this issue.

Sign in to add a comment