New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 842227 link

Starred by 3 users
Status: Assigned
Owner:
█ lincolnfrog@chromium.org
Last visit > 30 days ago
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task
Proj-VR
Proj-XR



Sign in to add a comment

Rename vr_device_base private virtual OnXXX methods to be HandleOnXXX

Project Member Reported by ijamardo@chromium.org, May 11 2018 
The naming of the private methods in the vr_device_base could be improved. These methods are called from other methods in the class.

Comment 1 by ddorwin@chromium.org, May 11 2018

Components: Blink>WebVR
Labels: -Type-Bug Type-Task
Status: Available (was: Untriaged)
We may also want to slightly rename the methods. For example, OnListeningForActivate might be HandleListeningForActivateChange.

Comment 2 by ddorwin@chromium.org, May 26 2018

Labels: XR-Device

Comment 3 by ddorwin@chromium.org, Jun 8 2018

Owner: lincolnfrog@chromium.org
Status: Assigned (was: Available)

Comment 4 by btebbs@chromium.org, Jul 4

Components: Blink>WebXR

Comment 5 by efoo@chromium.org, Aug 7

Labels: BlinkWebXR
Removing Blink>WebVR component and assigning to Blink>WebXR

Comment 6 by efoo@chromium.org, Aug 7

Labels: -BlinkWebXR
Removing Blink>WebVR component and assigning to Blink>WebXR

Comment 7 by efoo@chromium.org, Aug 7

Components: -Blink>WebVR

Comment 8 by btebbs@chromium.org, Sep 4

Labels: AR-Cleanup
►

Sign in to add a comment