New issue
Advanced search Search tips

Issue 842225 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 14
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 845913



Sign in to add a comment

Media nodes should only be constructible for AudioContexts

Project Member Reported by rtoy@chromium.org, May 11 2018

Issue description

See https://github.com/WebAudio/web-audio-api/issues/1607

The factory methods don't work for an OfflineAudioContext, so the constructors shouldn't support that either.

 

Comment 1 by rtoy@chromium.org, May 23 2018

Blockedon: 845913
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/79cb0630cf6ad293e913124fe0f51872a587005b

commit 79cb0630cf6ad293e913124fe0f51872a587005b
Author: Raymond Toy <rtoy@chromium.org>
Date: Fri Oct 05 21:50:00 2018

Move Media nodes to AudioContext

The Media nodes should be on the AudioContext, not BaseAudioContext.
Make it so.  This also implies that the constructors for these nodes
should take an AudioContext, not BaseAudioContext.

Intent: https://groups.google.com/a/chromium.org/d/msg/blink-dev/H29uXnsIN54/BKXDqxoJAQAJ
Chrome feature entry: https://www.chromestatus.com/feature/5258622686724096

Bug:  845913 ,  842225 ,  697123 
Change-Id: Ic2a82a2343fa4a169a26733375c646fec61769ed
Reviewed-on: https://chromium-review.googlesource.com/c/1069692
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597322}
[modify] https://crrev.com/79cb0630cf6ad293e913124fe0f51872a587005b/content/test/data/media/mediarecorder_test.html
[modify] https://crrev.com/79cb0630cf6ad293e913124fe0f51872a587005b/third_party/WebKit/LayoutTests/external/wpt/webaudio/idlharness.https-expected.txt
[modify] https://crrev.com/79cb0630cf6ad293e913124fe0f51872a587005b/third_party/WebKit/LayoutTests/external/wpt/webaudio/idlharness.https.window-expected.txt
[modify] https://crrev.com/79cb0630cf6ad293e913124fe0f51872a587005b/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/79cb0630cf6ad293e913124fe0f51872a587005b/third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-nominal-range-expected.txt
[modify] https://crrev.com/79cb0630cf6ad293e913124fe0f51872a587005b/third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-nominal-range.html
[modify] https://crrev.com/79cb0630cf6ad293e913124fe0f51872a587005b/third_party/WebKit/LayoutTests/webaudio/MediaStreamAudioDestination/ctor-mediastreamaudiodestination.html
[modify] https://crrev.com/79cb0630cf6ad293e913124fe0f51872a587005b/third_party/WebKit/LayoutTests/webaudio/MediaStreamAudioSource/ctor-mediastreamaudiosource.html
[modify] https://crrev.com/79cb0630cf6ad293e913124fe0f51872a587005b/third_party/WebKit/LayoutTests/webaudio/dom-exceptions-expected.txt
[modify] https://crrev.com/79cb0630cf6ad293e913124fe0f51872a587005b/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/79cb0630cf6ad293e913124fe0f51872a587005b/third_party/blink/renderer/modules/webaudio/audio_context.cc
[modify] https://crrev.com/79cb0630cf6ad293e913124fe0f51872a587005b/third_party/blink/renderer/modules/webaudio/audio_context.h
[modify] https://crrev.com/79cb0630cf6ad293e913124fe0f51872a587005b/third_party/blink/renderer/modules/webaudio/audio_context.idl
[modify] https://crrev.com/79cb0630cf6ad293e913124fe0f51872a587005b/third_party/blink/renderer/modules/webaudio/base_audio_context.cc
[modify] https://crrev.com/79cb0630cf6ad293e913124fe0f51872a587005b/third_party/blink/renderer/modules/webaudio/base_audio_context.h
[modify] https://crrev.com/79cb0630cf6ad293e913124fe0f51872a587005b/third_party/blink/renderer/modules/webaudio/base_audio_context.idl
[modify] https://crrev.com/79cb0630cf6ad293e913124fe0f51872a587005b/third_party/blink/renderer/modules/webaudio/media_element_audio_source_node.cc
[modify] https://crrev.com/79cb0630cf6ad293e913124fe0f51872a587005b/third_party/blink/renderer/modules/webaudio/media_element_audio_source_node.h
[modify] https://crrev.com/79cb0630cf6ad293e913124fe0f51872a587005b/third_party/blink/renderer/modules/webaudio/media_element_audio_source_node.idl
[modify] https://crrev.com/79cb0630cf6ad293e913124fe0f51872a587005b/third_party/blink/renderer/modules/webaudio/media_stream_audio_destination_node.cc
[modify] https://crrev.com/79cb0630cf6ad293e913124fe0f51872a587005b/third_party/blink/renderer/modules/webaudio/media_stream_audio_destination_node.h
[modify] https://crrev.com/79cb0630cf6ad293e913124fe0f51872a587005b/third_party/blink/renderer/modules/webaudio/media_stream_audio_destination_node.idl
[modify] https://crrev.com/79cb0630cf6ad293e913124fe0f51872a587005b/third_party/blink/renderer/modules/webaudio/media_stream_audio_source_node.cc
[modify] https://crrev.com/79cb0630cf6ad293e913124fe0f51872a587005b/third_party/blink/renderer/modules/webaudio/media_stream_audio_source_node.h
[modify] https://crrev.com/79cb0630cf6ad293e913124fe0f51872a587005b/third_party/blink/renderer/modules/webaudio/media_stream_audio_source_node.idl

Owner: rtoy@chromium.org
Status: Fixed (was: Available)

Sign in to add a comment