Showpress should get forwarded after a GFC followed by Tap down suppression. |
||
Issue descriptionShowpress should get forwarded after a GFC followed by Tap down suppression.
,
May 14 2018
,
May 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/89b1db1d27b85a92fa09b9a505d0b6b2545a0a74 commit 89b1db1d27b85a92fa09b9a505d0b6b2545a0a74 Author: Sahel Sharifymoghaddam <sahel@chromium.org> Date: Wed May 16 21:27:55 2018 Revert "Don't suppress Showpress after a GFC followed by Tap down suppression" This reverts commit 76b93d2deee7a24a588b7472a7b67a3acdf26172. Reason for revert: The cl is the root cause of crbug.com/843027 Original change's description: > Don't suppress Showpress after a GFC followed by Tap down suppression > > Showpress should get forwarded after a GFC followed by Tap down suppression. > > Bug: 842221 > Change-Id: I60beaf3296557ec8c3d3d25b627f272b82114eed > Reviewed-on: https://chromium-review.googlesource.com/1055653 > Reviewed-by: Dave Tapuska <dtapuska@chromium.org> > Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#557958} TBR=dtapuska@chromium.org,sahel@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 842221 , 843027 Change-Id: Ie47d1836059dd0336fa5c48a11bf5680e32f9adf Reviewed-on: https://chromium-review.googlesource.com/1062545 Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org> Reviewed-by: Sahel Sharifymoghaddam <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#559300} [modify] https://crrev.com/89b1db1d27b85a92fa09b9a505d0b6b2545a0a74/content/browser/renderer_host/input/fling_controller.cc [modify] https://crrev.com/89b1db1d27b85a92fa09b9a505d0b6b2545a0a74/content/browser/renderer_host/input/fling_controller_unittest.cc [modify] https://crrev.com/89b1db1d27b85a92fa09b9a505d0b6b2545a0a74/content/browser/renderer_host/input/touchscreen_tap_suppression_controller.cc
,
May 16 2018
This change is not needed anymore. With the revert in comment #4, we suppress a showpress after a GFC if the tap down event is suppressed. |
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, May 11 2018