Issue 842218 link

Starred by 2 users

Issue metadata

Status:	Fixed
Owner:	kylixrd@chromium.org
Closed:	May 2018
EstimatedDays:	----
NextAction:	----
OS:	Linux , Windows , Chrome , Mac
Pri:	2
Type:	Bug
Needs-Feedback Proj-MdRefresh

Under top-chrome-md=material-refresh mode, the close button isn't visible on the active tab

Project Member Reported by kylixrd@chromium.org, May 11 2018

Issue description

Chrome Version: 68.0.3427.0
OS: Windows, MacOS, Linux

On the active tab, the space for the close button is reserved, but it is not visible until the mouse hovers over it.

Project Member

Comment 1 by bugdroid1@chromium.org, May 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/035552498218737a9741615c1751136edf9cd6ad

commit 035552498218737a9741615c1751136edf9cd6ad
Author: Allen Bauer <kylixrd@chromium.org>
Date: Tue May 15 15:47:38 2018

Material Refresh - Make separator 20dip instead of 16dip. Always show close button on active tabs.

GetOpacity() didn't handle the active tab case where the close button should be always visible.



Bug:  822061 
Bug:  842218 
Change-Id: Id91e5ab402fb1e9e249f8cb60d1a26a3c9a3c46e
Reviewed-on: https://chromium-review.googlesource.com/1055648
Commit-Queue: Allen Bauer <kylixrd@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558717}
[modify] https://crrev.com/035552498218737a9741615c1751136edf9cd6ad/chrome/browser/ui/views/tabs/tab.cc
[modify] https://crrev.com/035552498218737a9741615c1751136edf9cd6ad/chrome/browser/ui/views/tabs/tab_close_button.cc

Comment 2 by susan.boorgula@chromium.org, May 16 2018

Labels: Needs-Feedback

Tested this issue on Windows 10, Mac OS 10.13.3 and Ubuntu 14.04 on the reported version 68.0.3427.0 and the latest Canary 68.0.3430.0.
Able to repro the issue Windows 10 and Ubuntu 14.04 on the reported version 68.0.3427.0 and the issue is fixed on the latest Canary 68.0.3430.0.
Attached is the screen cast for reference.

But unable to reproduce the issue on the reported version 68.0.3427.0 on Mac OS 10.13.3. 
On changing the  Material Design refresh flag to Refresh, can observe that the close button is visible.
Attached is the screen shot for reference.

kylixrd@ Request you to check and confirm the behavior on Mac OS.

Thanks..