Issue metadata
Sign in to add a comment
|
Memory regressions due to 'Disable embedded builtins' |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
May 11 2018
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8946806468290955472
,
May 12 2018
=== Auto-CCing suspected CL author jgruber@chromium.org === Hi jgruber@chromium.org, the bisect results pointed to your CL, please take a look at the results. === BISECT JOB RESULTS === Perf regression found with culprit Suspected Commit Author : jgruber Commit : e0c3f6d6ca005185e537fb85bbe841fe5dae5240 Date : Tue May 08 11:21:37 2018 Subject: Disable embedded builtins Bisect Details Configuration: clankium-phone-perf-bisect Benchmark : system_health.memory_mobile Metric : memory:chrome:all_processes:reported_by_chrome:v8:allocated_objects_size_avg/load_chrome/load_chrome_blank Change : 46.31% | 740012.0 -> 1082732.0 Revision Result N android-chrome@be902aa047 740012 +- 0.0 6 good android-chrome@be902aa047,chromium@556849 740032 +- 0.0 6 good android-chrome@be902aa047,chromium@556890 740032 +- 0.0 6 good android-chrome@be902aa047,chromium@556893 740032 +- 0.0 6 good android-chrome@be902aa047,chromium@556894 740032 +- 0.0 6 good android-chrome@be902aa047,chromium@556894,v8@855850eb7f 740024 +- 0.0 6 good android-chrome@be902aa047,chromium@556894,v8@e0c3f6d6ca 1083208 +- 0.0 6 bad <-- android-chrome@be902aa047,chromium@556894,v8@c34562803e 1083208 +- 0.0 6 bad android-chrome@be902aa047,chromium@556894,v8@9f5018c9b0 1083208 +- 0.0 6 bad android-chrome@be902aa047,chromium@556894,v8@61af2762ef 1082732 +- 0.0 6 bad android-chrome@be902aa047,chromium@556895 1082732 +- 0.0 6 bad android-chrome@be902aa047,chromium@556901 1082732 +- 0.0 6 bad android-chrome@be902aa047,chromium@556911 1082732 +- 0.0 6 bad android-chrome@1390428f76 1082732 +- 0.0 6 bad android-chrome@41db54dacb 1082732 +- 0.0 6 bad Please refer to the following doc on diagnosing memory regressions: https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md To Run This Test src/tools/perf/run_benchmark -v --browser=android-chrome --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=load.chrome.blank system_health.memory_mobile More information on addressing performance regressions: http://g.co/ChromePerformanceRegressions Debug information about this bisect: https://chromeperf.appspot.com/buildbucket_job_status/8946806468290955472 For feedback, file a bug with component Speed>Bisection
,
May 12 2018
Issue 842217 has been merged into this issue.
,
May 14 2018
Embedded builtins will be reenabled once performance regressions are fixed.
,
May 14 2018
Issue 842216 has been merged into this issue.
,
May 14 2018
Issue 842611 has been merged into this issue.
,
May 14 2018
Issue 842615 has been merged into this issue.
,
May 15 2018
,
May 15 2018
Issue 842776 has been merged into this issue.
,
May 15 2018
Issue 842610 has been merged into this issue.
,
May 15 2018
,
May 15 2018
Issue 842616 has been merged into this issue.
,
May 15 2018
Issue 842775 has been merged into this issue.
,
May 16 2018
,
May 16 2018
Issue 841778 has been merged into this issue.
,
May 17 2018
Issue 843173 has been merged into this issue.
,
May 17 2018
Issue 843175 has been merged into this issue.
,
May 18 2018
,
May 21 2018
Just want to double-check. Should we expect the regressions to be already fixed? Or is the fix coming?
,
May 22 2018
No, the regressions are not fixed yet. They will be when embedded builtins are reenabled. I'm still working on related performance concerns.
,
May 22 2018
,
May 22 2018
Then let's keep this open and close after fix is confirmed.
,
May 23 2018
Issue 842700 has been merged into this issue.
,
May 24 2018
,
May 25 2018
,
May 25 2018
Issue 846672 has been merged into this issue.
,
May 28 2018
Issue 846670 has been merged into this issue.
,
May 29 2018
,
Jun 5 2018
Issue 846674 has been merged into this issue.
,
Aug 2
,
Aug 2
,
Oct 25
Embedded builtins are now on by default in all shipping configurations. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, May 11 2018