New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 842214 link

Starred by 10 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 25
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression

Blocking:
issue v8:6666



Sign in to add a comment

Memory regressions due to 'Disable embedded builtins'

Project Member Reported by ulan@google.com, May 11 2018

Issue description

See the link to graphs below.
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, May 11 2018

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=842214

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=23c50b733c83adc4ecc36bbb0031ad3d3ad05dcf8db24fdf5751230866a32a34


Bot(s) for this bug's original alert(s):

health-plan-clankium-low-end-phone
health-plan-clankium-phone
health-plan-webview-low-end-phone
health-plan-webview-phone
perf-go-phone-1024
perf-go-phone-512
perf-go-webview-phone
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, May 12 2018

Cc: jgruber@chromium.org
Owner: jgruber@chromium.org
Status: Assigned (was: Untriaged)

=== Auto-CCing suspected CL author jgruber@chromium.org ===

Hi jgruber@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : jgruber
  Commit : e0c3f6d6ca005185e537fb85bbe841fe5dae5240
  Date   : Tue May 08 11:21:37 2018
  Subject: Disable embedded builtins

Bisect Details
  Configuration: clankium-phone-perf-bisect
  Benchmark    : system_health.memory_mobile
  Metric       : memory:chrome:all_processes:reported_by_chrome:v8:allocated_objects_size_avg/load_chrome/load_chrome_blank
  Change       : 46.31% | 740012.0 -> 1082732.0

Revision                                                     Result              N
android-chrome@be902aa047                                    740012 +- 0.0       6      good
android-chrome@be902aa047,chromium@556849                    740032 +- 0.0       6      good
android-chrome@be902aa047,chromium@556890                    740032 +- 0.0       6      good
android-chrome@be902aa047,chromium@556893                    740032 +- 0.0       6      good
android-chrome@be902aa047,chromium@556894                    740032 +- 0.0       6      good
android-chrome@be902aa047,chromium@556894,v8@855850eb7f      740024 +- 0.0       6      good
android-chrome@be902aa047,chromium@556894,v8@e0c3f6d6ca      1083208 +- 0.0      6      bad       <--
android-chrome@be902aa047,chromium@556894,v8@c34562803e      1083208 +- 0.0      6      bad
android-chrome@be902aa047,chromium@556894,v8@9f5018c9b0      1083208 +- 0.0      6      bad
android-chrome@be902aa047,chromium@556894,v8@61af2762ef      1082732 +- 0.0      6      bad
android-chrome@be902aa047,chromium@556895                    1082732 +- 0.0      6      bad
android-chrome@be902aa047,chromium@556901                    1082732 +- 0.0      6      bad
android-chrome@be902aa047,chromium@556911                    1082732 +- 0.0      6      bad
android-chrome@1390428f76                                    1082732 +- 0.0      6      bad
android-chrome@41db54dacb                                    1082732 +- 0.0      6      bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chrome --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=load.chrome.blank system_health.memory_mobile

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8946806468290955472


For feedback, file a bug with component Speed>Bisection
Project Member

Comment 4 by 42576172...@developer.gserviceaccount.com, May 12 2018

 Issue 842217  has been merged into this issue.
Status: WontFix (was: Assigned)
Embedded builtins will be reenabled once performance regressions are fixed.
Cc: cwhan.t...@gmail.com mstarzinger@chromium.org szuend@google.com
 Issue 842216  has been merged into this issue.
Project Member

Comment 7 by 42576172...@developer.gserviceaccount.com, May 14 2018

 Issue 842611  has been merged into this issue.
Project Member

Comment 8 by 42576172...@developer.gserviceaccount.com, May 14 2018

 Issue 842615  has been merged into this issue.
Project Member

Comment 9 by 42576172...@developer.gserviceaccount.com, May 15 2018

Cc: nzolghadr@chromium.org
 Issue 842762  has been merged into this issue.
Project Member

Comment 10 by 42576172...@developer.gserviceaccount.com, May 15 2018

 Issue 842776  has been merged into this issue.
Project Member

Comment 11 by 42576172...@developer.gserviceaccount.com, May 15 2018

 Issue 842610  has been merged into this issue.
Cc: cbruni@chromium.org
 Issue 842672  has been merged into this issue.
 Issue 842616  has been merged into this issue.
Project Member

Comment 14 by 42576172...@developer.gserviceaccount.com, May 15 2018

 Issue 842775  has been merged into this issue.
Project Member

Comment 15 by 42576172...@developer.gserviceaccount.com, May 16 2018

Cc: perezju@google.com
 Issue 842716  has been merged into this issue.
Project Member

Comment 16 by 42576172...@developer.gserviceaccount.com, May 16 2018

 Issue 841778  has been merged into this issue.
Project Member

Comment 17 by 42576172...@developer.gserviceaccount.com, May 17 2018

 Issue 843173  has been merged into this issue.
Project Member

Comment 18 by 42576172...@developer.gserviceaccount.com, May 17 2018

 Issue 843175  has been merged into this issue.
Summary: Memory regressions due to 'Disable embedded builtins' (was: 2.9%-45% regression in memory.top_10_mobile at 1525825910:1525850609)
Just want to double-check. Should we expect the regressions to be already fixed? Or is the fix coming?
No, the regressions are not fixed yet. They will be when embedded builtins are reenabled. I'm still working on related performance concerns.
Cc: npm@chromium.org
 Issue 844473  has been merged into this issue.
Status: Assigned (was: WontFix)
Then let's keep this open and close after fix is confirmed.
 Issue 842700  has been merged into this issue.
Project Member

Comment 25 by 42576172...@developer.gserviceaccount.com, May 24 2018

Cc: sunyunjia@chromium.org
 Issue 846059  has been merged into this issue.
Project Member

Comment 26 by 42576172...@developer.gserviceaccount.com, May 25 2018

Cc: hpayer@chromium.org
 Issue 846667  has been merged into this issue.
Project Member

Comment 27 by 42576172...@developer.gserviceaccount.com, May 25 2018

 Issue 846672  has been merged into this issue.
Issue 846670 has been merged into this issue.
Cc: delph...@chromium.org
 Issue 846669  has been merged into this issue.
 Issue 846674  has been merged into this issue.
Components: Speed>Metrics>SystemHealthRegressions
Components: -Speed>Metrics>SystemHealthRegressions
Blocking: v8:6666
Status: Fixed (was: Assigned)
Embedded builtins are now on by default in all shipping configurations.

Sign in to add a comment