New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 842195 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: ----
Proj-Servicification



Sign in to add a comment

network_service_browser_tests failing on chromium.linux/linux-xenial-rel

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, May 11 2018

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of tmartino@chromium.org

network_service_browser_tests failing on chromium.linux/linux-xenial-rel

Builders failed on: 
- linux-xenial-rel: 
  https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-xenial-rel


 
Project Member

Comment 1 by bugdroid1@chromium.org, May 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9fedcd6889424af9766ebf07eab67d42ec0a9091

commit 9fedcd6889424af9766ebf07eab67d42ec0a9091
Author: Tommy Martino <tmartino@chromium.org>
Date: Fri May 11 16:53:22 2018

Disabling flaky test TestSBUpdateCookies

Full test name:
SafeBrowsingDatabaseManagerCookieTest.TestSBUpdateCookies

Link to failure:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-xenial-rel/54

Bug:  842195 
Change-Id: I807a6815fc65e75b3023095d8abd875ad2cf3e14

TBR=jialiul@chromium.org

Change-Id: I807a6815fc65e75b3023095d8abd875ad2cf3e14
Reviewed-on: https://chromium-review.googlesource.com/1055618
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Commit-Queue: Tommy Martino <tmartino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557905}
[modify] https://crrev.com/9fedcd6889424af9766ebf07eab67d42ec0a9091/chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc

Cc: jialiul@chromium.org
Owner: nhiroki@chromium.org
Status: Assigned (was: Available)
Disabled the test on Linux, and assigning to nhiroki@. Do you think this could be related to the feature you recently enabled? That was the last thing to touch this test file.

cc jialiul@ who was the OWNER TBR'd on the disabling CL.

Comment 3 by finnur@chromium.org, May 17 2018

Labels: -Sheriff-Chromium
Bug assigned, removing Sheriff label.
Cc: nhiroki@chromium.org
Components: Internals>Network>Cookies Services>Safebrowsing
Owner: ----
Status: Untriaged (was: Assigned)
I think my change[1] is not relevant. It should affect only WebSocket tests.
[1] https://chromium.googlesource.com/chromium/src/+/b3183b6eaa7077ae42a9d2f9c4a7309450f66707

Looks like this test is for cookies, so I'll add "Internals>Network/Cookies" components.

Comment 5 by mmenke@chromium.org, May 17 2018

Components: Internals>Services>Network
Labels: -Pri-2 Proj-Servicification-Canary Pri-1
Owner: jam@chromium.org
Status: Assigned (was: Untriaged)
[+jam]:  John, mind looking into this?

Comment 6 by dxie@chromium.org, May 18 2018

Labels: OS-Linux OS-Mac OS-Windows

Comment 7 by jam@chromium.org, May 22 2018

Status: Fixed (was: Assigned)
Looks like the flake in network_service_content_browsertests was the same as what's seen on Win Mojo, which was due to a flaky test suite. This was fixed in r560411 and this bot is now green.

Comment 8 by jam@chromium.org, May 22 2018

Status: Assigned (was: Fixed)
oh, I only looked at last 200 runs where the content_browsertests flakiness was. Now I read this closer and see there was a browser_tests flakiness with the SB test that got disabled. looking more.

Comment 9 by jam@chromium.org, May 24 2018

Status: Fixed (was: Assigned)
I can confirm that this is fixed by r560938. It's a race condition because the network service still had the safe browsing cookie store open sometimes. I'll revert the test disable
Project Member

Comment 10 by bugdroid1@chromium.org, May 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/74a03eca40ba76d19fad951183b8d4eaf8273223

commit 74a03eca40ba76d19fad951183b8d4eaf8273223
Author: John Abd-El-Malek <jam@chromium.org>
Date: Thu May 24 17:56:07 2018

Revert "Disabling flaky test TestSBUpdateCookies"

This reverts commit 9fedcd6889424af9766ebf07eab67d42ec0a9091.

Reason for revert: fixed after r560938

Original change's description:
> Disabling flaky test TestSBUpdateCookies
> 
> Full test name:
> SafeBrowsingDatabaseManagerCookieTest.TestSBUpdateCookies
> 
> Link to failure:
> https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-xenial-rel/54
> 
> Bug:  842195 
> Change-Id: I807a6815fc65e75b3023095d8abd875ad2cf3e14
> 
> TBR=jialiul@chromium.org
> 
> Change-Id: I807a6815fc65e75b3023095d8abd875ad2cf3e14
> Reviewed-on: https://chromium-review.googlesource.com/1055618
> Reviewed-by: Tommy Martino <tmartino@chromium.org>
> Commit-Queue: Tommy Martino <tmartino@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#557905}

TBR=tmartino@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  842195 
Change-Id: I1dfc6104223cc0ae27fb912d20befb98d77aa616
Reviewed-on: https://chromium-review.googlesource.com/1071848
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561546}
[modify] https://crrev.com/74a03eca40ba76d19fad951183b8d4eaf8273223/chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc

Sign in to add a comment