New issue
Advanced search Search tips

Issue 842181 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 842179



Sign in to add a comment

Update swarming UI out of polymer to web components

Project Member Reported by estaab@chromium.org, May 11 2018

Issue description

Swarming appears to still be using polymer 1 and Chrome will stop supporting it in a year.

https://cs.corp.google.com/github/luci/luci-py/appengine/swarming/ui/bower.json
 

Comment 1 by mar...@chromium.org, May 11 2018

Owner: kjlubick@chromium.org
Status: Assigned (was: Available)
Or stop using polymer, which _could_ be simpler. Assigning to Kevin for him to decide.

Comment 2 by estaab@chromium.org, May 11 2018

Blocking: 842179

Comment 3 by kjlubick@google.com, May 11 2018

Cc: jcgrego...@google.com
Polymer 3 would be the target if we are sticking with Polymer.

However, there's an experiment we are doing with just using native Web Components that seems promising and preferable.
Summary: Update swarming UI to polymer 2 (or some other alternative) (was: Update swarming UI to polymer 2)
Where some other alternative is currently native Web Components.
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-py.git/+/f588059a72e59356609ae8c0f517f65299579b24

commit f588059a72e59356609ae8c0f517f65299579b24
Author: Kevin Lubick <kjlubick@google.com>
Date: Thu Jun 07 18:55:05 2018

Add Karma tests for WebComponents swarming-index

This also adds a feature to swarming-app where "busy" tasks,
e.g. network requests, can control a spinner.  A followon CL
will actually make it spin.

One small creature comfort is a way to add in delays for when
viewing the demo page, to make it feel more life-like.

Bug: 842181
Change-Id: I043bc3c6200884e561f3917e4c067e75abbf4405
Reviewed-on: https://chromium-review.googlesource.com/1089658
Commit-Queue: Kevin Lubick <kjlubick@chromium.org>
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Reviewed-by: Joe Gregorio <jcgregorio@chromium.org>

[modify] https://crrev.com/f588059a72e59356609ae8c0f517f65299579b24/appengine/swarming/ui2/Makefile
[modify] https://crrev.com/f588059a72e59356609ae8c0f517f65299579b24/appengine/swarming/ui2/README.md
[modify] https://crrev.com/f588059a72e59356609ae8c0f517f65299579b24/appengine/swarming/ui2/dist/public_swarming_index-bundle.css
[modify] https://crrev.com/f588059a72e59356609ae8c0f517f65299579b24/appengine/swarming/ui2/dist/public_swarming_index-bundle.js
[modify] https://crrev.com/f588059a72e59356609ae8c0f517f65299579b24/appengine/swarming/ui2/dist/public_swarming_index.html
[add] https://crrev.com/f588059a72e59356609ae8c0f517f65299579b24/appengine/swarming/ui2/karma.conf.js
[modify] https://crrev.com/f588059a72e59356609ae8c0f517f65299579b24/appengine/swarming/ui2/modules/swarming-app/swarming-app.js
[modify] https://crrev.com/f588059a72e59356609ae8c0f517f65299579b24/appengine/swarming/ui2/modules/swarming-index/swarming-index-demo.js
[modify] https://crrev.com/f588059a72e59356609ae8c0f517f65299579b24/appengine/swarming/ui2/modules/swarming-index/swarming-index.js
[add] https://crrev.com/f588059a72e59356609ae8c0f517f65299579b24/appengine/swarming/ui2/modules/swarming-index/swarming-index_test.js
[modify] https://crrev.com/f588059a72e59356609ae8c0f517f65299579b24/appengine/swarming/ui2/package-lock.json
[modify] https://crrev.com/f588059a72e59356609ae8c0f517f65299579b24/appengine/swarming/ui2/package.json

Project Member

Comment 6 by bugdroid1@chromium.org, Jun 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-py.git/+/78083f5977c302721b17ad689b1465871c0c587b

commit 78083f5977c302721b17ad689b1465871c0c587b
Author: Kevin Lubick <kjlubick@google.com>
Date: Tue Jun 12 14:15:34 2018

Add more karma tests for Swarming UI

Tests added for swarming-app and oauth-login.

This was a bit more tricky than anticipated because of how Karma
loads things into the browser.

We no longer have a way to signal autorebuild, but perhaps someone
could write a custom case using 'watch' or a similar third party tool
that watches the directory and automatically runs make test.

We now minify the output HTML a bit better, which trims down
public_swarming_index.html from 1051 bytes (614 bytes gzipped) to
766 bytes (493 bytes gzipped) after.

Also add the spinner to indicate things are loading, as was promised
in a previous CL.

Also also adds some bare pages for the bot-list, task-page, etc.

Bug: 842181
Change-Id: I256215f2a4333964a6a899577cb6f2e0d5731737
Reviewed-on: https://chromium-review.googlesource.com/1093558
Commit-Queue: Kevin Lubick <kjlubick@chromium.org>
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>

[modify] https://crrev.com/78083f5977c302721b17ad689b1465871c0c587b/appengine/swarming/ui2/.gitignore
[modify] https://crrev.com/78083f5977c302721b17ad689b1465871c0c587b/appengine/swarming/ui2/Makefile
[modify] https://crrev.com/78083f5977c302721b17ad689b1465871c0c587b/appengine/swarming/ui2/README.md
[add] https://crrev.com/78083f5977c302721b17ad689b1465871c0c587b/appengine/swarming/ui2/dist/public_bot_index-bundle.css
[add] https://crrev.com/78083f5977c302721b17ad689b1465871c0c587b/appengine/swarming/ui2/dist/public_bot_index-bundle.js
[add] https://crrev.com/78083f5977c302721b17ad689b1465871c0c587b/appengine/swarming/ui2/dist/public_bot_index.html
[add] https://crrev.com/78083f5977c302721b17ad689b1465871c0c587b/appengine/swarming/ui2/dist/public_botlist_index-bundle.css
[add] https://crrev.com/78083f5977c302721b17ad689b1465871c0c587b/appengine/swarming/ui2/dist/public_botlist_index-bundle.js
[add] https://crrev.com/78083f5977c302721b17ad689b1465871c0c587b/appengine/swarming/ui2/dist/public_botlist_index.html
[modify] https://crrev.com/78083f5977c302721b17ad689b1465871c0c587b/appengine/swarming/ui2/dist/public_swarming_index-bundle.css
[modify] https://crrev.com/78083f5977c302721b17ad689b1465871c0c587b/appengine/swarming/ui2/dist/public_swarming_index-bundle.js
[modify] https://crrev.com/78083f5977c302721b17ad689b1465871c0c587b/appengine/swarming/ui2/dist/public_swarming_index.html
[add] https://crrev.com/78083f5977c302721b17ad689b1465871c0c587b/appengine/swarming/ui2/dist/public_task_index-bundle.css
[add] https://crrev.com/78083f5977c302721b17ad689b1465871c0c587b/appengine/swarming/ui2/dist/public_task_index-bundle.js
[add] https://crrev.com/78083f5977c302721b17ad689b1465871c0c587b/appengine/swarming/ui2/dist/public_task_index.html
[add] https://crrev.com/78083f5977c302721b17ad689b1465871c0c587b/appengine/swarming/ui2/dist/public_tasklist_index-bundle.css
[add] https://crrev.com/78083f5977c302721b17ad689b1465871c0c587b/appengine/swarming/ui2/dist/public_tasklist_index-bundle.js
[add] https://crrev.com/78083f5977c302721b17ad689b1465871c0c587b/appengine/swarming/ui2/dist/public_tasklist_index.html
[modify] https://crrev.com/78083f5977c302721b17ad689b1465871c0c587b/appengine/swarming/ui2/karma.conf.js
[modify] https://crrev.com/78083f5977c302721b17ad689b1465871c0c587b/appengine/swarming/ui2/modules/oauth-login/oauth-login.js
[add] https://crrev.com/78083f5977c302721b17ad689b1465871c0c587b/appengine/swarming/ui2/modules/oauth-login/oauth-login_test.js
[modify] https://crrev.com/78083f5977c302721b17ad689b1465871c0c587b/appengine/swarming/ui2/modules/swarming-app/index.js
[modify] https://crrev.com/78083f5977c302721b17ad689b1465871c0c587b/appengine/swarming/ui2/modules/swarming-app/swarming-app-demo.html
[modify] https://crrev.com/78083f5977c302721b17ad689b1465871c0c587b/appengine/swarming/ui2/modules/swarming-app/swarming-app-demo.js
[modify] https://crrev.com/78083f5977c302721b17ad689b1465871c0c587b/appengine/swarming/ui2/modules/swarming-app/swarming-app.js
[modify] https://crrev.com/78083f5977c302721b17ad689b1465871c0c587b/appengine/swarming/ui2/modules/swarming-app/swarming-app.scss
[add] https://crrev.com/78083f5977c302721b17ad689b1465871c0c587b/appengine/swarming/ui2/modules/swarming-app/swarming-app_test.js
[modify] https://crrev.com/78083f5977c302721b17ad689b1465871c0c587b/appengine/swarming/ui2/modules/swarming-index/swarming-index-demo.html
[modify] https://crrev.com/78083f5977c302721b17ad689b1465871c0c587b/appengine/swarming/ui2/modules/swarming-index/swarming-index-demo.js
[modify] https://crrev.com/78083f5977c302721b17ad689b1465871c0c587b/appengine/swarming/ui2/modules/swarming-index/swarming-index.js
[modify] https://crrev.com/78083f5977c302721b17ad689b1465871c0c587b/appengine/swarming/ui2/modules/swarming-index/swarming-index_test.js
[modify] https://crrev.com/78083f5977c302721b17ad689b1465871c0c587b/appengine/swarming/ui2/package-lock.json
[modify] https://crrev.com/78083f5977c302721b17ad689b1465871c0c587b/appengine/swarming/ui2/package.json
[add] https://crrev.com/78083f5977c302721b17ad689b1465871c0c587b/appengine/swarming/ui2/pages/public_bot_index.html
[add] https://crrev.com/78083f5977c302721b17ad689b1465871c0c587b/appengine/swarming/ui2/pages/public_bot_index.js
[add] https://crrev.com/78083f5977c302721b17ad689b1465871c0c587b/appengine/swarming/ui2/pages/public_botlist_index.html
[add] https://crrev.com/78083f5977c302721b17ad689b1465871c0c587b/appengine/swarming/ui2/pages/public_botlist_index.js
[modify] https://crrev.com/78083f5977c302721b17ad689b1465871c0c587b/appengine/swarming/ui2/pages/public_swarming_index.html
[add] https://crrev.com/78083f5977c302721b17ad689b1465871c0c587b/appengine/swarming/ui2/pages/public_task_index.html
[add] https://crrev.com/78083f5977c302721b17ad689b1465871c0c587b/appengine/swarming/ui2/pages/public_task_index.js
[add] https://crrev.com/78083f5977c302721b17ad689b1465871c0c587b/appengine/swarming/ui2/pages/public_tasklist_index.html
[add] https://crrev.com/78083f5977c302721b17ad689b1465871c0c587b/appengine/swarming/ui2/pages/public_tasklist_index.js
[modify] https://crrev.com/78083f5977c302721b17ad689b1465871c0c587b/appengine/swarming/ui2/webpack.config.js

Project Member

Comment 7 by bugdroid1@chromium.org, Jun 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-py.git/+/b252bedf9d7c1de778ce3d6a767787261c5ca082

commit b252bedf9d7c1de778ce3d6a767787261c5ca082
Author: Kevin Lubick <kjlubick@google.com>
Date: Wed Jun 20 19:41:35 2018

[ui] Integrate JSDoc as a build rule.

Additionally, refactor swarming-app to use SwarmingAppBoilerplate, which
will be used by bot-list and every other top level app.

An update to elements-sk@2.1 lets us use the renamed and smaller
icon-sk elements.

This also re-works the imports to align with the best-practices,
that is, a module's index.js only be ./module.js and ./module.s?css
and all other imports to go in ./module.js

I found a few typos in the main ui/ page so fixes for those are
here too.


Bug: 842181
Change-Id: I59d0076e3ffc3b62717749d630f26f3459827259
Reviewed-on: https://chromium-review.googlesource.com/1108079
Reviewed-by: Joe Gregorio <jcgregorio@chromium.org>

[modify] https://crrev.com/b252bedf9d7c1de778ce3d6a767787261c5ca082/appengine/swarming/ui/build/elements.html
[modify] https://crrev.com/b252bedf9d7c1de778ce3d6a767787261c5ca082/appengine/swarming/ui/res/imp/botlist/bot-list-data.html
[modify] https://crrev.com/b252bedf9d7c1de778ce3d6a767787261c5ca082/appengine/swarming/ui/res/imp/common/dynamic-table-behavior.html
[modify] https://crrev.com/b252bedf9d7c1de778ce3d6a767787261c5ca082/appengine/swarming/ui/res/imp/common/swarming-app.html
[modify] https://crrev.com/b252bedf9d7c1de778ce3d6a767787261c5ca082/appengine/swarming/ui2/.gitignore
[modify] https://crrev.com/b252bedf9d7c1de778ce3d6a767787261c5ca082/appengine/swarming/ui2/Makefile
[modify] https://crrev.com/b252bedf9d7c1de778ce3d6a767787261c5ca082/appengine/swarming/ui2/README.md
[modify] https://crrev.com/b252bedf9d7c1de778ce3d6a767787261c5ca082/appengine/swarming/ui2/dist/custom-elements.min.js
[modify] https://crrev.com/b252bedf9d7c1de778ce3d6a767787261c5ca082/appengine/swarming/ui2/dist/public_bot_index-bundle.css
[modify] https://crrev.com/b252bedf9d7c1de778ce3d6a767787261c5ca082/appengine/swarming/ui2/dist/public_bot_index-bundle.js
[modify] https://crrev.com/b252bedf9d7c1de778ce3d6a767787261c5ca082/appengine/swarming/ui2/dist/public_bot_index.html
[modify] https://crrev.com/b252bedf9d7c1de778ce3d6a767787261c5ca082/appengine/swarming/ui2/dist/public_botlist_index-bundle.css
[modify] https://crrev.com/b252bedf9d7c1de778ce3d6a767787261c5ca082/appengine/swarming/ui2/dist/public_botlist_index-bundle.js
[modify] https://crrev.com/b252bedf9d7c1de778ce3d6a767787261c5ca082/appengine/swarming/ui2/dist/public_botlist_index.html
[modify] https://crrev.com/b252bedf9d7c1de778ce3d6a767787261c5ca082/appengine/swarming/ui2/dist/public_swarming_index-bundle.css
[modify] https://crrev.com/b252bedf9d7c1de778ce3d6a767787261c5ca082/appengine/swarming/ui2/dist/public_swarming_index-bundle.js
[modify] https://crrev.com/b252bedf9d7c1de778ce3d6a767787261c5ca082/appengine/swarming/ui2/dist/public_swarming_index.html
[modify] https://crrev.com/b252bedf9d7c1de778ce3d6a767787261c5ca082/appengine/swarming/ui2/dist/public_task_index-bundle.css
[modify] https://crrev.com/b252bedf9d7c1de778ce3d6a767787261c5ca082/appengine/swarming/ui2/dist/public_task_index-bundle.js
[modify] https://crrev.com/b252bedf9d7c1de778ce3d6a767787261c5ca082/appengine/swarming/ui2/dist/public_task_index.html
[modify] https://crrev.com/b252bedf9d7c1de778ce3d6a767787261c5ca082/appengine/swarming/ui2/dist/public_tasklist_index-bundle.css
[modify] https://crrev.com/b252bedf9d7c1de778ce3d6a767787261c5ca082/appengine/swarming/ui2/dist/public_tasklist_index-bundle.js
[modify] https://crrev.com/b252bedf9d7c1de778ce3d6a767787261c5ca082/appengine/swarming/ui2/dist/public_tasklist_index.html
[add] https://crrev.com/b252bedf9d7c1de778ce3d6a767787261c5ca082/appengine/swarming/ui2/jsdoc.config.js
[add] https://crrev.com/b252bedf9d7c1de778ce3d6a767787261c5ca082/appengine/swarming/ui2/modules/SwarmingAppBoilerplate.js
[modify] https://crrev.com/b252bedf9d7c1de778ce3d6a767787261c5ca082/appengine/swarming/ui2/modules/oauth-login/oauth-login.js
[modify] https://crrev.com/b252bedf9d7c1de778ce3d6a767787261c5ca082/appengine/swarming/ui2/modules/oauth-login/oauth-login_test.js
[modify] https://crrev.com/b252bedf9d7c1de778ce3d6a767787261c5ca082/appengine/swarming/ui2/modules/swarming-app/index.js
[modify] https://crrev.com/b252bedf9d7c1de778ce3d6a767787261c5ca082/appengine/swarming/ui2/modules/swarming-app/swarming-app.js
[modify] https://crrev.com/b252bedf9d7c1de778ce3d6a767787261c5ca082/appengine/swarming/ui2/modules/swarming-app/swarming-app_test.js
[modify] https://crrev.com/b252bedf9d7c1de778ce3d6a767787261c5ca082/appengine/swarming/ui2/modules/swarming-index/index.js
[modify] https://crrev.com/b252bedf9d7c1de778ce3d6a767787261c5ca082/appengine/swarming/ui2/modules/swarming-index/swarming-index.js
[modify] https://crrev.com/b252bedf9d7c1de778ce3d6a767787261c5ca082/appengine/swarming/ui2/modules/swarming-index/swarming-index_test.js
[add] https://crrev.com/b252bedf9d7c1de778ce3d6a767787261c5ca082/appengine/swarming/ui2/modules/util.js
[modify] https://crrev.com/b252bedf9d7c1de778ce3d6a767787261c5ca082/appengine/swarming/ui2/package-lock.json
[modify] https://crrev.com/b252bedf9d7c1de778ce3d6a767787261c5ca082/appengine/swarming/ui2/package.json

Project Member

Comment 8 by bugdroid1@chromium.org, Oct 2

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-py.git/+/82fd0616c6167d5aa6fff90c5faea4fd12edf869

commit 82fd0616c6167d5aa6fff90c5faea4fd12edf869
Author: Kevin Lubick <kjlubick@google.com>
Date: Tue Oct 02 20:20:47 2018

Update WebComponents deps

"Big" change to lit-html 0.11 and Karma 3.0.

This also refactors a few shared things into test_util and
SwarmingAppBoilerplate. These refactors were informed by
adding the bot-list element which will start arriving in a
follow-on CL.

Bug: 842181
Change-Id: Idf2bf217bddd80ac4c870efe9bc1a09c815b1c52
Reviewed-on: https://chromium-review.googlesource.com/c/1249447
Reviewed-by: Joe Gregorio <jcgregorio@chromium.org>

[modify] https://crrev.com/82fd0616c6167d5aa6fff90c5faea4fd12edf869/appengine/swarming/ui2/Makefile
[modify] https://crrev.com/82fd0616c6167d5aa6fff90c5faea4fd12edf869/appengine/swarming/ui2/dist/public_bot_index-bundle.css
[modify] https://crrev.com/82fd0616c6167d5aa6fff90c5faea4fd12edf869/appengine/swarming/ui2/dist/public_bot_index-bundle.js
[modify] https://crrev.com/82fd0616c6167d5aa6fff90c5faea4fd12edf869/appengine/swarming/ui2/dist/public_bot_index.html
[modify] https://crrev.com/82fd0616c6167d5aa6fff90c5faea4fd12edf869/appengine/swarming/ui2/dist/public_botlist_index-bundle.css
[modify] https://crrev.com/82fd0616c6167d5aa6fff90c5faea4fd12edf869/appengine/swarming/ui2/dist/public_botlist_index-bundle.js
[modify] https://crrev.com/82fd0616c6167d5aa6fff90c5faea4fd12edf869/appengine/swarming/ui2/dist/public_botlist_index.html
[modify] https://crrev.com/82fd0616c6167d5aa6fff90c5faea4fd12edf869/appengine/swarming/ui2/dist/public_swarming_index-bundle.css
[modify] https://crrev.com/82fd0616c6167d5aa6fff90c5faea4fd12edf869/appengine/swarming/ui2/dist/public_swarming_index-bundle.js
[modify] https://crrev.com/82fd0616c6167d5aa6fff90c5faea4fd12edf869/appengine/swarming/ui2/dist/public_swarming_index.html
[modify] https://crrev.com/82fd0616c6167d5aa6fff90c5faea4fd12edf869/appengine/swarming/ui2/dist/public_task_index-bundle.css
[modify] https://crrev.com/82fd0616c6167d5aa6fff90c5faea4fd12edf869/appengine/swarming/ui2/dist/public_task_index-bundle.js
[modify] https://crrev.com/82fd0616c6167d5aa6fff90c5faea4fd12edf869/appengine/swarming/ui2/dist/public_task_index.html
[modify] https://crrev.com/82fd0616c6167d5aa6fff90c5faea4fd12edf869/appengine/swarming/ui2/dist/public_tasklist_index-bundle.css
[modify] https://crrev.com/82fd0616c6167d5aa6fff90c5faea4fd12edf869/appengine/swarming/ui2/dist/public_tasklist_index-bundle.js
[modify] https://crrev.com/82fd0616c6167d5aa6fff90c5faea4fd12edf869/appengine/swarming/ui2/dist/public_tasklist_index.html
[modify] https://crrev.com/82fd0616c6167d5aa6fff90c5faea4fd12edf869/appengine/swarming/ui2/jsdoc.config.js
[modify] https://crrev.com/82fd0616c6167d5aa6fff90c5faea4fd12edf869/appengine/swarming/ui2/karma.conf.js
[modify] https://crrev.com/82fd0616c6167d5aa6fff90c5faea4fd12edf869/appengine/swarming/ui2/modules/SwarmingAppBoilerplate.js
[modify] https://crrev.com/82fd0616c6167d5aa6fff90c5faea4fd12edf869/appengine/swarming/ui2/modules/oauth-login/oauth-login.js
[modify] https://crrev.com/82fd0616c6167d5aa6fff90c5faea4fd12edf869/appengine/swarming/ui2/modules/swarming-app/swarming-app-demo.html
[modify] https://crrev.com/82fd0616c6167d5aa6fff90c5faea4fd12edf869/appengine/swarming/ui2/modules/swarming-app/swarming-app-demo.js
[modify] https://crrev.com/82fd0616c6167d5aa6fff90c5faea4fd12edf869/appengine/swarming/ui2/modules/swarming-app/swarming-app.js
[modify] https://crrev.com/82fd0616c6167d5aa6fff90c5faea4fd12edf869/appengine/swarming/ui2/modules/swarming-app/swarming-app.scss
[modify] https://crrev.com/82fd0616c6167d5aa6fff90c5faea4fd12edf869/appengine/swarming/ui2/modules/swarming-app/swarming-app_test.js
[modify] https://crrev.com/82fd0616c6167d5aa6fff90c5faea4fd12edf869/appengine/swarming/ui2/modules/swarming-index/swarming-index-demo.html
[modify] https://crrev.com/82fd0616c6167d5aa6fff90c5faea4fd12edf869/appengine/swarming/ui2/modules/swarming-index/swarming-index-demo.js
[modify] https://crrev.com/82fd0616c6167d5aa6fff90c5faea4fd12edf869/appengine/swarming/ui2/modules/swarming-index/swarming-index.js
[modify] https://crrev.com/82fd0616c6167d5aa6fff90c5faea4fd12edf869/appengine/swarming/ui2/modules/swarming-index/swarming-index_test.js
[add] https://crrev.com/82fd0616c6167d5aa6fff90c5faea4fd12edf869/appengine/swarming/ui2/modules/test_util.js
[modify] https://crrev.com/82fd0616c6167d5aa6fff90c5faea4fd12edf869/appengine/swarming/ui2/modules/util.js
[modify] https://crrev.com/82fd0616c6167d5aa6fff90c5faea4fd12edf869/appengine/swarming/ui2/package-lock.json
[modify] https://crrev.com/82fd0616c6167d5aa6fff90c5faea4fd12edf869/appengine/swarming/ui2/package.json
[modify] https://crrev.com/82fd0616c6167d5aa6fff90c5faea4fd12edf869/appengine/swarming/ui2/webpack.config.js

Project Member

Comment 10 by bugdroid1@chromium.org, Oct 3

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-py.git/+/e2a2a2ec74975f888e2046196820ab597582bb10

commit e2a2a2ec74975f888e2046196820ab597582bb10
Author: Kevin Lubick <kjlubick@google.com>
Date: Wed Oct 03 11:30:33 2018

Adds the first pieces of the swarming bot-list using WebComponents.

I'm trying out keeping HTML-related logic and anything involving
'this' in the bot-list.js and any pure JS logic in bot-list helpers.
I think it does a good job of decluttering bot-list.js and makes
it easier to write unit tests.

It sorts and dynamically can add/remove filters and columns.
It makes all sorts of ajax requests using fetch.
It makes use of query params.

It has > 30 tests just for the bot-list.

There are many more TODOs to get all the current functionality, but
those will arrive in a later CL.

Bug: 842181
Change-Id: I1e0156a0de1ad53a2306b3d4399e8a980a089b14
Reviewed-on: https://chromium-review.googlesource.com/c/1251662
Commit-Queue: Kevin Lubick <kjlubick@chromium.org>
Reviewed-by: Joe Gregorio <jcgregorio@chromium.org>

[modify] https://crrev.com/e2a2a2ec74975f888e2046196820ab597582bb10/appengine/swarming/ui2/dist/public_bot_index-bundle.js
[modify] https://crrev.com/e2a2a2ec74975f888e2046196820ab597582bb10/appengine/swarming/ui2/dist/public_bot_index.html
[modify] https://crrev.com/e2a2a2ec74975f888e2046196820ab597582bb10/appengine/swarming/ui2/dist/public_botlist_index-bundle.css
[modify] https://crrev.com/e2a2a2ec74975f888e2046196820ab597582bb10/appengine/swarming/ui2/dist/public_botlist_index-bundle.js
[modify] https://crrev.com/e2a2a2ec74975f888e2046196820ab597582bb10/appengine/swarming/ui2/dist/public_botlist_index.html
[modify] https://crrev.com/e2a2a2ec74975f888e2046196820ab597582bb10/appengine/swarming/ui2/dist/public_swarming_index-bundle.css
[modify] https://crrev.com/e2a2a2ec74975f888e2046196820ab597582bb10/appengine/swarming/ui2/dist/public_swarming_index-bundle.js
[modify] https://crrev.com/e2a2a2ec74975f888e2046196820ab597582bb10/appengine/swarming/ui2/dist/public_swarming_index.html
[modify] https://crrev.com/e2a2a2ec74975f888e2046196820ab597582bb10/appengine/swarming/ui2/dist/public_task_index-bundle.js
[modify] https://crrev.com/e2a2a2ec74975f888e2046196820ab597582bb10/appengine/swarming/ui2/dist/public_task_index.html
[modify] https://crrev.com/e2a2a2ec74975f888e2046196820ab597582bb10/appengine/swarming/ui2/dist/public_tasklist_index-bundle.js
[modify] https://crrev.com/e2a2a2ec74975f888e2046196820ab597582bb10/appengine/swarming/ui2/dist/public_tasklist_index.html
[modify] https://crrev.com/e2a2a2ec74975f888e2046196820ab597582bb10/appengine/swarming/ui2/modules/SwarmingAppBoilerplate.js
[add] https://crrev.com/e2a2a2ec74975f888e2046196820ab597582bb10/appengine/swarming/ui2/modules/bot-list/bot-list-demo.html
[add] https://crrev.com/e2a2a2ec74975f888e2046196820ab597582bb10/appengine/swarming/ui2/modules/bot-list/bot-list-demo.js
[add] https://crrev.com/e2a2a2ec74975f888e2046196820ab597582bb10/appengine/swarming/ui2/modules/bot-list/bot-list-helpers.js
[add] https://crrev.com/e2a2a2ec74975f888e2046196820ab597582bb10/appengine/swarming/ui2/modules/bot-list/bot-list.js
[add] https://crrev.com/e2a2a2ec74975f888e2046196820ab597582bb10/appengine/swarming/ui2/modules/bot-list/bot-list.scss
[add] https://crrev.com/e2a2a2ec74975f888e2046196820ab597582bb10/appengine/swarming/ui2/modules/bot-list/bot-list_test.js
[add] https://crrev.com/e2a2a2ec74975f888e2046196820ab597582bb10/appengine/swarming/ui2/modules/bot-list/index.js
[add] https://crrev.com/e2a2a2ec74975f888e2046196820ab597582bb10/appengine/swarming/ui2/modules/bot-list/test_data.js
[modify] https://crrev.com/e2a2a2ec74975f888e2046196820ab597582bb10/appengine/swarming/ui2/modules/oauth-login/oauth-login.js
[modify] https://crrev.com/e2a2a2ec74975f888e2046196820ab597582bb10/appengine/swarming/ui2/modules/swarming-app/swarming-app-demo.js
[modify] https://crrev.com/e2a2a2ec74975f888e2046196820ab597582bb10/appengine/swarming/ui2/modules/swarming-app/swarming-app.js
[modify] https://crrev.com/e2a2a2ec74975f888e2046196820ab597582bb10/appengine/swarming/ui2/modules/swarming-index/swarming-index.js
[modify] https://crrev.com/e2a2a2ec74975f888e2046196820ab597582bb10/appengine/swarming/ui2/package-lock.json
[modify] https://crrev.com/e2a2a2ec74975f888e2046196820ab597582bb10/appengine/swarming/ui2/package.json
[modify] https://crrev.com/e2a2a2ec74975f888e2046196820ab597582bb10/appengine/swarming/ui2/pages/public_botlist_index.html
[modify] https://crrev.com/e2a2a2ec74975f888e2046196820ab597582bb10/appengine/swarming/ui2/pages/public_botlist_index.js

Project Member

Comment 11 by bugdroid1@chromium.org, Oct 29

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-py.git/+/2a9d6a72302de17f6e669d948baf418e25ddcd23

commit 2a9d6a72302de17f6e669d948baf418e25ddcd23
Author: Kevin Lubick <kjlubick@google.com>
Date: Mon Oct 29 14:21:37 2018

Add aliasing to new botlist

This is a somewhat simpler implementation than the Polymer one.

Fixes a few bugs in displaying versions.

Removes custom stableSort since Chrome 70 is now stable.

This should be that last "big" ui feature needed before
turning it on.

Bug: 842181
Change-Id: I2bd382e5594bfc0469167d17d22e4b727bd687b0
Reviewed-on: https://chromium-review.googlesource.com/c/1303994
Reviewed-by: Joe Gregorio <jcgregorio@chromium.org>
Commit-Queue: Kevin Lubick <kjlubick@chromium.org>

[modify] https://crrev.com/2a9d6a72302de17f6e669d948baf418e25ddcd23/appengine/swarming/ui/build/elements.html
[modify] https://crrev.com/2a9d6a72302de17f6e669d948baf418e25ddcd23/appengine/swarming/ui/build/js/js.js
[modify] https://crrev.com/2a9d6a72302de17f6e669d948baf418e25ddcd23/appengine/swarming/ui/res/js/alias.js
[modify] https://crrev.com/2a9d6a72302de17f6e669d948baf418e25ddcd23/appengine/swarming/ui2/dist/public_bot_index.html
[modify] https://crrev.com/2a9d6a72302de17f6e669d948baf418e25ddcd23/appengine/swarming/ui2/dist/public_botlist_index-bundle.css
[modify] https://crrev.com/2a9d6a72302de17f6e669d948baf418e25ddcd23/appengine/swarming/ui2/dist/public_botlist_index-bundle.js
[modify] https://crrev.com/2a9d6a72302de17f6e669d948baf418e25ddcd23/appengine/swarming/ui2/dist/public_botlist_index.html
[modify] https://crrev.com/2a9d6a72302de17f6e669d948baf418e25ddcd23/appengine/swarming/ui2/dist/public_swarming_index.html
[modify] https://crrev.com/2a9d6a72302de17f6e669d948baf418e25ddcd23/appengine/swarming/ui2/dist/public_task_index.html
[modify] https://crrev.com/2a9d6a72302de17f6e669d948baf418e25ddcd23/appengine/swarming/ui2/dist/public_tasklist_index.html
[add] https://crrev.com/2a9d6a72302de17f6e669d948baf418e25ddcd23/appengine/swarming/ui2/modules/alias.js
[modify] https://crrev.com/2a9d6a72302de17f6e669d948baf418e25ddcd23/appengine/swarming/ui2/modules/bot-list/bot-list-helpers.js
[modify] https://crrev.com/2a9d6a72302de17f6e669d948baf418e25ddcd23/appengine/swarming/ui2/modules/bot-list/bot-list.js
[modify] https://crrev.com/2a9d6a72302de17f6e669d948baf418e25ddcd23/appengine/swarming/ui2/modules/bot-list/bot-list_test.js
[modify] https://crrev.com/2a9d6a72302de17f6e669d948baf418e25ddcd23/appengine/swarming/ui2/modules/bot-list/test_data.js
[modify] https://crrev.com/2a9d6a72302de17f6e669d948baf418e25ddcd23/appengine/swarming/ui2/modules/test_util.js
[modify] https://crrev.com/2a9d6a72302de17f6e669d948baf418e25ddcd23/appengine/swarming/ui2/modules/util.js

Project Member

Comment 12 by bugdroid1@chromium.org, Nov 6

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-py.git/+/2f897295fec698305949c6c032b51f548eeda067

commit 2f897295fec698305949c6c032b51f548eeda067
Author: Kevin Lubick <kjlubick@google.com>
Date: Tue Nov 06 20:56:14 2018

Make ui2 the default for some pages

Bug: 842181
Change-Id: I5886503b487230ceb73716b8c0dc2e5cce93aa17
Reviewed-on: https://chromium-review.googlesource.com/c/1319789
Commit-Queue: Kevin Lubick <kjlubick@chromium.org>
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>

[modify] https://crrev.com/2f897295fec698305949c6c032b51f548eeda067/appengine/swarming/handlers_frontend.py
[modify] https://crrev.com/2f897295fec698305949c6c032b51f548eeda067/appengine/swarming/ui/build/elements.html
[modify] https://crrev.com/2f897295fec698305949c6c032b51f548eeda067/appengine/swarming/ui/res/imp/botlist/bot-filters.html
[modify] https://crrev.com/2f897295fec698305949c6c032b51f548eeda067/appengine/swarming/ui2/dist/public_bot_index.html
[modify] https://crrev.com/2f897295fec698305949c6c032b51f548eeda067/appengine/swarming/ui2/dist/public_botlist_index-bundle.css
[modify] https://crrev.com/2f897295fec698305949c6c032b51f548eeda067/appengine/swarming/ui2/dist/public_botlist_index-bundle.js
[modify] https://crrev.com/2f897295fec698305949c6c032b51f548eeda067/appengine/swarming/ui2/dist/public_botlist_index.html
[modify] https://crrev.com/2f897295fec698305949c6c032b51f548eeda067/appengine/swarming/ui2/dist/public_swarming_index.html
[modify] https://crrev.com/2f897295fec698305949c6c032b51f548eeda067/appengine/swarming/ui2/dist/public_task_index.html
[modify] https://crrev.com/2f897295fec698305949c6c032b51f548eeda067/appengine/swarming/ui2/dist/public_tasklist_index.html
[modify] https://crrev.com/2f897295fec698305949c6c032b51f548eeda067/appengine/swarming/ui2/modules/bot-list/bot-list-helpers.js
[modify] https://crrev.com/2f897295fec698305949c6c032b51f548eeda067/appengine/swarming/ui2/modules/bot-list/bot-list.js
[modify] https://crrev.com/2f897295fec698305949c6c032b51f548eeda067/appengine/swarming/ui2/modules/bot-list/bot-list.scss
[modify] https://crrev.com/2f897295fec698305949c6c032b51f548eeda067/appengine/swarming/ui2/modules/bot-list/bot-list_test.js

Project Member

Comment 13 by bugdroid1@chromium.org, Jan 4

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-py.git/+/9cab919e1a135adbf5104bee6bc8f34c84974362

commit 9cab919e1a135adbf5104bee6bc8f34c84974362
Author: Kevin Lubick <kjlubick@google.com>
Date: Fri Jan 04 13:07:58 2019

[swarming-ui] Refactors and clean-ups of bot-list

prepares to lay the foundation of task-list

Makes a button properly hide on new bot-list when not logged in.

Deletes bit-rotted tests involving query params. I think the
issue had been caused in Chrome by pushing the state every render
and so Chrome would stop updating it (and even log a message in
the console).  Maybe now that we don't update the query params in
render, we could one day test that?

Bug: 842181
Change-Id: Ifb420fed5a011c8d167d90dcf8bb73e4c4382114
Reviewed-on: https://chromium-review.googlesource.com/c/1392324
Reviewed-by: Joe Gregorio <jcgregorio@chromium.org>
Commit-Queue: Kevin Lubick <kjlubick@chromium.org>

[modify] https://crrev.com/9cab919e1a135adbf5104bee6bc8f34c84974362/appengine/swarming/ui/res/imp/common/common-behavior.html
[modify] https://crrev.com/9cab919e1a135adbf5104bee6bc8f34c84974362/appengine/swarming/ui/res/imp/tasklist/task-list.html
[modify] https://crrev.com/9cab919e1a135adbf5104bee6bc8f34c84974362/appengine/swarming/ui2/dist/public_bot_index-bundle.css
[modify] https://crrev.com/9cab919e1a135adbf5104bee6bc8f34c84974362/appengine/swarming/ui2/dist/public_bot_index.html
[modify] https://crrev.com/9cab919e1a135adbf5104bee6bc8f34c84974362/appengine/swarming/ui2/dist/public_botlist_index-bundle.css
[modify] https://crrev.com/9cab919e1a135adbf5104bee6bc8f34c84974362/appengine/swarming/ui2/dist/public_botlist_index-bundle.js
[modify] https://crrev.com/9cab919e1a135adbf5104bee6bc8f34c84974362/appengine/swarming/ui2/dist/public_botlist_index.html
[modify] https://crrev.com/9cab919e1a135adbf5104bee6bc8f34c84974362/appengine/swarming/ui2/dist/public_swarming_index-bundle.css
[modify] https://crrev.com/9cab919e1a135adbf5104bee6bc8f34c84974362/appengine/swarming/ui2/dist/public_swarming_index.html
[modify] https://crrev.com/9cab919e1a135adbf5104bee6bc8f34c84974362/appengine/swarming/ui2/dist/public_task_index-bundle.css
[modify] https://crrev.com/9cab919e1a135adbf5104bee6bc8f34c84974362/appengine/swarming/ui2/dist/public_task_index.html
[modify] https://crrev.com/9cab919e1a135adbf5104bee6bc8f34c84974362/appengine/swarming/ui2/dist/public_tasklist_index-bundle.css
[modify] https://crrev.com/9cab919e1a135adbf5104bee6bc8f34c84974362/appengine/swarming/ui2/dist/public_tasklist_index.html
[modify] https://crrev.com/9cab919e1a135adbf5104bee6bc8f34c84974362/appengine/swarming/ui2/modules/bot-list/bot-list-demo.html
[modify] https://crrev.com/9cab919e1a135adbf5104bee6bc8f34c84974362/appengine/swarming/ui2/modules/bot-list/bot-list-helpers.js
[modify] https://crrev.com/9cab919e1a135adbf5104bee6bc8f34c84974362/appengine/swarming/ui2/modules/bot-list/bot-list.js
[modify] https://crrev.com/9cab919e1a135adbf5104bee6bc8f34c84974362/appengine/swarming/ui2/modules/bot-list/bot-list_test.js
[modify] https://crrev.com/9cab919e1a135adbf5104bee6bc8f34c84974362/appengine/swarming/ui2/modules/util.js

Project Member

Comment 14 by bugdroid1@chromium.org, Jan 4

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-py.git/+/8b59ccbfbbfc3579090728ab02fad725848310e9

commit 8b59ccbfbbfc3579090728ab02fad725848310e9
Author: Kevin Lubick <kjlubick@google.com>
Date: Fri Jan 04 13:26:28 2019

[swarming-ui] First shake at task-list

Note to the reviewer: Patchset 1 is mostly boilerplate. I'd recommend
browsing that PS, then use that as the baseline of comparisons
for further changes.

Bug: 842181

Change-Id: If67b5d14a01a4cbc34beb1dd75bb035522732549
Reviewed-on: https://chromium-review.googlesource.com/c/1384427
Commit-Queue: Kevin Lubick <kjlubick@chromium.org>
Reviewed-by: Joe Gregorio <jcgregorio@chromium.org>

[modify] https://crrev.com/8b59ccbfbbfc3579090728ab02fad725848310e9/appengine/swarming/ui2/dist/public_bot_index-bundle.css
[modify] https://crrev.com/8b59ccbfbbfc3579090728ab02fad725848310e9/appengine/swarming/ui2/dist/public_bot_index-bundle.js
[modify] https://crrev.com/8b59ccbfbbfc3579090728ab02fad725848310e9/appengine/swarming/ui2/dist/public_bot_index.html
[modify] https://crrev.com/8b59ccbfbbfc3579090728ab02fad725848310e9/appengine/swarming/ui2/dist/public_botlist_index-bundle.css
[modify] https://crrev.com/8b59ccbfbbfc3579090728ab02fad725848310e9/appengine/swarming/ui2/dist/public_botlist_index-bundle.js
[modify] https://crrev.com/8b59ccbfbbfc3579090728ab02fad725848310e9/appengine/swarming/ui2/dist/public_botlist_index.html
[modify] https://crrev.com/8b59ccbfbbfc3579090728ab02fad725848310e9/appengine/swarming/ui2/dist/public_swarming_index-bundle.css
[modify] https://crrev.com/8b59ccbfbbfc3579090728ab02fad725848310e9/appengine/swarming/ui2/dist/public_swarming_index-bundle.js
[modify] https://crrev.com/8b59ccbfbbfc3579090728ab02fad725848310e9/appengine/swarming/ui2/dist/public_swarming_index.html
[modify] https://crrev.com/8b59ccbfbbfc3579090728ab02fad725848310e9/appengine/swarming/ui2/dist/public_task_index-bundle.css
[modify] https://crrev.com/8b59ccbfbbfc3579090728ab02fad725848310e9/appengine/swarming/ui2/dist/public_task_index-bundle.js
[modify] https://crrev.com/8b59ccbfbbfc3579090728ab02fad725848310e9/appengine/swarming/ui2/dist/public_task_index.html
[modify] https://crrev.com/8b59ccbfbbfc3579090728ab02fad725848310e9/appengine/swarming/ui2/dist/public_tasklist_index-bundle.css
[modify] https://crrev.com/8b59ccbfbbfc3579090728ab02fad725848310e9/appengine/swarming/ui2/dist/public_tasklist_index-bundle.js
[modify] https://crrev.com/8b59ccbfbbfc3579090728ab02fad725848310e9/appengine/swarming/ui2/dist/public_tasklist_index.html
[modify] https://crrev.com/8b59ccbfbbfc3579090728ab02fad725848310e9/appengine/swarming/ui2/modules/SwarmingAppBoilerplate.js
[modify] https://crrev.com/8b59ccbfbbfc3579090728ab02fad725848310e9/appengine/swarming/ui2/modules/bot-list/bot-list-helpers.js
[modify] https://crrev.com/8b59ccbfbbfc3579090728ab02fad725848310e9/appengine/swarming/ui2/modules/bot-list/bot-list.js
[add] https://crrev.com/8b59ccbfbbfc3579090728ab02fad725848310e9/appengine/swarming/ui2/modules/task-list/index.js
[add] https://crrev.com/8b59ccbfbbfc3579090728ab02fad725848310e9/appengine/swarming/ui2/modules/task-list/task-list-demo.html
[add] https://crrev.com/8b59ccbfbbfc3579090728ab02fad725848310e9/appengine/swarming/ui2/modules/task-list/task-list-demo.js
[add] https://crrev.com/8b59ccbfbbfc3579090728ab02fad725848310e9/appengine/swarming/ui2/modules/task-list/task-list-helpers.js
[add] https://crrev.com/8b59ccbfbbfc3579090728ab02fad725848310e9/appengine/swarming/ui2/modules/task-list/task-list.js
[add] https://crrev.com/8b59ccbfbbfc3579090728ab02fad725848310e9/appengine/swarming/ui2/modules/task-list/task-list.scss
[add] https://crrev.com/8b59ccbfbbfc3579090728ab02fad725848310e9/appengine/swarming/ui2/modules/task-list/task-list_test.js
[add] https://crrev.com/8b59ccbfbbfc3579090728ab02fad725848310e9/appengine/swarming/ui2/modules/task-list/test_data.js
[modify] https://crrev.com/8b59ccbfbbfc3579090728ab02fad725848310e9/appengine/swarming/ui2/pages/public_tasklist_index.html
[modify] https://crrev.com/8b59ccbfbbfc3579090728ab02fad725848310e9/appengine/swarming/ui2/pages/public_tasklist_index.js

Project Member

Comment 15 by bugdroid1@chromium.org, Jan 9

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-py.git/+/a469af3fc8f8e9f45aa5dfa187e4c31278619139

commit a469af3fc8f8e9f45aa5dfa187e4c31278619139
Author: Kevin Lubick <kjlubick@google.com>
Date: Wed Jan 09 21:05:20 2019

[swarming-ui] Cleanups of tests and refactoring of bot-list

There are some new tests to bot-list that directly test
the filtering (while fetch is waiting).

Additionally, instead of defaulting to 'none' if we don't
have a given bot attribute, I changed to '--', which looks nicer
(especially on task-list)

queryfilter.js houses some of the code that can be easily shared
between bot-list and task-list.

Bug: 842181

Change-Id: I13be1baeddf2d52bc8127255bf5ec3baa008771e
Reviewed-on: https://chromium-review.googlesource.com/c/1403435
Reviewed-by: Joe Gregorio <jcgregorio@chromium.org>

[modify] https://crrev.com/a469af3fc8f8e9f45aa5dfa187e4c31278619139/appengine/swarming/ui2/dist/public_bot_index-bundle.css
[modify] https://crrev.com/a469af3fc8f8e9f45aa5dfa187e4c31278619139/appengine/swarming/ui2/dist/public_bot_index.html
[modify] https://crrev.com/a469af3fc8f8e9f45aa5dfa187e4c31278619139/appengine/swarming/ui2/dist/public_botlist_index-bundle.css
[modify] https://crrev.com/a469af3fc8f8e9f45aa5dfa187e4c31278619139/appengine/swarming/ui2/dist/public_botlist_index-bundle.js
[modify] https://crrev.com/a469af3fc8f8e9f45aa5dfa187e4c31278619139/appengine/swarming/ui2/dist/public_botlist_index.html
[modify] https://crrev.com/a469af3fc8f8e9f45aa5dfa187e4c31278619139/appengine/swarming/ui2/dist/public_swarming_index-bundle.css
[modify] https://crrev.com/a469af3fc8f8e9f45aa5dfa187e4c31278619139/appengine/swarming/ui2/dist/public_swarming_index.html
[modify] https://crrev.com/a469af3fc8f8e9f45aa5dfa187e4c31278619139/appengine/swarming/ui2/dist/public_task_index-bundle.css
[modify] https://crrev.com/a469af3fc8f8e9f45aa5dfa187e4c31278619139/appengine/swarming/ui2/dist/public_task_index.html
[modify] https://crrev.com/a469af3fc8f8e9f45aa5dfa187e4c31278619139/appengine/swarming/ui2/dist/public_tasklist_index-bundle.css
[modify] https://crrev.com/a469af3fc8f8e9f45aa5dfa187e4c31278619139/appengine/swarming/ui2/dist/public_tasklist_index.html
[modify] https://crrev.com/a469af3fc8f8e9f45aa5dfa187e4c31278619139/appengine/swarming/ui2/modules/bot-list/bot-list-demo.js
[modify] https://crrev.com/a469af3fc8f8e9f45aa5dfa187e4c31278619139/appengine/swarming/ui2/modules/bot-list/bot-list-helpers.js
[modify] https://crrev.com/a469af3fc8f8e9f45aa5dfa187e4c31278619139/appengine/swarming/ui2/modules/bot-list/bot-list.js
[modify] https://crrev.com/a469af3fc8f8e9f45aa5dfa187e4c31278619139/appengine/swarming/ui2/modules/bot-list/bot-list_test.js
[modify] https://crrev.com/a469af3fc8f8e9f45aa5dfa187e4c31278619139/appengine/swarming/ui2/modules/bot-list/test_data.js
[add] https://crrev.com/a469af3fc8f8e9f45aa5dfa187e4c31278619139/appengine/swarming/ui2/modules/queryfilter.js
[modify] https://crrev.com/a469af3fc8f8e9f45aa5dfa187e4c31278619139/appengine/swarming/ui2/modules/swarming-app/swarming-app_test.js
[modify] https://crrev.com/a469af3fc8f8e9f45aa5dfa187e4c31278619139/appengine/swarming/ui2/modules/swarming-index/swarming-index_test.js
[modify] https://crrev.com/a469af3fc8f8e9f45aa5dfa187e4c31278619139/appengine/swarming/ui2/modules/task-list/task-list_test.js
[modify] https://crrev.com/a469af3fc8f8e9f45aa5dfa187e4c31278619139/appengine/swarming/ui2/modules/test_util.js

Summary: Update swarming UI out of polymer to web components (was: Update swarming UI to polymer 2 (or some other alternative))
Project Member

Comment 17 by bugdroid1@chromium.org, Jan 14

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-py.git/+/af0c393b82d41de61bb15a08614567e932c25930

commit af0c393b82d41de61bb15a08614567e932c25930
Author: Kevin Lubick <kjlubick@google.com>
Date: Mon Jan 14 20:37:44 2019

[swarming-ui] Build task-list UI from bot-list

This creates a large chunk of the task-list UI by more or less
copying-pasting the bot-list parts and adapting them for the new
variable names and data structure.

I figured it would be best to do this all at once, since it's mostly
the same, and then work on the the task-list specific things like
datepicking, task counts, and the rest of the API calls in future
CLs.

Bug: 842181
Change-Id: Ib5ec6067a5905f4deb324c7f0eb0901c699ad106
Reviewed-on: https://chromium-review.googlesource.com/c/1404014
Reviewed-by: Joe Gregorio <jcgregorio@chromium.org>
Commit-Queue: Kevin Lubick <kjlubick@chromium.org>

[modify] https://crrev.com/af0c393b82d41de61bb15a08614567e932c25930/appengine/swarming/ui2/dist/custom-elements.min.js
[modify] https://crrev.com/af0c393b82d41de61bb15a08614567e932c25930/appengine/swarming/ui2/dist/public_bot_index-bundle.js
[modify] https://crrev.com/af0c393b82d41de61bb15a08614567e932c25930/appengine/swarming/ui2/dist/public_bot_index.html
[modify] https://crrev.com/af0c393b82d41de61bb15a08614567e932c25930/appengine/swarming/ui2/dist/public_botlist_index-bundle.css
[modify] https://crrev.com/af0c393b82d41de61bb15a08614567e932c25930/appengine/swarming/ui2/dist/public_botlist_index-bundle.js
[modify] https://crrev.com/af0c393b82d41de61bb15a08614567e932c25930/appengine/swarming/ui2/dist/public_botlist_index.html
[modify] https://crrev.com/af0c393b82d41de61bb15a08614567e932c25930/appengine/swarming/ui2/dist/public_swarming_index-bundle.js
[modify] https://crrev.com/af0c393b82d41de61bb15a08614567e932c25930/appengine/swarming/ui2/dist/public_swarming_index.html
[modify] https://crrev.com/af0c393b82d41de61bb15a08614567e932c25930/appengine/swarming/ui2/dist/public_task_index-bundle.js
[modify] https://crrev.com/af0c393b82d41de61bb15a08614567e932c25930/appengine/swarming/ui2/dist/public_task_index.html
[modify] https://crrev.com/af0c393b82d41de61bb15a08614567e932c25930/appengine/swarming/ui2/dist/public_tasklist_index-bundle.css
[modify] https://crrev.com/af0c393b82d41de61bb15a08614567e932c25930/appengine/swarming/ui2/dist/public_tasklist_index-bundle.js
[modify] https://crrev.com/af0c393b82d41de61bb15a08614567e932c25930/appengine/swarming/ui2/dist/public_tasklist_index.html
[modify] https://crrev.com/af0c393b82d41de61bb15a08614567e932c25930/appengine/swarming/ui2/modules/bot-list/bot-list-helpers.js
[modify] https://crrev.com/af0c393b82d41de61bb15a08614567e932c25930/appengine/swarming/ui2/modules/bot-list/bot-list.js
[modify] https://crrev.com/af0c393b82d41de61bb15a08614567e932c25930/appengine/swarming/ui2/modules/bot-list/bot-list_test.js
[modify] https://crrev.com/af0c393b82d41de61bb15a08614567e932c25930/appengine/swarming/ui2/modules/task-list/task-list-demo.js
[modify] https://crrev.com/af0c393b82d41de61bb15a08614567e932c25930/appengine/swarming/ui2/modules/task-list/task-list-helpers.js
[modify] https://crrev.com/af0c393b82d41de61bb15a08614567e932c25930/appengine/swarming/ui2/modules/task-list/task-list.js
[modify] https://crrev.com/af0c393b82d41de61bb15a08614567e932c25930/appengine/swarming/ui2/modules/task-list/task-list.scss
[modify] https://crrev.com/af0c393b82d41de61bb15a08614567e932c25930/appengine/swarming/ui2/modules/task-list/task-list_test.js
[modify] https://crrev.com/af0c393b82d41de61bb15a08614567e932c25930/appengine/swarming/ui2/modules/task-list/test_data.js
[modify] https://crrev.com/af0c393b82d41de61bb15a08614567e932c25930/appengine/swarming/ui2/modules/test_util.js

Project Member

Comment 18 by bugdroid1@chromium.org, Jan 14

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-py.git/+/2e4c71fdcc373a284e3a0044be9d52a37cd69618

commit 2e4c71fdcc373a284e3a0044be9d52a37cd69618
Author: Kevin Lubick <kjlubick@google.com>
Date: Mon Jan 14 20:49:10 2019

[swarming-ui] Correctly filter, add time pickers

required https://github.com/google/pulito/pull/4
for robust fix in css minification.

Bug: 842181

Change-Id: I8c98ed4066c04899b6f8eadae24bf72c572db736
Reviewed-on: https://chromium-review.googlesource.com/c/1406048
Commit-Queue: Kevin Lubick <kjlubick@chromium.org>
Reviewed-by: Joe Gregorio <jcgregorio@chromium.org>

[modify] https://crrev.com/2e4c71fdcc373a284e3a0044be9d52a37cd69618/appengine/swarming/ui2/dist/public_bot_index-bundle.css
[modify] https://crrev.com/2e4c71fdcc373a284e3a0044be9d52a37cd69618/appengine/swarming/ui2/dist/public_bot_index-bundle.js
[modify] https://crrev.com/2e4c71fdcc373a284e3a0044be9d52a37cd69618/appengine/swarming/ui2/dist/public_bot_index.html
[modify] https://crrev.com/2e4c71fdcc373a284e3a0044be9d52a37cd69618/appengine/swarming/ui2/dist/public_botlist_index-bundle.css
[modify] https://crrev.com/2e4c71fdcc373a284e3a0044be9d52a37cd69618/appengine/swarming/ui2/dist/public_botlist_index-bundle.js
[modify] https://crrev.com/2e4c71fdcc373a284e3a0044be9d52a37cd69618/appengine/swarming/ui2/dist/public_botlist_index.html
[modify] https://crrev.com/2e4c71fdcc373a284e3a0044be9d52a37cd69618/appengine/swarming/ui2/dist/public_swarming_index-bundle.css
[modify] https://crrev.com/2e4c71fdcc373a284e3a0044be9d52a37cd69618/appengine/swarming/ui2/dist/public_swarming_index-bundle.js
[modify] https://crrev.com/2e4c71fdcc373a284e3a0044be9d52a37cd69618/appengine/swarming/ui2/dist/public_swarming_index.html
[modify] https://crrev.com/2e4c71fdcc373a284e3a0044be9d52a37cd69618/appengine/swarming/ui2/dist/public_task_index-bundle.css
[modify] https://crrev.com/2e4c71fdcc373a284e3a0044be9d52a37cd69618/appengine/swarming/ui2/dist/public_task_index-bundle.js
[modify] https://crrev.com/2e4c71fdcc373a284e3a0044be9d52a37cd69618/appengine/swarming/ui2/dist/public_task_index.html
[modify] https://crrev.com/2e4c71fdcc373a284e3a0044be9d52a37cd69618/appengine/swarming/ui2/dist/public_tasklist_index-bundle.css
[modify] https://crrev.com/2e4c71fdcc373a284e3a0044be9d52a37cd69618/appengine/swarming/ui2/dist/public_tasklist_index-bundle.js
[modify] https://crrev.com/2e4c71fdcc373a284e3a0044be9d52a37cd69618/appengine/swarming/ui2/dist/public_tasklist_index.html
[modify] https://crrev.com/2e4c71fdcc373a284e3a0044be9d52a37cd69618/appengine/swarming/ui2/modules/bot-list/bot-list-helpers.js
[modify] https://crrev.com/2e4c71fdcc373a284e3a0044be9d52a37cd69618/appengine/swarming/ui2/modules/bot-list/bot-list.js
[modify] https://crrev.com/2e4c71fdcc373a284e3a0044be9d52a37cd69618/appengine/swarming/ui2/modules/task-list/task-list-helpers.js
[modify] https://crrev.com/2e4c71fdcc373a284e3a0044be9d52a37cd69618/appengine/swarming/ui2/modules/task-list/task-list.js
[modify] https://crrev.com/2e4c71fdcc373a284e3a0044be9d52a37cd69618/appengine/swarming/ui2/modules/task-list/task-list.scss
[modify] https://crrev.com/2e4c71fdcc373a284e3a0044be9d52a37cd69618/appengine/swarming/ui2/modules/task-list/task-list_test.js
[modify] https://crrev.com/2e4c71fdcc373a284e3a0044be9d52a37cd69618/appengine/swarming/ui2/package-lock.json
[modify] https://crrev.com/2e4c71fdcc373a284e3a0044be9d52a37cd69618/appengine/swarming/ui2/package.json

Project Member

Comment 19 by bugdroid1@chromium.org, Jan 14

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-py.git/+/61c340a1d691fbd8d32436b7634b8b166e6a779e

commit 61c340a1d691fbd8d32436b7634b8b166e6a779e
Author: Kevin Lubick <kjlubick@google.com>
Date: Mon Jan 14 21:04:20 2019

[swarming-ui] Add counts to task-list

Bug: 842181
Change-Id: I8f920f728c7ed348f4baa134e70056e41d3acbf0
Reviewed-on: https://chromium-review.googlesource.com/c/1409924
Commit-Queue: Kevin Lubick <kjlubick@chromium.org>
Reviewed-by: Joe Gregorio <jcgregorio@chromium.org>

[modify] https://crrev.com/61c340a1d691fbd8d32436b7634b8b166e6a779e/appengine/swarming/ui2/dist/public_bot_index-bundle.css
[modify] https://crrev.com/61c340a1d691fbd8d32436b7634b8b166e6a779e/appengine/swarming/ui2/dist/public_bot_index-bundle.js
[modify] https://crrev.com/61c340a1d691fbd8d32436b7634b8b166e6a779e/appengine/swarming/ui2/dist/public_bot_index.html
[modify] https://crrev.com/61c340a1d691fbd8d32436b7634b8b166e6a779e/appengine/swarming/ui2/dist/public_botlist_index-bundle.css
[modify] https://crrev.com/61c340a1d691fbd8d32436b7634b8b166e6a779e/appengine/swarming/ui2/dist/public_botlist_index-bundle.js
[modify] https://crrev.com/61c340a1d691fbd8d32436b7634b8b166e6a779e/appengine/swarming/ui2/dist/public_botlist_index.html
[modify] https://crrev.com/61c340a1d691fbd8d32436b7634b8b166e6a779e/appengine/swarming/ui2/dist/public_swarming_index-bundle.css
[modify] https://crrev.com/61c340a1d691fbd8d32436b7634b8b166e6a779e/appengine/swarming/ui2/dist/public_swarming_index-bundle.js
[modify] https://crrev.com/61c340a1d691fbd8d32436b7634b8b166e6a779e/appengine/swarming/ui2/dist/public_swarming_index.html
[modify] https://crrev.com/61c340a1d691fbd8d32436b7634b8b166e6a779e/appengine/swarming/ui2/dist/public_task_index-bundle.css
[modify] https://crrev.com/61c340a1d691fbd8d32436b7634b8b166e6a779e/appengine/swarming/ui2/dist/public_task_index-bundle.js
[modify] https://crrev.com/61c340a1d691fbd8d32436b7634b8b166e6a779e/appengine/swarming/ui2/dist/public_task_index.html
[modify] https://crrev.com/61c340a1d691fbd8d32436b7634b8b166e6a779e/appengine/swarming/ui2/dist/public_tasklist_index-bundle.css
[modify] https://crrev.com/61c340a1d691fbd8d32436b7634b8b166e6a779e/appengine/swarming/ui2/dist/public_tasklist_index-bundle.js
[modify] https://crrev.com/61c340a1d691fbd8d32436b7634b8b166e6a779e/appengine/swarming/ui2/dist/public_tasklist_index.html
[modify] https://crrev.com/61c340a1d691fbd8d32436b7634b8b166e6a779e/appengine/swarming/ui2/modules/task-list/task-list.js
[modify] https://crrev.com/61c340a1d691fbd8d32436b7634b8b166e6a779e/appengine/swarming/ui2/modules/task-list/task-list_test.js

Project Member

Comment 20 by bugdroid1@chromium.org, Jan 17 (5 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-py.git/+/89b3f35962e84f79340c4138344f8b14c3fb05f6

commit 89b3f35962e84f79340c4138344f8b14c3fb05f6
Author: Kevin Lubick <kjlubick@google.com>
Date: Thu Jan 17 13:07:30 2019

[swarming-ui] Add bot-mass-delete element

Incorporates it into bot-list and adds tests.

It also adds the stub for task-mass-cancel, which should
be similar.

Bug: 842181
Change-Id: I71def7d3a34f09ce1881ccd4aa86a2049d9c1ace
Reviewed-on: https://chromium-review.googlesource.com/c/1412257
Reviewed-by: Kevin Lubick <kjlubick@chromium.org>

[modify] https://crrev.com/89b3f35962e84f79340c4138344f8b14c3fb05f6/appengine/swarming/ui2/README.md
[modify] https://crrev.com/89b3f35962e84f79340c4138344f8b14c3fb05f6/appengine/swarming/ui2/dist/public_bot_index-bundle.js
[modify] https://crrev.com/89b3f35962e84f79340c4138344f8b14c3fb05f6/appengine/swarming/ui2/dist/public_bot_index.html
[modify] https://crrev.com/89b3f35962e84f79340c4138344f8b14c3fb05f6/appengine/swarming/ui2/dist/public_botlist_index-bundle.css
[modify] https://crrev.com/89b3f35962e84f79340c4138344f8b14c3fb05f6/appengine/swarming/ui2/dist/public_botlist_index-bundle.js
[modify] https://crrev.com/89b3f35962e84f79340c4138344f8b14c3fb05f6/appengine/swarming/ui2/dist/public_botlist_index.html
[modify] https://crrev.com/89b3f35962e84f79340c4138344f8b14c3fb05f6/appengine/swarming/ui2/dist/public_swarming_index-bundle.js
[modify] https://crrev.com/89b3f35962e84f79340c4138344f8b14c3fb05f6/appengine/swarming/ui2/dist/public_swarming_index.html
[modify] https://crrev.com/89b3f35962e84f79340c4138344f8b14c3fb05f6/appengine/swarming/ui2/dist/public_task_index-bundle.js
[modify] https://crrev.com/89b3f35962e84f79340c4138344f8b14c3fb05f6/appengine/swarming/ui2/dist/public_task_index.html
[modify] https://crrev.com/89b3f35962e84f79340c4138344f8b14c3fb05f6/appengine/swarming/ui2/dist/public_tasklist_index-bundle.css
[modify] https://crrev.com/89b3f35962e84f79340c4138344f8b14c3fb05f6/appengine/swarming/ui2/dist/public_tasklist_index-bundle.js
[modify] https://crrev.com/89b3f35962e84f79340c4138344f8b14c3fb05f6/appengine/swarming/ui2/dist/public_tasklist_index.html
[modify] https://crrev.com/89b3f35962e84f79340c4138344f8b14c3fb05f6/appengine/swarming/ui2/modules/bot-list/bot-list-demo.js
[modify] https://crrev.com/89b3f35962e84f79340c4138344f8b14c3fb05f6/appengine/swarming/ui2/modules/bot-list/bot-list.js
[modify] https://crrev.com/89b3f35962e84f79340c4138344f8b14c3fb05f6/appengine/swarming/ui2/modules/bot-list/bot-list.scss
[add] https://crrev.com/89b3f35962e84f79340c4138344f8b14c3fb05f6/appengine/swarming/ui2/modules/bot-mass-delete/bot-mass-delete-demo.html
[add] https://crrev.com/89b3f35962e84f79340c4138344f8b14c3fb05f6/appengine/swarming/ui2/modules/bot-mass-delete/bot-mass-delete-demo.js
[add] https://crrev.com/89b3f35962e84f79340c4138344f8b14c3fb05f6/appengine/swarming/ui2/modules/bot-mass-delete/bot-mass-delete.js
[add] https://crrev.com/89b3f35962e84f79340c4138344f8b14c3fb05f6/appengine/swarming/ui2/modules/bot-mass-delete/bot-mass-delete.scss
[add] https://crrev.com/89b3f35962e84f79340c4138344f8b14c3fb05f6/appengine/swarming/ui2/modules/bot-mass-delete/bot-mass-delete_test.js
[add] https://crrev.com/89b3f35962e84f79340c4138344f8b14c3fb05f6/appengine/swarming/ui2/modules/bot-mass-delete/index.js
[modify] https://crrev.com/89b3f35962e84f79340c4138344f8b14c3fb05f6/appengine/swarming/ui2/modules/sort-toggle/sort-toggle.js
[add] https://crrev.com/89b3f35962e84f79340c4138344f8b14c3fb05f6/appengine/swarming/ui2/modules/task-mass-cancel/index.js
[add] https://crrev.com/89b3f35962e84f79340c4138344f8b14c3fb05f6/appengine/swarming/ui2/modules/task-mass-cancel/task-mass-cancel-demo.html
[add] https://crrev.com/89b3f35962e84f79340c4138344f8b14c3fb05f6/appengine/swarming/ui2/modules/task-mass-cancel/task-mass-cancel-demo.js
[add] https://crrev.com/89b3f35962e84f79340c4138344f8b14c3fb05f6/appengine/swarming/ui2/modules/task-mass-cancel/task-mass-cancel.js
[add] https://crrev.com/89b3f35962e84f79340c4138344f8b14c3fb05f6/appengine/swarming/ui2/modules/task-mass-cancel/task-mass-cancel.scss
[add] https://crrev.com/89b3f35962e84f79340c4138344f8b14c3fb05f6/appengine/swarming/ui2/modules/task-mass-cancel/task-mass-cancel_test.js
[modify] https://crrev.com/89b3f35962e84f79340c4138344f8b14c3fb05f6/appengine/swarming/ui2/modules/util.js

Project Member

Comment 21 by bugdroid1@chromium.org, Jan 17 (5 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-py.git/+/f55e3e4a0cd1dbc1b428963a7746d4b6f5ceffe8

commit f55e3e4a0cd1dbc1b428963a7746d4b6f5ceffe8
Author: Kevin Lubick <kjlubick@google.com>
Date: Thu Jan 17 13:07:30 2019

[swarming-ui] move dialog-pop-over to own element

Bug: 842181
Change-Id: Iae1be71ce7adc115cc0610d432aa5fe7211c1b58
Reviewed-on: https://chromium-review.googlesource.com/c/1414031
Reviewed-by: Kevin Lubick <kjlubick@chromium.org>

[modify] https://crrev.com/f55e3e4a0cd1dbc1b428963a7746d4b6f5ceffe8/appengine/swarming/ui2/dist/public_bot_index-bundle.js
[modify] https://crrev.com/f55e3e4a0cd1dbc1b428963a7746d4b6f5ceffe8/appengine/swarming/ui2/dist/public_bot_index.html
[modify] https://crrev.com/f55e3e4a0cd1dbc1b428963a7746d4b6f5ceffe8/appengine/swarming/ui2/dist/public_botlist_index-bundle.css
[modify] https://crrev.com/f55e3e4a0cd1dbc1b428963a7746d4b6f5ceffe8/appengine/swarming/ui2/dist/public_botlist_index-bundle.js
[modify] https://crrev.com/f55e3e4a0cd1dbc1b428963a7746d4b6f5ceffe8/appengine/swarming/ui2/dist/public_botlist_index.html
[modify] https://crrev.com/f55e3e4a0cd1dbc1b428963a7746d4b6f5ceffe8/appengine/swarming/ui2/dist/public_swarming_index-bundle.js
[modify] https://crrev.com/f55e3e4a0cd1dbc1b428963a7746d4b6f5ceffe8/appengine/swarming/ui2/dist/public_swarming_index.html
[modify] https://crrev.com/f55e3e4a0cd1dbc1b428963a7746d4b6f5ceffe8/appengine/swarming/ui2/dist/public_task_index-bundle.js
[modify] https://crrev.com/f55e3e4a0cd1dbc1b428963a7746d4b6f5ceffe8/appengine/swarming/ui2/dist/public_task_index.html
[modify] https://crrev.com/f55e3e4a0cd1dbc1b428963a7746d4b6f5ceffe8/appengine/swarming/ui2/dist/public_tasklist_index-bundle.js
[modify] https://crrev.com/f55e3e4a0cd1dbc1b428963a7746d4b6f5ceffe8/appengine/swarming/ui2/dist/public_tasklist_index.html
[modify] https://crrev.com/f55e3e4a0cd1dbc1b428963a7746d4b6f5ceffe8/appengine/swarming/ui2/modules/bot-list/bot-list.js
[modify] https://crrev.com/f55e3e4a0cd1dbc1b428963a7746d4b6f5ceffe8/appengine/swarming/ui2/modules/bot-list/bot-list.scss
[add] https://crrev.com/f55e3e4a0cd1dbc1b428963a7746d4b6f5ceffe8/appengine/swarming/ui2/modules/dialog-pop-over/dialog-pop-over-demo.html
[add] https://crrev.com/f55e3e4a0cd1dbc1b428963a7746d4b6f5ceffe8/appengine/swarming/ui2/modules/dialog-pop-over/dialog-pop-over-demo.js
[add] https://crrev.com/f55e3e4a0cd1dbc1b428963a7746d4b6f5ceffe8/appengine/swarming/ui2/modules/dialog-pop-over/dialog-pop-over.js
[add] https://crrev.com/f55e3e4a0cd1dbc1b428963a7746d4b6f5ceffe8/appengine/swarming/ui2/modules/dialog-pop-over/dialog-pop-over.scss
[add] https://crrev.com/f55e3e4a0cd1dbc1b428963a7746d4b6f5ceffe8/appengine/swarming/ui2/modules/dialog-pop-over/dialog-pop-over_test.js
[add] https://crrev.com/f55e3e4a0cd1dbc1b428963a7746d4b6f5ceffe8/appengine/swarming/ui2/modules/dialog-pop-over/index.js

Project Member

Comment 22 by bugdroid1@chromium.org, Jan 17 (5 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-py.git/+/2ab655dbb6ed1a8a4dd7458feb4df98d701c4b76

commit 2ab655dbb6ed1a8a4dd7458feb4df98d701c4b76
Author: Kevin Lubick <kjlubick@google.com>
Date: Thu Jan 17 13:07:30 2019

[swarming-ui] Create task-mass-cancel

Bug: 842181
Change-Id: Ifd6c6e315b0eedaf0ef7edc9b11050991cc37f72
Reviewed-on: https://chromium-review.googlesource.com/c/1416232
Reviewed-by: Kevin Lubick <kjlubick@chromium.org>

[modify] https://crrev.com/2ab655dbb6ed1a8a4dd7458feb4df98d701c4b76/appengine/swarming/ui2/dist/public_bot_index-bundle.js
[modify] https://crrev.com/2ab655dbb6ed1a8a4dd7458feb4df98d701c4b76/appengine/swarming/ui2/dist/public_bot_index.html
[modify] https://crrev.com/2ab655dbb6ed1a8a4dd7458feb4df98d701c4b76/appengine/swarming/ui2/dist/public_botlist_index-bundle.css
[modify] https://crrev.com/2ab655dbb6ed1a8a4dd7458feb4df98d701c4b76/appengine/swarming/ui2/dist/public_botlist_index-bundle.js
[modify] https://crrev.com/2ab655dbb6ed1a8a4dd7458feb4df98d701c4b76/appengine/swarming/ui2/dist/public_botlist_index.html
[modify] https://crrev.com/2ab655dbb6ed1a8a4dd7458feb4df98d701c4b76/appengine/swarming/ui2/dist/public_swarming_index-bundle.js
[modify] https://crrev.com/2ab655dbb6ed1a8a4dd7458feb4df98d701c4b76/appengine/swarming/ui2/dist/public_swarming_index.html
[modify] https://crrev.com/2ab655dbb6ed1a8a4dd7458feb4df98d701c4b76/appengine/swarming/ui2/dist/public_task_index-bundle.js
[modify] https://crrev.com/2ab655dbb6ed1a8a4dd7458feb4df98d701c4b76/appengine/swarming/ui2/dist/public_task_index.html
[modify] https://crrev.com/2ab655dbb6ed1a8a4dd7458feb4df98d701c4b76/appengine/swarming/ui2/dist/public_tasklist_index-bundle.css
[modify] https://crrev.com/2ab655dbb6ed1a8a4dd7458feb4df98d701c4b76/appengine/swarming/ui2/dist/public_tasklist_index-bundle.js
[modify] https://crrev.com/2ab655dbb6ed1a8a4dd7458feb4df98d701c4b76/appengine/swarming/ui2/dist/public_tasklist_index.html
[modify] https://crrev.com/2ab655dbb6ed1a8a4dd7458feb4df98d701c4b76/appengine/swarming/ui2/modules/bot-list/bot-list_test.js
[modify] https://crrev.com/2ab655dbb6ed1a8a4dd7458feb4df98d701c4b76/appengine/swarming/ui2/modules/bot-mass-delete/bot-mass-delete-demo.html
[modify] https://crrev.com/2ab655dbb6ed1a8a4dd7458feb4df98d701c4b76/appengine/swarming/ui2/modules/bot-mass-delete/bot-mass-delete.js
[modify] https://crrev.com/2ab655dbb6ed1a8a4dd7458feb4df98d701c4b76/appengine/swarming/ui2/modules/bot-mass-delete/bot-mass-delete.scss
[modify] https://crrev.com/2ab655dbb6ed1a8a4dd7458feb4df98d701c4b76/appengine/swarming/ui2/modules/bot-mass-delete/bot-mass-delete_test.js
[modify] https://crrev.com/2ab655dbb6ed1a8a4dd7458feb4df98d701c4b76/appengine/swarming/ui2/modules/dialog-pop-over/dialog-pop-over.js
[modify] https://crrev.com/2ab655dbb6ed1a8a4dd7458feb4df98d701c4b76/appengine/swarming/ui2/modules/dialog-pop-over/dialog-pop-over.scss
[modify] https://crrev.com/2ab655dbb6ed1a8a4dd7458feb4df98d701c4b76/appengine/swarming/ui2/modules/swarming-app/swarming-app_test.js
[modify] https://crrev.com/2ab655dbb6ed1a8a4dd7458feb4df98d701c4b76/appengine/swarming/ui2/modules/swarming-index/swarming-index_test.js
[modify] https://crrev.com/2ab655dbb6ed1a8a4dd7458feb4df98d701c4b76/appengine/swarming/ui2/modules/task-list/task-list-demo.js
[modify] https://crrev.com/2ab655dbb6ed1a8a4dd7458feb4df98d701c4b76/appengine/swarming/ui2/modules/task-list/task-list.js
[modify] https://crrev.com/2ab655dbb6ed1a8a4dd7458feb4df98d701c4b76/appengine/swarming/ui2/modules/task-list/task-list.scss
[modify] https://crrev.com/2ab655dbb6ed1a8a4dd7458feb4df98d701c4b76/appengine/swarming/ui2/modules/task-list/task-list_test.js
[modify] https://crrev.com/2ab655dbb6ed1a8a4dd7458feb4df98d701c4b76/appengine/swarming/ui2/modules/task-mass-cancel/task-mass-cancel-demo.html
[modify] https://crrev.com/2ab655dbb6ed1a8a4dd7458feb4df98d701c4b76/appengine/swarming/ui2/modules/task-mass-cancel/task-mass-cancel-demo.js
[modify] https://crrev.com/2ab655dbb6ed1a8a4dd7458feb4df98d701c4b76/appengine/swarming/ui2/modules/task-mass-cancel/task-mass-cancel.js
[modify] https://crrev.com/2ab655dbb6ed1a8a4dd7458feb4df98d701c4b76/appengine/swarming/ui2/modules/task-mass-cancel/task-mass-cancel.scss
[modify] https://crrev.com/2ab655dbb6ed1a8a4dd7458feb4df98d701c4b76/appengine/swarming/ui2/modules/task-mass-cancel/task-mass-cancel_test.js
[modify] https://crrev.com/2ab655dbb6ed1a8a4dd7458feb4df98d701c4b76/appengine/swarming/ui2/modules/test_util.js

Project Member

Comment 23 by bugdroid1@chromium.org, Jan 18 (4 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-py.git/+/b6aa1780f4dab2ec1057ded85220adafca60a31a

commit b6aa1780f4dab2ec1057ded85220adafca60a31a
Author: Kevin Lubick <kjlubick@google.com>
Date: Fri Jan 18 16:53:18 2019

[swarming-ui] Fix links on task-list

Implement matching bots, counts and fix count logic.

Bug: 842181
Change-Id: I92dee814f10e8c22f7344ac948fe304487276431
Reviewed-on: https://chromium-review.googlesource.com/c/1418310
Reviewed-by: Kevin Lubick <kjlubick@chromium.org>

[modify] https://crrev.com/b6aa1780f4dab2ec1057ded85220adafca60a31a/appengine/swarming/ui2/dist/public_bot_index.html
[modify] https://crrev.com/b6aa1780f4dab2ec1057ded85220adafca60a31a/appengine/swarming/ui2/dist/public_botlist_index-bundle.css
[modify] https://crrev.com/b6aa1780f4dab2ec1057ded85220adafca60a31a/appengine/swarming/ui2/dist/public_botlist_index-bundle.js
[modify] https://crrev.com/b6aa1780f4dab2ec1057ded85220adafca60a31a/appengine/swarming/ui2/dist/public_botlist_index.html
[modify] https://crrev.com/b6aa1780f4dab2ec1057ded85220adafca60a31a/appengine/swarming/ui2/dist/public_swarming_index.html
[modify] https://crrev.com/b6aa1780f4dab2ec1057ded85220adafca60a31a/appengine/swarming/ui2/dist/public_task_index.html
[modify] https://crrev.com/b6aa1780f4dab2ec1057ded85220adafca60a31a/appengine/swarming/ui2/dist/public_tasklist_index-bundle.css
[modify] https://crrev.com/b6aa1780f4dab2ec1057ded85220adafca60a31a/appengine/swarming/ui2/dist/public_tasklist_index-bundle.js
[modify] https://crrev.com/b6aa1780f4dab2ec1057ded85220adafca60a31a/appengine/swarming/ui2/dist/public_tasklist_index.html
[modify] https://crrev.com/b6aa1780f4dab2ec1057ded85220adafca60a31a/appengine/swarming/ui2/modules/bot-list/bot-list.js
[modify] https://crrev.com/b6aa1780f4dab2ec1057ded85220adafca60a31a/appengine/swarming/ui2/modules/bot-list/bot-list_test.js
[modify] https://crrev.com/b6aa1780f4dab2ec1057ded85220adafca60a31a/appengine/swarming/ui2/modules/task-list/task-list-helpers.js
[modify] https://crrev.com/b6aa1780f4dab2ec1057ded85220adafca60a31a/appengine/swarming/ui2/modules/task-list/task-list.js
[modify] https://crrev.com/b6aa1780f4dab2ec1057ded85220adafca60a31a/appengine/swarming/ui2/modules/task-list/task-list_test.js
[modify] https://crrev.com/b6aa1780f4dab2ec1057ded85220adafca60a31a/appengine/swarming/ui2/modules/util.js

Sign in to add a comment