Issue metadata
Sign in to add a comment
|
In Landscape tab grid, "close all tabs" is on the wrong side |
||||||||||||||||||||||
Issue descriptionM68 canary, iPhoneX, iOS 11.3 - enable UIRefresh - have phone in portrait - open tab grid, note that "close all tabs" is on the left side, "done" is on right near where user just tapped. - close tab grid - rotate phone to landscape - open tab grid expected: - "close all tabs" on left, "done" on right actual: - "close all tabs" on right, "done" on left. Close all is now right under my thumb. This is the reverse of portrait and inconsistent.
,
May 23 2018
Just to make sure, I don't think we need any input from Pete here. As Pink said, Done should be where the tab switcher button is roughly. So Done on right, Close All on the left. Thanks.
,
Jun 7 2018
,
Jun 20 2018
,
Jun 20 2018
,
Jun 21 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/38174dbfbdda69414cbd8a7b96dcba5f02500297 commit 38174dbfbdda69414cbd8a7b96dcba5f02500297 Author: edchin <edchin@chromium.org> Date: Thu Jun 21 07:04:23 2018 [ios] Fix done button position in tab grid Bug: 842171 Change-Id: I225a5a3a5c23a7c0878f352f53a5e6dcec3c0df7 Reviewed-on: https://chromium-review.googlesource.com/1108741 Reviewed-by: edchin <edchin@chromium.org> Reviewed-by: Sergio Collazos <sczs@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#569177} [modify] https://crrev.com/38174dbfbdda69414cbd8a7b96dcba5f02500297/ios/chrome/browser/ui/tab_grid/tab_grid_view_controller.mm |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by pkl@chromium.org
, May 14 2018Status: Assigned (was: Untriaged)