Tab switching is not offered if the input contains a scheme |
||
Issue descriptionSteps to reproduce: 1. Have a tab open with some content. 2. Open a new tab and verify that some input that matches the content in the target tab produces a suggestion with the tab switch button. 3. Copy the full URL of the target tab. 4. Open a new tab and paste the URL into the omnibox. 5. Note that a suggestion is offered matching the target tab but the tab switch button is not present. A couple observations: - The steps above will produce a url-what-you-typed suggestion but it's possible to get a non-wyt suggestion by removing one or more characters from the end of the URL and pasting that. Then you'll get a history match, but it still won't have the tab switch button. - If you remove the scheme from the full URL and then paste that, you'll get a suggestion with the tab switch button present. This might seem like a really obscure case to worry about but it's very easy to trigger currently if you focus the tab switch button and then press space. That will fill the full URL of the target tab into the omnibox, plus a space. If you try to fix your mistake by deleting the space, you'd like to have the suggestion return with the button but the button will be gone.
,
May 14 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cafb944bc42712c0e4463a8eefc911d8b30793a7 commit cafb944bc42712c0e4463a8eefc911d8b30793a7 Author: Kevin Bailey <krb@chromium.org> Date: Mon May 14 21:40:25 2018 [omnibox] Pass same input to both URL reductions in comparison When comparing 2 URLs for equality in StrippedURLsAreEqual() - one a suggestion and one an open tab - we were passing the user input to only one of the reductions - the suggestion, since the suggestion was based on it, and because the open tab was assumed to be already cleaned up. Instead, the input causes rules to be applied to the suggestion URL which must also be applied to the open tab URL, so that, if equal, they compare equal. This CL changes the comparison to pass the input to both reductions so that we're comparing apples to apples. Bug: 842170 Change-Id: Ib88d7306b25ceaf9b1441366e66199620e107492 Reviewed-on: https://chromium-review.googlesource.com/1055670 Commit-Queue: Kevin Bailey <krb@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#558472} [modify] https://crrev.com/cafb944bc42712c0e4463a8eefc911d8b30793a7/chrome/browser/autocomplete/chrome_autocomplete_provider_client.cc [modify] https://crrev.com/cafb944bc42712c0e4463a8eefc911d8b30793a7/chrome/browser/autocomplete/chrome_autocomplete_provider_client_unittest.cc
,
May 17 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by k...@chromium.org
, May 11 2018