V8 uses __lsan_ignore_object under ASan causing link errors on Windows |
||
Issue descriptionLink error: C:/b/depot_tools/win_tools-2_7_6_bin/python/bin/python.exe ../../build/toolchain/win/tool_wrapper.py link-wrapper environment.x86 False link.exe /nologo /DLL /OUT:./ipc_message_dump.dll /PDB:./ipc_message_dump.dll.pdb @./ipc_message_dump.dll.rsp code-assembler.obj : error LNK2019: unresolved external symbol ___lsan_ignore_object referenced in function "public: void __cdecl v8::internal::compiler::CodeAssembler::Comment(char const *,...)" (?Comment@CodeAssembler@compiler@internal@v8@@QAAXPBDZZ) code-generator.obj : error LNK2001: unresolved external symbol ___lsan_ignore_object ./ipc_message_dump.dll : fatal error LNK1120: 1 unresolved externals First failing build: https://ci.chromium.org/buildbot/chromium.clang/CrWinAsan/566 It contains the V8 roll "Update V8 to version 6.8.199." with these changes: https://chromium.googlesource.com/v8/v8/+log/9c5f77a1..98ce1809 This change adds lsan stuff: https://chromium.googlesource.com/v8/v8/+/c8ae9729ec6364a18857a6e1a5629c2d23c2fb59 That's probably the culprit. This is probably breaking clusterfuzz builds, so a revert or fix is relatively urgent.
,
May 14 2018
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/db4f1ee435c87ca933d53e2c8627cfda76418679 commit db4f1ee435c87ca933d53e2c8627cfda76418679 Author: Clemens Hammacher <clemensh@chromium.org> Date: Mon May 14 09:57:32 2018 [lsan] Disable annotations on windows LSan is not implemented on windows, and trying to use the {__lsan_ignore_object} function gives link error. Since LSan is never enabled on windows, we also don't need the annotations, so just disable them on windows. R=bmeurer@chromium.org Bug: chromium:842166 , v8:7738 Change-Id: Ibaed77b4b884c09c7a08e081d953c56c53f907ff Reviewed-on: https://chromium-review.googlesource.com/1056990 Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#53141} [modify] https://crrev.com/db4f1ee435c87ca933d53e2c8627cfda76418679/src/lsan.h
,
May 14 2018
Fix landed in v8, still needs to roll into chromium. Will keep an eye on the win asat bot to verify that it turns green.
,
May 14 2018
Rolled as 31bb33d09ddd2aee6a3bded9607b605932b40bac.
,
May 14 2018
Issue 842441 has been merged into this issue. |
||
►
Sign in to add a comment |
||
Comment 1 by clemensh@chromium.org
, May 14 2018Status: Started (was: Unconfirmed)