The spec suggests [1] we should consider applying these two values in paging scroll operations e.g. PgDown, PgUp. We currently apply these for snapping, scrollIntoView, and focus. [1] https://drafts.csswg.org/css-scroll-snap/#scroll-padding
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/16495a74b2c3e5b07094c6184ab89509b0d9468f commit 16495a74b2c3e5b07094c6184ab89509b0d9468f Author: Majid Valipour <majidvp@chromium.org> Date: Wed Jun 20 21:32:41 2018 Page scroll operation takes scroll-padding into account Paging scroll operations should take scroll-padding into account [1]. So we use the snapport rect to calculate the page step instead of the visible rect. Other minor change: - VisibleScrollSnapportRect now takes into account scrollbar inclusion. This was needed since in at least one paging operation we needed to include scrollbars. [1] https://drafts.csswg.org/css-scroll-snap/#scroll-padding Bug: 842165 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I3112a94a984b438bc66fc2664b8288ec95a1d725 Reviewed-on: https://chromium-review.googlesource.com/1105520 Reviewed-by: David Bokan <bokan@chromium.org> Commit-Queue: Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#569028} [add] https://crrev.com/16495a74b2c3e5b07094c6184ab89509b0d9468f/third_party/WebKit/LayoutTests/fast/scroll-behavior/scroll-padding-page-scrolling.html [modify] https://crrev.com/16495a74b2c3e5b07094c6184ab89509b0d9468f/third_party/blink/renderer/core/frame/local_frame_view.cc [modify] https://crrev.com/16495a74b2c3e5b07094c6184ab89509b0d9468f/third_party/blink/renderer/core/frame/local_frame_view.h [modify] https://crrev.com/16495a74b2c3e5b07094c6184ab89509b0d9468f/third_party/blink/renderer/core/frame/root_frame_viewport.cc [modify] https://crrev.com/16495a74b2c3e5b07094c6184ab89509b0d9468f/third_party/blink/renderer/core/frame/root_frame_viewport.h [modify] https://crrev.com/16495a74b2c3e5b07094c6184ab89509b0d9468f/third_party/blink/renderer/core/paint/paint_layer_scrollable_area.cc [modify] https://crrev.com/16495a74b2c3e5b07094c6184ab89509b0d9468f/third_party/blink/renderer/core/paint/paint_layer_scrollable_area.h [modify] https://crrev.com/16495a74b2c3e5b07094c6184ab89509b0d9468f/third_party/blink/renderer/platform/scroll/scrollable_area.cc [modify] https://crrev.com/16495a74b2c3e5b07094c6184ab89509b0d9468f/third_party/blink/renderer/platform/scroll/scrollable_area.h
Comment 1 by majidvp@chromium.org
, May 22 2018Cc: sunyunjia@chromium.org
Owner: majidvp@chromium.org