New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 842146 link

Starred by 4 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug

Blocked on:
issue 833999



Sign in to add a comment

Make ANGLE standalone Linux GCC compile builders work

Project Member Reported by jmad...@chromium.org, May 11 2018

Issue description

Currently these testers fail because of an extremely old GCC version that doesn't support Chromium flags like -gnu++14.

For example: https://ci.chromium.org/p/angle/builders/luci.angle.ci/linux-gcc-dbg/19

The listed GCC version is [GCC 4.8.4] on our bots currently, while Skia uses [GCC 6.3.0 20170516].

thakis@ mentioned that this GCC version comes from the images used for these bots, and a possible solution is using a hermetic GCC binary like they do with the Clang binary. Another option would be to upgrade the GCC in the image, or make a custom image for ANGLE.

machenbach@, V8 also has GCC testing, do you guys use the current 4.8.4 version? Have you ever tried upgrading GCC or using a different version?
 

Comment 1 by thakis@chromium.org, May 11 2018

s/testers/builders/ (?)
Summary: Make ANGLE standalone Linux GCC compile builders work (was: Make ANGLE standalone Linux GCC testers work)
Yes, I'm referring to compile-only bots.
nope, we continued using 4.8. We add the gn arg use_cxx11=true to all our gcc bots.
Cool. Have you guys discussed to updating to c++14? i.e. have you ever discussed upgrading your GCC version? If I requested the version in the image upgraded, would it disrupt you guys?

Comment 5 by thakis@chromium.org, May 11 2018

I think all the chromium subprojects that choose to explicitly support gcc should have a conversation about what their motivations for doing so are, and what the min gcc version they want to support is. 4.8.4 is the default on some ubuntu version, so if working with that gcc is part of the motivation then some subprojects probably want to keep around support for that -- in that case, each project should probably DEPS in a gcc binary that they want to support, since if different subprojects want to support different gccs, using system gcc won't work. (Unless we have different system images for different subprojects, which sounds like a nightmare for infra.)

I'd be curious to hear the summary of motivations once that conversation has happened.
Nico, I think Skia uses their own image already. Do you know what other subprojects want to support GCC other than V8 and ANGLE?

Comment 7 by thakis@chromium.org, May 11 2018

skia uses homegrown stuff for almost everything, so they're a bit of a special case.

Probably webrtc, and maybe pdfium. Possibly others I don't know about.
Cc: ofrobots@chromium.org yangguo@chromium.org
V8 supports gcc solely for node.js. It seems the minimum version should be 4.9 according to some web resources. Ali or Yang, do you know more?

Sign in to add a comment