Make perf one build bot step store each benchmark's log in logdog |
||||
Issue descriptionOne major blocker of rolling out one build bot step (OBBS) on all perf configs is the number of shards we can have. The reason is one build bot step has a huge log since it execute all Telemetry benchmarks in one single step, thus a low number of shards will lead to unconsumable log. A way to tackle this is to store each benchmark's log separately in logdog. To do this, we can modify run_performance_tests to save each benchmark's stdout/stderr into a file, then upload that file to logdog. The pipeline to handle this can be very similar to how we save the perf json results of each benchmark in logdog.
,
May 14 2018
I have some free cycle, so I may tackle this bug with Emily's help
,
May 18 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ec1e58d7d52c0528d1db3d8beda48cb6bc3389ac commit ec1e58d7d52c0528d1db3d8beda48cb6bc3389ac Author: nednguyen <nednguyen@google.com> Date: Fri May 18 11:54:39 2018 Refactor process_perf_results to separate handling perf dashboard results out from handling perf json results Bug: 842145 Change-Id: If995ba7d4e50a9bd4284c3b05fd20d4cf05fb67e Reviewed-on: https://chromium-review.googlesource.com/1064317 Reviewed-by: Emily Hanley <eyaich@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#559867} [modify] https://crrev.com/ec1e58d7d52c0528d1db3d8beda48cb6bc3389ac/tools/perf/process_perf_results.py
,
May 18 2018
,
May 18 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a8950e4ae1489ace1765474d12edbe6afe257a9f commit a8950e4ae1489ace1765474d12edbe6afe257a9f Author: nednguyen <nednguyen@google.com> Date: Fri May 18 22:42:06 2018 Enable tracking benchmark's log (stdout/stderr) in 'Benchmarks Log' link Bug: 842145 Change-Id: Ib8484e4a851ebcc2c48e80f5f707749c0da49b41 Reviewed-on: https://chromium-review.googlesource.com/1063996 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by: Emily Hanley <eyaich@chromium.org> Cr-Commit-Position: refs/heads/master@{#560081} [modify] https://crrev.com/a8950e4ae1489ace1765474d12edbe6afe257a9f/testing/scripts/run_performance_tests.py [modify] https://crrev.com/a8950e4ae1489ace1765474d12edbe6afe257a9f/testing/scripts/run_telemetry_benchmark_as_googletest.py [modify] https://crrev.com/a8950e4ae1489ace1765474d12edbe6afe257a9f/tools/perf/process_perf_results.py
,
May 21 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2da79f8cb852254631200138256b0d7ad7281359 commit 2da79f8cb852254631200138256b0d7ad7281359 Author: Emily Hanley <eyaich@google.com> Date: Mon May 21 18:29:39 2018 Initializing upload_failed to prevent program initialization failure There is a case where no benchmarks could be uploading perf results from a shard (ie they are all disabled). Bug: 842145 Change-Id: Iea52461dee8e8a7c4475396d9af9f0339cdfaf3e Reviewed-on: https://chromium-review.googlesource.com/1066080 Reviewed-by: Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#560311} [modify] https://crrev.com/2da79f8cb852254631200138256b0d7ad7281359/tools/perf/process_perf_results.py
,
May 22 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by nednguyen@chromium.org
, May 11 2018