New issue
Advanced search Search tips

Issue 842131 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Cursor position doesn’t get changed while typing the text and direction of text is wrong in Find-In-Page textbox.

Reported by dchau...@etouch.net, May 11 2018

Issue description

Chrome Version: 68.0.3427.0 (Official Build) (64-bit) Revision	afb48319da5a0de6204978a68993f32d1d506263-refs/branch-heads/3427@{#1}
OS: Mac(10.12.6, 10.13.1, 10.13.5).

What steps will reproduce the problem?
1. Launch Chrome and go to any webpage (For Ex: www.facebook.com).
2. Press “Command + F” key from keyboard to open Find-In-Page text-box.
3. Type any keyword (For Ex: Facebook) in Find-In-Page textbox and observe.

Actual: Cursor position doesn’t get changed while typing the text and direction of text is wrong.
Expected: Cursor position should change accordingly while typing the text and direction of text should seen properly.

This is a mac specific regression issue, broken in M-68 series, below is manual regression range.

Good build: 68.0.3426.0 (Revision: 557429)
Bad build: 68.0.3427.0 (Revision: 557758)

Providing the bisect using per-revision bisect:

You are probably looking for a change made after 557715 (known good), but no later than 557716 (first known bad).
CHANGELOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.
  https://chromium.googlesource.com/chromium/src/+log/7db664ae330cbc285b7eaa9be808d9d4c2412d5f..626e8f4e769a669f0060451d720b28a4a10310d9

Suspecting: https://chromium.googlesource.com/chromium/src/+/626e8f4e769a669f0060451d720b28a4a10310d9

@robliao: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

NOTE: This issue is not seen on Win(7,8,8.1,10) and Linux (14.04 LTS) OS.

Kindly review the attached screen-cast for reference.

Thank You!
 
Actual behavior.mov
4.5 MB View Download
Expected behavior.mov
2.2 MB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, May 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2a741a1fd691061cb7ff8c93a4a6d9a1fa5937c3

commit 2a741a1fd691061cb7ff8c93a4a6d9a1fa5937c3
Author: Robert Liao <robliao@chromium.org>
Date: Fri May 11 16:46:06 2018

Propagate the Views Find Bar Text Changes to the Pasteboard

Adds support to get the views find bar text to the global pasteboard.
Also fixes a Cocoa bug introduced in the previous pasteboard change
where the selection is always reset to the beginning at every keystroke.

BUG= 826478 , 827189 , 842131 

Change-Id: If1a639f1997e3fea7fee2c66959e7dcdb2fd3bc7
Reviewed-on: https://chromium-review.googlesource.com/1055195
Commit-Queue: Robert Liao <robliao@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557902}
[modify] https://crrev.com/2a741a1fd691061cb7ff8c93a4a6d9a1fa5937c3/chrome/browser/ui/find_bar/find_bar_controller.cc
[modify] https://crrev.com/2a741a1fd691061cb7ff8c93a4a6d9a1fa5937c3/chrome/browser/ui/find_bar/find_bar_controller.h
[modify] https://crrev.com/2a741a1fd691061cb7ff8c93a4a6d9a1fa5937c3/chrome/browser/ui/find_bar/find_bar_platform_helper.h
[modify] https://crrev.com/2a741a1fd691061cb7ff8c93a4a6d9a1fa5937c3/chrome/browser/ui/find_bar/find_bar_platform_helper_mac.mm
[add] https://crrev.com/2a741a1fd691061cb7ff8c93a4a6d9a1fa5937c3/chrome/browser/ui/find_bar/find_bar_platform_helper_mac_interactive_uitest.mm
[modify] https://crrev.com/2a741a1fd691061cb7ff8c93a4a6d9a1fa5937c3/chrome/browser/ui/views/find_bar_view.cc
[modify] https://crrev.com/2a741a1fd691061cb7ff8c93a4a6d9a1fa5937c3/chrome/test/BUILD.gn

Status: Fixed (was: Assigned)
Cc: robliao@chromium.org
 Issue 843740  has been merged into this issue.

Sign in to add a comment