New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 842130 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 20
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Non-Regression : 'DELETE' text is seen black on hovering mouse on 'DELETE' button in FilesApp

Project Member Reported by mmanchala@chromium.org, May 11 2018

Issue description

Chrome Version:  68.0.3425.0/10666.0.0 dev-channel Paine,Peppy and Kip
OS: Chrome

What steps will reproduce the problem?
(1)Sign into User -> Download images or Take Screenshots using  'Ctrl+F5(Overview Mode Button)'  
(2)Now go to Files App-> click on thumbnail of image, so that image will be ticked ('Cancel selection','Open','Delete' options are seen) -> now click on 'Delete' option -> 'Are you sure you...' Dialog box is seen with 'DELETE' and 'CANCEL' buttons
(3)hover mouse on  'DELETE' button and observe text is seen black 
(Please refer video and Screenshot)


Note : In Files App select image , so that blue highlight is seen for image -> now at Header part select 'Delete' option ->  'Are you sure you...' Dialog box is seen with 'DELETE' and 'CANCEL' buttons -> hover mouse on  'DELETE' button and observe text is not seen black
(Please refer 'Expected_Text' video and screnshot)

Expected: On hovering mouse on 'DELETE' button, text should not be seen black
Actual: Instead on hovering mouse on 'DELETE' button, text is seen black

This is Non-Regression Issue seen from M-62

@fukino : Please confirm the Issue
 
Actual_BlackText.webm
1.8 MB View Download
Actual_Text.jpg
783 KB View Download
Expected_Text.webm
313 KB View Download
Expected_Text.jpg
1015 KB View Download
Labels: -Pri-2 -M-68 CrOSFilesCategory-UI Pri-3
Owner: ----
Status: Available (was: Assigned)

Comment 2 by sashab@chromium.org, May 30 2018

Owner: nigeltao@chromium.org
Status: Assigned (was: Available)
Assigning to Nigel as a low-pri UI starter bug :)
Labels: Files-Fixit-2018
Owner: ----
Status: Available (was: Assigned)
Status: Closed (was: Available)
This doesn't repro in 72.0.3611.0.
Owner: sa...@chromium.org
Status: Assigned (was: Closed)
Able to repro issue on latest M-72 72.0.2612/11279.0.0 dev-channel Kip,
attaching video for reference.
Reopening issue

Thanks..!!
Actual_BlackTextOnLatestM72.mp4
15.6 MB Download
Project Member

Comment 7 by bugdroid1@chromium.org, Nov 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d1e093c27066ce5de912a69813f95593ad6f6de4

commit d1e093c27066ce5de912a69813f95593ad6f6de4
Author: Sam McNally <sammc@chromium.org>
Date: Tue Nov 20 22:41:38 2018

Apply the dialog ok button color with hover as well as without.

Currently, the hover color for dialog ok buttons is not set, so it falls
through to the default button color, which varies depending on whether
check-select is applied to the body. This causes hovering to make the
text color dark instead of remaining unchanged. Set the color for both
with and without hover to avoid this.

Bug:  842130 
Change-Id: I67a02346a7aa173de91ac41366cbdd5057e9e6c3
Reviewed-on: https://chromium-review.googlesource.com/c/1345169
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609832}
[modify] https://crrev.com/d1e093c27066ce5de912a69813f95593ad6f6de4/ui/file_manager/file_manager/foreground/css/common.css

Status: Fixed (was: Assigned)

Sign in to add a comment