New issue
Advanced search Search tips

Issue 842127 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug

Blocking:
issue 827073



Sign in to add a comment

Remove leftover exported files when passwords are deleted from local storage

Project Member Reported by ioanap@chromium.org, May 11 2018

Issue description

The password export operation saves a temporary file containing passwords locally, in order to pass the data to the consumer app. There are cases in which the file is not removed when the export finishes. 

Deleting these temporary files when passwords are removed from local storage (keychain) will ensure that they are not persisted on the device past their intended removal.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/49873f22bfc576f26a79553c2b6054b145101e84

commit 49873f22bfc576f26a79553c2b6054b145101e84
Author: Ioana Pandele <ioanap@chromium.org>
Date: Thu May 17 11:52:53 2018

Remove leftover exported files when passwords are deleted

The password export operation saves a temporary file containing passwords locally, in order to pass
the data to the consumer app. There are cases in which the file is not removed when the export
finishes.

Deleting these temporary files when passwords are removed from local storage (keychain)
ensures  that they are not persisted on the device past their intended removal.

Bug:842127

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I0e965b41a726240714d209646a9394a35995f9e7
Reviewed-on: https://chromium-review.googlesource.com/1047869
Commit-Queue: Ioana Pandele <ioanap@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559494}
[modify] https://crrev.com/49873f22bfc576f26a79553c2b6054b145101e84/components/password_manager/core/browser/login_database_ios.cc
[modify] https://crrev.com/49873f22bfc576f26a79553c2b6054b145101e84/components/password_manager/core/browser/login_database_ios_unittest.cc
[modify] https://crrev.com/49873f22bfc576f26a79553c2b6054b145101e84/components/password_manager/core/browser/login_database_unittest.cc
[modify] https://crrev.com/49873f22bfc576f26a79553c2b6054b145101e84/components/password_manager/core/common/BUILD.gn
[add] https://crrev.com/49873f22bfc576f26a79553c2b6054b145101e84/components/password_manager/core/common/passwords_directory_util_ios.cc
[add] https://crrev.com/49873f22bfc576f26a79553c2b6054b145101e84/components/password_manager/core/common/passwords_directory_util_ios.h
[add] https://crrev.com/49873f22bfc576f26a79553c2b6054b145101e84/components/password_manager/core/common/passwords_directory_util_ios_unittest.cc
[modify] https://crrev.com/49873f22bfc576f26a79553c2b6054b145101e84/ios/chrome/app/main_controller.mm
[modify] https://crrev.com/49873f22bfc576f26a79553c2b6054b145101e84/ios/chrome/browser/passwords/BUILD.gn
[delete] https://crrev.com/72fbe934d9fd3d62dc5892d9b00768a72eece63f/ios/chrome/browser/passwords/passwords_directory_util.h
[delete] https://crrev.com/72fbe934d9fd3d62dc5892d9b00768a72eece63f/ios/chrome/browser/passwords/passwords_directory_util.mm
[delete] https://crrev.com/72fbe934d9fd3d62dc5892d9b00768a72eece63f/ios/chrome/browser/passwords/passwords_directory_util_unittest.mm
[modify] https://crrev.com/49873f22bfc576f26a79553c2b6054b145101e84/ios/chrome/browser/ui/settings/password_exporter.h
[modify] https://crrev.com/49873f22bfc576f26a79553c2b6054b145101e84/ios/chrome/browser/ui/settings/password_exporter.mm

Comment 2 by ioanap@chromium.org, May 18 2018

Status: Fixed (was: Assigned)

Sign in to add a comment