Issue metadata
Sign in to add a comment
|
Regression : Grey focus highlight on close icon 'X' appears misaligned in chrome://downloads page.
Reported by
rp...@etouch.net,
May 11 2018
|
||||||||||||||||||||||
Issue descriptionVersion: 68.0.3427.0 (Official Build) Revision afb48319da5a0de6204978a68993f32d1d506263-refs/branch-heads/3427@{#1}(32/64-bit) OS: Windows (7,8,8.1,10) What steps will reproduce the problem? 1. Launch chrome,download any file and navigate to chrome://downloads/ 2. Now press 'Tab' key such as grey focus highlight is seen on close icon of downloaded item entry overlay,observe focus highlight Actual: Grey focus highlight on close icon 'X' appears misaligned Expected: Grey focus highlight on close icon 'X' should be seen properly aligned This is regression issue, broken in ‘M 67’ and will below is the Bisect info : Good build: 67.0.3368.0 Bad build: 67.0.3369.0 Narrow bisect info: You are probably looking for a change made after 542342(known good), but no later than 542362(first known bad). CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+log/d123a43f7c147b640799aa29c20f80c525dc9a51..000c02e35c544b85064128c281ef11e4c531e03f?pretty=fuller&n=50 Suspecting: r542362 from Narrow bisect @hcarmona: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. NOTE: 1. This issue is also reproducible on M-67 Beta (build # 67.0.3396.40) and M-68 Dev (build # 68.0.3423.2) 2. Unable to narrow down the range using per-revision bisect,hence providing bisect using old script 3. Above issue is not seen on Linux (14.04 LTS) and Mac OS X(10.12.6,10.13.1,10.13.5) Thanks!
,
May 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ebf823339f77adb1fbf0ac95f46ac681506badd1 commit ebf823339f77adb1fbf0ac95f46ac681506badd1 Author: Hector Carmona <hcarmona@chromium.org> Date: Wed May 16 01:46:34 2018 WebUI - Downloads: Fix close button's X alignment. X was changed to an SVG applied with CSS to match other clear buttons. Screenshot in bug. Bug: 842121 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I0fb544ea429f8a10c2b65144ee17a8dce9f31a4c Reviewed-on: https://chromium-review.googlesource.com/1058174 Commit-Queue: Hector Carmona <hcarmona@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#558919} [modify] https://crrev.com/ebf823339f77adb1fbf0ac95f46ac681506badd1/chrome/browser/resources/md_downloads/item.html
,
May 16 2018
,
May 17 2018
Update: Rechecked the above issue on Windows(7,8,8.1,10) OS with latest Canary Chrome version : 68.0.3433.0 and the issue is fixed.Kindly refer the attached screen cast for reference. Thank you. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by hcarmona@chromium.org
, May 14 2018