New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 842120 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: ----



Sign in to add a comment

Build url is incorrect for autorevert of flaky tests

Project Member Reported by cr-audit...@appspot.gserviceaccount.com, May 11 2018

Issue description

commit https://chromium.googlesource.com/chromium/src.git/+/80cbe682e287f7562c7fd7e7b0a24927de78675d has caused the audit process to fail repeatedly, please audit by hand and don't close this bug until the root cause of the failure has been identified and resolved.
 

Comment 1 by st...@chromium.org, May 11 2018

Components: -Tools>Test>FindIt>Autorevert Tools>Test>FindIt>Flakiness
Labels: Pri-1
Owner: lijeffrey@chromium.org
Status: Assigned (was: Untriaged)
Summary: Build url is incorrect for autorevert of flaky tests (was: Audit on "80cbe682e287f7562c7fd7e7b0a24927de78675d" failed over 7 times)
Please move the sample flaky step/test to the top in the commit message as well.
Project Member

Comment 2 by bugdroid1@chromium.org, May 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/ac27a960f8e161a660425faa9fb899ac0f930caf

commit ac27a960f8e161a660425faa9fb899ac0f930caf
Author: Roberto Carrillo <robertocn@google.com>
Date: Fri May 11 23:05:39 2018

[cr-audit-commits] Use new sample flaky test prefix.

This is used to determine if an auto-revert is meant to address a
flakiness culprit.

R=lijeffrey,chanli,stgao

Bug:842120
Change-Id: I70e7eea796164aefc59ff3742fe8f664898bdedb
Reviewed-on: https://chromium-review.googlesource.com/1056224
Reviewed-by: Shuotao Gao <stgao@chromium.org>
Commit-Queue: Roberto Carrillo <robertocn@chromium.org>

[modify] https://crrev.com/ac27a960f8e161a660425faa9fb899ac0f930caf/go/src/infra/appengine/cr-audit-commits/app/findit_rules_test.go
[modify] https://crrev.com/ac27a960f8e161a660425faa9fb899ac0f930caf/go/src/infra/appengine/cr-audit-commits/app/utils.go

Project Member

Comment 3 by bugdroid1@chromium.org, May 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/a439805a2586b9f232fff5d0e01f109c91b5b3bf

commit a439805a2586b9f232fff5d0e01f109c91b5b3bf
Author: Jeffrey Li <lijeffrey@chromium.org>
Date: Mon May 14 16:42:49 2018

[Findit] Flake Analyzer - Fixing auto revert commit body

1. Use the MasterFlakeAnalysis' original build number when pointing to
   a sample failed build.
2. Remove footer, as the information in there is already provided in the
   body of the revert text
3. Update flake analysis text to say "Flaky Test" instead of "Failed test"

Bug:  842120 
Change-Id: I9349ab034cf20908d967957efc66b6e359a88741
Reviewed-on: https://chromium-review.googlesource.com/1055785
Commit-Queue: Jeffrey Li <lijeffrey@chromium.org>
Reviewed-by: Chan Li <chanli@chromium.org>
Reviewed-by: Shuotao Gao <stgao@chromium.org>
Reviewed-by: Roberto Carrillo <robertocn@chromium.org>

[modify] https://crrev.com/a439805a2586b9f232fff5d0e01f109c91b5b3bf/appengine/findit/infra_api_clients/codereview/test/gerrit_test.py
[modify] https://crrev.com/a439805a2586b9f232fff5d0e01f109c91b5b3bf/appengine/findit/pipelines/test/create_revert_cl_pipeline_test.py
[modify] https://crrev.com/a439805a2586b9f232fff5d0e01f109c91b5b3bf/appengine/findit/pipelines/flake_failure/analyze_flake_pipeline.py
[modify] https://crrev.com/a439805a2586b9f232fff5d0e01f109c91b5b3bf/appengine/findit/infra_api_clients/codereview/gerrit.py
[modify] https://crrev.com/a439805a2586b9f232fff5d0e01f109c91b5b3bf/appengine/findit/pipelines/flake_failure/test/analyze_flake_pipeline_test.py
[modify] https://crrev.com/a439805a2586b9f232fff5d0e01f109c91b5b3bf/appengine/findit/services/test/gerrit_test.py
[modify] https://crrev.com/a439805a2586b9f232fff5d0e01f109c91b5b3bf/appengine/findit/services/gerrit.py

Status: Fixed (was: Assigned)

Sign in to add a comment