New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 842110 link

Starred by 3 users

Issue metadata

Status: Duplicate
Merged: issue 843189
Owner:
Last visit > 30 days ago
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Suggestion's favicon icon and text is not aligned with each other in omnibox.

Reported by avsha...@etouch.net, May 11 2018

Issue description

Chrome Version : 68.0.3427.0 (Official Build) afb48319da5a0de6204978a68993f32d1d506263-refs/branch-heads/3427@{#1} 32/64-bit
OS : Windows(7,8,8.1,10)

What steps will reproduce the problem?
1. Launch chrome and open NTP.
2. Type 'a' in omnibox and observe the suggestions list.

Actual Result : Suggestion's favicon icon and text is not aligned with each other in omnibox.

Expected Result : Suggestion's favicon icon and text should be aligned properly with each other in omnibox.

Note : Unable to narrow down the range using per-revision script as getting traceback error between this range,hence providing bisect using old script.

This is a regression issue, broken in M-68 and providing the bisect using old script:
Good Build : 68.0.3426.2 (Revision : 557429)
Bad Build : 68.0.3427.0 (Revision : 557758)

Narrow bisect URL :
https://chromium.googlesource.com/chromium/src/+log/3269695c3d558a1d7b886418c996d4e2ff77fc5d..cc01dffa5e145abcfd2d60f8063375ca9f611d36

Suspecting : r557616

@Dave : Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Note : 
1. Issue is not seen on Mac(10.12.6, 10.13.1, 10.13.5) and Linux(14.04 LTS) OS.
 
Omnibox_Suggestions.png
19.8 KB View Download
Actual_Result.mp4
420 KB View Download

Comment 1 by meh...@chromium.org, May 11 2018

Labels: Proj-MacViews OS-Mac
The text is also off (too low) by 1px under enabled MacViews (chrome://flags/#views-browser-windows).
actual.png
34.0 KB View Download
expected.png
35.7 KB View Download
Mergedinto: 843189
Status: Duplicate (was: Assigned)

Comment 3 by gov...@chromium.org, May 22 2018

M68 branch is coming soon on this Thursday, 05/24 and M68 Beta promotion is on 06/07. 
This bug is marked as P1 for M68. Pls land the fix to trunk ASAP (if possible before 4:00 PM PT this Thursday in order to make it to M68 branch build cut. Thank you.

Sign in to add a comment