New issue
Advanced search Search tips

Issue 842099 link

Starred by 1 user
Status: Fixed
Owner:
aee@chromium.org
Closed: May 2018
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
namratakannan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression

Blocking:
issue 831852



Sign in to add a comment

Regression:Unable to visually differentiate between dev-mode toolbar and details page of extension.

Reported by shruti.j...@etouch.net, May 11 2018 
Chrome version : 68.0.3427.0 (Official Build) afb48319da5a0de6204978a68993f32d1d506263-refs/branch-heads/3427@{#1}(32/64-bit) 

OS: Windows(7,8,8.1,10), Mac(10.12.6,10.13.1,10.13.5),Linux(14.04 LTS)

Steps to reproduce:
1.Launch chrome and navigate to chroe://extensions
2.Enable developer mode and click on extensions 'Details' button and observe.

Actual Result:Unable to visually differentiate between dev-mode toolbar and details page of extension. 
Expected Result:Dev-mode toolbar should have dark border at the bottom so that it can differentiate page and tool-bar

This is regression issue broken in ‘M-68’ and providing per-revision bisect info below
Good Build:68.0.3426.0(Revision: 557429)  
Bad Build:68.0.3427.0(Revision:557758)
 
You are probably looking for a change made after 557720 (known good), but no later than 557721 (first known bad).
CHANGE-LOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/998efe38db19486bb8d4b89c520020ba6ddf96bf..0884a2c6a68829fdb63261916c9239c3ff3cab87

Suspecting:https://chromium.googlesource.com/chromium/src/+/0884a2c6a68829fdb63261916c9239c3ff3cab87
@Esmael: Could you please help to reassign if your change is not the cause for this change.

Note :Pardon me if it is intended as visually differentiating between details page and toolbar is difficult.
Thank You!
Actual_Result.mov
4.4 MB View Download
Expected_Result.mov
3.4 MB View Download
Actual_Result.png
23.6 KB View Download
Expected_Result.png
25.8 KB View Download

Comment 1 by aee@chromium.org, May 11 2018

Cc: namratakannan@chromium.org
@namratakannan: should the dev-mode button strip be visually differentiated from the extension details? If so, what should it look like?

Comment 2 by namratakannan@chromium.org, May 11 2018 

Can we add a 1px line/border at the bottom edge of the dev toolbar. Color (Google grey 300: #DADCE0)

Attached pics.
extensions_details.png
252 KB View Download
page_extensions_devmode.png
113 KB View Download

Comment 3 by aee@chromium.org, May 11 2018

Status: Started (was: Assigned)

Comment 4 by namratakannan@chromium.org, May 11 2018

Blocking: 831852
Components: -Platform>Extensions UI>Browser>ExtensionsManagement

Comment 5 by dpa...@chromium.org, May 12 2018

Labels: Proj-MaterialDesign-Refresh-WebUI
Project Member

Comment 6 by bugdroid1@chromium.org, May 12 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a89bc49b4eb9b5f416470bd241297c6fb0472e50

commit a89bc49b4eb9b5f416470bd241297c6fb0472e50
Author: Esmael El-Moslimany <aee@chromium.org>
Date: Sat May 12 00:26:05 2018

MD Extensions: adding border to dev toolbar

Bug:  842099 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ic52a5afc94ab2de1e5745df995441b1c5e6f152b
Reviewed-on: https://chromium-review.googlesource.com/1055815
Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558069}
[modify] https://crrev.com/a89bc49b4eb9b5f416470bd241297c6fb0472e50/chrome/browser/resources/md_extensions/toolbar.html

Comment 7 by aee@chromium.org, May 12 2018

Status: Fixed (was: Started)

Comment 8 by shruti.j...@etouch.net, May 14 2018

Labels: TE-Verified-M68 TE-Verified-68.0.3430.0
Summary: Regression:Unable to visually differentiate between dev-mode toolbar and details page of extension. (was: RegressionUnable to visually differentiate between dev-mode toolbar and details page of extension. )
Update : 
Retested above issue on Windows (7,8,8.1,10) Linux(14.04 LTS) and Mac(10.12.6,10.13.1,10.13.5) OS using latest Canary #68.0.3430.0 and issue is fixed.Visually differentiating between page and Dev-mode toolbar is easy now. 
.Kindly review the attached screen-cast.

Thank you!
Canary_Behaviour#68.0.3430.0.mov
2.0 MB View Download
►

Sign in to add a comment