Preserve HTTP code of failed Sync request |
||||
Issue descriptionThe Chrome Sync client currently considers all non-200 HTTP codes as equivalent: https://cs.chromium.org/chromium/src/components/sync/engine_impl/net/server_connection_manager.cc?rcl=b8d3b1e930ee8120f36e14511f54a7127e81ed96&l=68 This discards useful information. In particular, the Sync server may emit the following HTTP codes: * 400 Bad Request * 401 Unauthorized * 403 Forbidden * 404 Not Found * 429 Too Many Requests * 500 Internal Server Error * 503 Service Unavailable (I also saw a 504 Gateway Timeout; I don’t think the Sync server itself would have generated that, but it’s a possible response) In particular, while investigating https://crbug.com/838323, I would really have liked to see an HTTP 429 error instead of SYNC_SERVER_ERROR. This would have saved a lot of investigation time.
,
May 11 2018
Yeah, I don’t see it anywhere. I would have expected to see it in chrome://sync-internals somewhere, ideally in the log, but at least in some kind of “most recent status” field.
,
May 11 2018
To make it at least show up in console logs, it needs to be added here: https://cs.chromium.org/chromium/src/components/sync/engine_impl/net/server_connection_manager.cc?rcl=e127247ef7e8c02498522c5e2e507cc8b39af278&l=275 To make it show up in sync-internals, it'll need to be piped through to here: https://cs.chromium.org/chromium/src/components/sync/engine_impl/events/get_updates_response_event.cc?rcl=e127247ef7e8c02498522c5e2e507cc8b39af278&l=28
,
Jul 3
,
Jul 5
Tentatively assigning to tschumann@.
,
Oct 24
|
||||
►
Sign in to add a comment |
||||
Comment 1 by treib@chromium.org
, May 11 2018Labels: -Pri-3 OS-Android OS-Chrome OS-Linux OS-Mac OS-Windows Pri-2
Status: Available (was: Untriaged)