"ProfileMainNetworkContext/NetworkContextConfigurationBrowserTest.Hsts/2" is flaky |
||||||
Issue description"ProfileMainNetworkContext/NetworkContextConfigurationBrowserTest.Hsts/2" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyUgsSBUZsYWtlIkdQcm9maWxlTWFpbk5ldHdvcmtDb250ZXh0L05ldHdvcmtDb250ZXh0Q29uZmlndXJhdGlvbkJyb3dzZXJUZXN0LkhzdHMvMgw. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
,
May 11 2018
Note: both ProfileMainNetworkContext/NetworkContextConfigurationBrowserTest.Hsts/1 and ProfileMainNetworkContext/NetworkContextConfigurationBrowserTest.Hsts/2 are flakily timing out, see dashboard: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=ProfileMainNetworkContext%2FNetworkContextConfigurationBrowserTest.Hsts
,
May 11 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/88935d1f4a3e132703ac2115c0358b76b3cc1711 commit 88935d1f4a3e132703ac2115c0358b76b3cc1711 Author: Max Morin <maxmorin@chromium.org> Date: Fri May 11 14:36:19 2018 Disable NetworkContextConfigurationBrowserTest.Hsts Revert failed, so I'm disabling the test. Tbr: mmenke No-Try: true Bug: 837776 , 842088 Change-Id: I5cd22fb63cb53ae85c99cb4b903c4c1143767c42 Reviewed-on: https://chromium-review.googlesource.com/1055508 Reviewed-by: Max Morin <maxmorin@chromium.org> Commit-Queue: Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#557873} [modify] https://crrev.com/88935d1f4a3e132703ac2115c0358b76b3cc1711/chrome/browser/net/network_context_configuration_browsertest.cc
,
May 11 2018
,
May 11 2018
Thanks for disabling the test! I'll remove the test today - sadly, I don't think there's a way to make testing this work reliably.
,
May 14 2018
,
May 16 2018
,
May 19 2018
,
May 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c1273ef38167e73d5bdb38c73aca7d67fd4632cd commit c1273ef38167e73d5bdb38c73aca7d67fd4632cd Author: Matt Menke <mmenke@chromium.org> Date: Sat May 19 00:45:21 2018 Selectively re-enable NetworkContextConfigurationBrowserTest.Hsts. What I believe is happening is that, when using the network service, we're killing the network service before it can write to disk, resulting in settings not being saved before restarting the browser and trying to load the saved state. Unfortunately, the browser process kills subprocesses on shutdown, rather than letting them run their BLOCK_SHUTDOWN tasks. This CL disables the test whenever there's an on-disk cache and the network service is enabled. Bug: 837776 , 820996 , 842088 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I80549906d3408b1a0c651475075959b83fb0dc03 Reviewed-on: https://chromium-review.googlesource.com/1054525 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by: Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#560123} [modify] https://crrev.com/c1273ef38167e73d5bdb38c73aca7d67fd4632cd/chrome/browser/net/network_context_configuration_browsertest.cc [modify] https://crrev.com/c1273ef38167e73d5bdb38c73aca7d67fd4632cd/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter
,
May 19 2018
I'm hoping that will take care of the flake. We'll see. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by Findit
, May 11 2018