Replace base::AtomicNumber<T> with std::atomic<T>
Replace base::AtomicNumber<T> with std::atomic<T> in V8
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/ff5bb7e5cef701cc35d79456665c8c32f4a92f12 commit ff5bb7e5cef701cc35d79456665c8c32f4a92f12 Author: Hannes Payer <hpayer@chromium.org> Date: Fri May 11 09:38:05 2018 [heap] Cleanup: Use std::atomic<T> instead of base::AtomicNumber<T> in concurrent marker. Bug: chromium:842083 Change-Id: I4ce2b58aa7fcafe7e886a3c80d3ddf7bfe3e4415 Reviewed-on: https://chromium-review.googlesource.com/1055389 Commit-Queue: Hannes Payer <hpayer@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#53120} [modify] https://crrev.com/ff5bb7e5cef701cc35d79456665c8c32f4a92f12/src/heap/concurrent-marking.cc [modify] https://crrev.com/ff5bb7e5cef701cc35d79456665c8c32f4a92f12/src/heap/concurrent-marking.h
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/8251c146648dd987d3f577553a10daed2297c29c commit 8251c146648dd987d3f577553a10daed2297c29c Author: Hannes Payer <hpayer@chromium.org> Date: Fri May 11 11:29:35 2018 [heap] Cleanup: Use std::atomic<T> instead of base::AtomicNumber<T> in sweeper. Bug: chromium:842083 Change-Id: Ided2d8542e4501250208dde6146f00da77410f48 Reviewed-on: https://chromium-review.googlesource.com/1054234 Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Hannes Payer <hpayer@chromium.org> Cr-Commit-Position: refs/heads/master@{#53121} [modify] https://crrev.com/8251c146648dd987d3f577553a10daed2297c29c/src/heap/sweeper.cc [modify] https://crrev.com/8251c146648dd987d3f577553a10daed2297c29c/src/heap/sweeper.h
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/3fc8937ed130983d8db285ab2213dce816fc3ebf commit 3fc8937ed130983d8db285ab2213dce816fc3ebf Author: Hannes Payer <hpayer@chromium.org> Date: Fri May 11 21:10:58 2018 [heap] Cleanup: Use std::atomic<T> instead of base::AtomicNumber<T> in heap. Bug: chromium:842083 Change-Id: Ic28d47df055277878cb8e066cd2276cedf06d3cf Reviewed-on: https://chromium-review.googlesource.com/1054074 Commit-Queue: Hannes Payer <hpayer@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#53134} [modify] https://crrev.com/3fc8937ed130983d8db285ab2213dce816fc3ebf/src/heap/heap-inl.h [modify] https://crrev.com/3fc8937ed130983d8db285ab2213dce816fc3ebf/src/heap/heap.cc [modify] https://crrev.com/3fc8937ed130983d8db285ab2213dce816fc3ebf/src/heap/heap.h
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/7032b91dc0d38b9f05863200b54d1c66c5ad6013 commit 7032b91dc0d38b9f05863200b54d1c66c5ad6013 Author: Hannes Payer <hpayer@chromium.org> Date: Mon May 28 14:18:07 2018 [heap] Cleanup: Use std::atomic<T> instead of base::AtomicNumber<T> in spaces. Bug: chromium:842083 Change-Id: Ic0cfd84d56f48e61711cdbb695178837e1570e21 Reviewed-on: https://chromium-review.googlesource.com/1073427 Commit-Queue: Hannes Payer <hpayer@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#53388} [modify] https://crrev.com/7032b91dc0d38b9f05863200b54d1c66c5ad6013/src/heap/spaces.cc [modify] https://crrev.com/7032b91dc0d38b9f05863200b54d1c66c5ad6013/src/heap/spaces.h
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/66e9596c144bf2a09dd8d8fd77fe16491f01b0f8 commit 66e9596c144bf2a09dd8d8fd77fe16491f01b0f8 Author: Hannes Payer <hpayer@chromium.org> Date: Tue May 29 10:33:53 2018 [heap] Cleanup: Use std::atomic<T> instead of base::AtomicNumber<T> in mark-compact. Bug: chromium:842083 Change-Id: Ie09b02bfe3fbc4f9ad2486843349d0f896b87b39 Reviewed-on: https://chromium-review.googlesource.com/1075532 Commit-Queue: Hannes Payer <hpayer@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#53401} [modify] https://crrev.com/66e9596c144bf2a09dd8d8fd77fe16491f01b0f8/src/heap/mark-compact.cc [modify] https://crrev.com/66e9596c144bf2a09dd8d8fd77fe16491f01b0f8/src/heap/mark-compact.h [modify] https://crrev.com/66e9596c144bf2a09dd8d8fd77fe16491f01b0f8/src/heap/spaces.h
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/39177148541a5eabe7812898bb2a156a18c290b8 commit 39177148541a5eabe7812898bb2a156a18c290b8 Author: Hannes Payer <hpayer@chromium.org> Date: Tue Jul 10 11:12:20 2018 Cleanup: Use std::atomic<T> instead of base::AtomicNumber<T> in isolate. Bug: chromium:842083 Change-Id: I015db53853c7da42c4879c791f437bf44eea7a00 Reviewed-on: https://chromium-review.googlesource.com/1130516 Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Hannes Payer <hpayer@chromium.org> Cr-Commit-Position: refs/heads/master@{#54348} [modify] https://crrev.com/39177148541a5eabe7812898bb2a156a18c290b8/src/isolate.cc [modify] https://crrev.com/39177148541a5eabe7812898bb2a156a18c290b8/src/isolate.h
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/49dbb393820cc2361b9e53875d773707c959664b commit 49dbb393820cc2361b9e53875d773707c959664b Author: Hannes Payer <hpayer@chromium.org> Date: Thu Jul 12 07:22:06 2018 Cleanup: Use std::atomic<T> instead of base::AtomicNumber<T> in TaskRunner. Bug: chromium:842083 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I6b3f60526718f782b075bd450282646d97f6f9b5 Reviewed-on: https://chromium-review.googlesource.com/1131124 Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Hannes Payer <hpayer@chromium.org> Cr-Commit-Position: refs/heads/master@{#54385} [modify] https://crrev.com/49dbb393820cc2361b9e53875d773707c959664b/test/inspector/task-runner.cc [modify] https://crrev.com/49dbb393820cc2361b9e53875d773707c959664b/test/inspector/task-runner.h
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/bb3b74eabee8bba56edd20aa977c27d10cafb80f commit bb3b74eabee8bba56edd20aa977c27d10cafb80f Author: Hannes Payer <hpayer@chromium.org> Date: Thu Jul 12 08:17:57 2018 Retire AtomicNumber. Bug: chromium:842083 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I9a8d8327bfbab95cf9bdddb096804b65270cdfed Reviewed-on: https://chromium-review.googlesource.com/1127944 Commit-Queue: Hannes Payer <hpayer@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#54388} [modify] https://crrev.com/bb3b74eabee8bba56edd20aa977c27d10cafb80f/src/base/atomic-utils.h [modify] https://crrev.com/bb3b74eabee8bba56edd20aa977c27d10cafb80f/src/cancelable-task.h [modify] https://crrev.com/bb3b74eabee8bba56edd20aa977c27d10cafb80f/src/isolate.cc [modify] https://crrev.com/bb3b74eabee8bba56edd20aa977c27d10cafb80f/src/profiler/cpu-profiler-inl.h [modify] https://crrev.com/bb3b74eabee8bba56edd20aa977c27d10cafb80f/src/profiler/cpu-profiler.cc [modify] https://crrev.com/bb3b74eabee8bba56edd20aa977c27d10cafb80f/src/profiler/cpu-profiler.h [modify] https://crrev.com/bb3b74eabee8bba56edd20aa977c27d10cafb80f/test/unittests/base/atomic-utils-unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/770ace0779889b94c284f76c5af8caadb0a67352 commit 770ace0779889b94c284f76c5af8caadb0a67352 Author: Hannes Payer <hpayer@chromium.org> Date: Thu Jul 12 08:20:12 2018 [heap] Cleanup: Use std::atomic<T> instead of base::AtomicValue<T> in heap/*. Bug: chromium:842083 Change-Id: Idc04f9ddea326df4ac48a8c58321620660b21549 Reviewed-on: https://chromium-review.googlesource.com/1129520 Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Hannes Payer <hpayer@chromium.org> Cr-Commit-Position: refs/heads/master@{#54389} [modify] https://crrev.com/770ace0779889b94c284f76c5af8caadb0a67352/src/heap/concurrent-marking.cc [modify] https://crrev.com/770ace0779889b94c284f76c5af8caadb0a67352/src/heap/concurrent-marking.h [modify] https://crrev.com/770ace0779889b94c284f76c5af8caadb0a67352/src/heap/heap.cc [modify] https://crrev.com/770ace0779889b94c284f76c5af8caadb0a67352/src/heap/heap.h [modify] https://crrev.com/770ace0779889b94c284f76c5af8caadb0a67352/src/heap/item-parallel-job.h [modify] https://crrev.com/770ace0779889b94c284f76c5af8caadb0a67352/src/heap/mark-compact.cc [modify] https://crrev.com/770ace0779889b94c284f76c5af8caadb0a67352/src/heap/spaces.cc [modify] https://crrev.com/770ace0779889b94c284f76c5af8caadb0a67352/src/heap/spaces.h [modify] https://crrev.com/770ace0779889b94c284f76c5af8caadb0a67352/src/heap/sweeper.cc [modify] https://crrev.com/770ace0779889b94c284f76c5af8caadb0a67352/src/heap/sweeper.h
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/d20c14149cdc5c4222eec1b7ea4fc00607b9fada commit d20c14149cdc5c4222eec1b7ea4fc00607b9fada Author: Maya Lekova <mslekova@chromium.org> Date: Thu Jul 12 10:55:08 2018 Revert "[heap] Cleanup: Use std::atomic<T> instead of base::AtomicValue<T> in heap/*." This reverts commit 770ace0779889b94c284f76c5af8caadb0a67352. Reason for revert: Breaking the V8 Arm and V8 Arm - debug builds https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Arm%20-%20debug/7260 Original change's description: > [heap] Cleanup: Use std::atomic<T> instead of base::AtomicValue<T> in heap/*. > > Bug: chromium:842083 > Change-Id: Idc04f9ddea326df4ac48a8c58321620660b21549 > Reviewed-on: https://chromium-review.googlesource.com/1129520 > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Commit-Queue: Hannes Payer <hpayer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54389} TBR=ulan@chromium.org,hpayer@chromium.org,mlippautz@chromium.org Change-Id: I108bc5386ea825c2700f9b830b85a1ca8c10bf4b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:842083 Reviewed-on: https://chromium-review.googlesource.com/1134966 Reviewed-by: Maya Lekova <mslekova@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#54398} [modify] https://crrev.com/d20c14149cdc5c4222eec1b7ea4fc00607b9fada/src/heap/concurrent-marking.cc [modify] https://crrev.com/d20c14149cdc5c4222eec1b7ea4fc00607b9fada/src/heap/concurrent-marking.h [modify] https://crrev.com/d20c14149cdc5c4222eec1b7ea4fc00607b9fada/src/heap/heap.cc [modify] https://crrev.com/d20c14149cdc5c4222eec1b7ea4fc00607b9fada/src/heap/heap.h [modify] https://crrev.com/d20c14149cdc5c4222eec1b7ea4fc00607b9fada/src/heap/item-parallel-job.h [modify] https://crrev.com/d20c14149cdc5c4222eec1b7ea4fc00607b9fada/src/heap/mark-compact.cc [modify] https://crrev.com/d20c14149cdc5c4222eec1b7ea4fc00607b9fada/src/heap/spaces.cc [modify] https://crrev.com/d20c14149cdc5c4222eec1b7ea4fc00607b9fada/src/heap/spaces.h [modify] https://crrev.com/d20c14149cdc5c4222eec1b7ea4fc00607b9fada/src/heap/sweeper.cc [modify] https://crrev.com/d20c14149cdc5c4222eec1b7ea4fc00607b9fada/src/heap/sweeper.h
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/a1ef54bb6326b5a3f3362b7b520244c7ab304a36 commit a1ef54bb6326b5a3f3362b7b520244c7ab304a36 Author: Hannes Payer <hpayer@chromium.org> Date: Fri Jul 13 17:16:34 2018 [heap] Cleanup: Use std::atomic<T> instead of base::AtomicValue<T> in heap/*. Bug: chromium:842083 Change-Id: I7f3d7cb64c1263e081d1f9bd36939aaf1a0e3da8 Reviewed-on: https://chromium-review.googlesource.com/1135322 Commit-Queue: Hannes Payer <hpayer@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#54443} [modify] https://crrev.com/a1ef54bb6326b5a3f3362b7b520244c7ab304a36/src/heap/concurrent-marking.cc [modify] https://crrev.com/a1ef54bb6326b5a3f3362b7b520244c7ab304a36/src/heap/concurrent-marking.h [modify] https://crrev.com/a1ef54bb6326b5a3f3362b7b520244c7ab304a36/src/heap/heap.cc [modify] https://crrev.com/a1ef54bb6326b5a3f3362b7b520244c7ab304a36/src/heap/heap.h [modify] https://crrev.com/a1ef54bb6326b5a3f3362b7b520244c7ab304a36/src/heap/item-parallel-job.h [modify] https://crrev.com/a1ef54bb6326b5a3f3362b7b520244c7ab304a36/src/heap/mark-compact.cc [modify] https://crrev.com/a1ef54bb6326b5a3f3362b7b520244c7ab304a36/src/heap/spaces.cc [modify] https://crrev.com/a1ef54bb6326b5a3f3362b7b520244c7ab304a36/src/heap/spaces.h [modify] https://crrev.com/a1ef54bb6326b5a3f3362b7b520244c7ab304a36/src/heap/sweeper.cc [modify] https://crrev.com/a1ef54bb6326b5a3f3362b7b520244c7ab304a36/src/heap/sweeper.h
Comment 1 by hpayer@chromium.org
, May 11 2018