Re-enable QR code EG tests |
||||
Issue descriptionSome EG tests are failing on iOS 10 simulators phone. I can reproduce locally. I am not sure why it is happening, it started failing between https://chrome-internal.googlesource.com/chrome/ios_internal/+/87b5d0770d86d8b41602bd8d8f6bd7dde54e3eee and https://chrome-internal.googlesource.com/chrome/ios_internal/+/407cfd024c85facc80faa1fdf08c00dc0028dc93 but I don't see any change that could have caused it. The problem is that the omnibox is not loosing focus when the QR code is presented (i.e. didResignFirstResponder is not called). https://uberchromegw.corp.google.com/i/internal.bling.main/builders/iphone10-simulator/builds/12122 Assigning to Olivier as you are owner of the QR code directory. I am disabling the tests to fix the tree, please re-enable them once fixed.
,
May 14 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e53c9ee5b3fce6d95aa91b33ff1af4b7fb1a939d commit e53c9ee5b3fce6d95aa91b33ff1af4b7fb1a939d Author: Olivier Robin <olivierrobin@chromium.org> Date: Mon May 14 11:25:54 2018 Always unfocus omnibox when displaying QRScanner. On iOS10, when dismissing the keyboard, there is a short time when the scroll view containing the suggestion is offset. This cause the omnibox to not be unfocused automatically because of the test in https://cs.chromium.org/chromium/src/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_view_controller.mm?l=516 Fix the issue by always unfocus the omnibox when displaying QR scanner. Bug: 842072 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ie94884a18335753e919c0cd974c26e4a53abac8b Reviewed-on: https://chromium-review.googlesource.com/1055394 Reviewed-by: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#558259} [modify] https://crrev.com/e53c9ee5b3fce6d95aa91b33ff1af4b7fb1a939d/ios/chrome/browser/ui/qr_scanner/BUILD.gn [modify] https://crrev.com/e53c9ee5b3fce6d95aa91b33ff1af4b7fb1a939d/ios/chrome/browser/ui/qr_scanner/qr_scanner_legacy_coordinator.mm [modify] https://crrev.com/e53c9ee5b3fce6d95aa91b33ff1af4b7fb1a939d/ios/chrome/browser/ui/qr_scanner/qr_scanner_view_controller_egtest.mm
,
May 24 2018
,
May 24 2018
[Auto-generated comment by a script] We noticed that this issue is targeted for M-68; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-68 label, otherwise remove Merge-TBD label. Thanks.
,
May 24 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by bugdroid1@chromium.org
, May 11 2018