New issue
Advanced search Search tips

Issue 842070 link

Starred by 3 users

Issue metadata

Status: WontFix
Owner:
Closed: Jun 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Extension popup often cropped by 1/2'' square

Reported by shuto...@gmail.com, May 11 2018

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/66.0.3359.139 Safari/537.36

Steps to reproduce the problem:
1. Install Dark Reader extension on Chrome for Mac.
2. Switch tabs and click extension icon multiple times.

What is the expected behavior?
Popup size corresponds with declared in CSS.

What went wrong?
In 10% cases the popup suddenly becomes cropped before the open animation is finished. Chrome inspector states the root computed size is much bigger.

Did this work before? Yes 

Chrome version: 66.0.3359.139  Channel: stable
OS Version: OS X 10.13.4
Flash Version:
 
Screen Shot 2018-05-11 at 10.38.17.png
14.0 KB View Download
chrome-66-macos-popup-cropped.mov
27.3 MB Download

Comment 1 by woxxom@gmail.com, May 11 2018

This is a known issue already reported here and fixed in Chrome 67, if I'm not mistaken.

Comment 2 by meh...@chromium.org, May 11 2018

Components: -UI Platform>Extensions UI>Browser>Toolbar
Labels: Needs-Bisect Needs-Triage-M66
Labels: -Pri-2 -Needs-Bisect hasbisect-per-revision Triaged-ET M-66 FoundIn-66 Target-66 RegressedIn-66 Pri-1
Owner: robliao@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce the issue on reported version 66.0.3359.139 and latest stable# 66.0.3359.170 and the same is not seen on Beta# 67.0.3396.40 and latest canary 68.0.3429.0 using Mac 10.12.6, hence providing reverse bisect info
Note: Issue is not applicable to Windows 10 & Ubuntu 14.04
Reverse Bisect Info:
================
Last Bad build: 67.0.3362.0
First Good build: 67.0.3364.0

You are probably looking for a change made after 540879 (known good), but no later than 540880 (first known bad).
https://chromium.googlesource.com/chromium/src/+log/7bea94e12121bc43c45d68779803b5628f7ebbf1..a0259b3ae165b0673416f02848bed75082d639f4
Reviewed-on: https://chromium-review.googlesource.com/941883

@Robert Liao: Please confirm the issue and help in re-assigning if it is not related to your change, please help in merging it to M-66 if applicable
Adding ReleaseBlock-Stable for M-66, feel free to remove it if not applicable.

Thanks!
Labels: Proj-MacViews

Comment 6 by shuto...@gmail.com, May 30 2018

On Chrome 67 there is no popup animation at all. I've seen it in Canary, but decided to not report as far as it seemed so obvious.
chrome-67-no-popup-animation.mov
6.0 MB View Download

Comment 7 by shuto...@gmail.com, May 30 2018

I've discovered related issues
https://bugs.chromium.org/p/chromium/issues/detail?id=428044
https://bugs.chromium.org/p/chromium/issues/detail?id=813371

In my case I'm dynamically adding adding borders at left at right due to borders inconsistency per Chrome version and operating system https://bugs.chromium.org/p/chromium/issues/detail?id=750419

I would be glad to represent my vision of how the popup should animate.
The popup animations has been removed with the move to the new UI Platform. Is my interpretation correct that this is no longer an issue on M67?
Labels: -Pri-1 Pri-2
Shows up correctly near tip of tree. Waiting for feedback and will reelevate the priority if necessary.

Comment 10 by shuto...@gmail.com, May 31 2018

So, here is a chronology as far as I understand:

1. Bug with blurred extension popup was found https://bugs.chromium.org/p/chromium/issues/detail?id=824963
2. The quick solution for 67 stable release was to revert the whole work on popups for several months, both for Chrome and Windows.
3. Now there is no popup animation on Mac, horizontal popup borders appear on Windows https://bugs.chromium.org/p/chromium/issues/detail?id=750419

So, I guess, that the work on popups will be continued, animation will be enabled and the bug with cropped content will appear again. Please, let us know when it happens, because I would like to submit some more popup animation issues for Mac and Windows.
In the near term, there will not be a resize animation for the popup dialog. Having said that, is there a version of your extension that demonstrates the reported bug?
@robliao No, I cannot reproduce it.
Status: WontFix (was: Assigned)
I'm going to mark this as WontFix then per #12 as there is no further work to be done here. If there is, feel free to comment/reopen.

Sign in to add a comment