For duplex printing, need to be able to select long/short edge for flipping
Reported by
markus@chromium.org,
May 11 2018
|
|||||||
Issue descriptionUserAgent: Mozilla/5.0 (X11; CrOS x86_64 10635.0.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/68.0.3416.0 Safari/537.36 Platform: 10635.0.0 (Official Build) dev-channel eve Steps to reproduce the problem: It's great that ChromeOS now supports duplex printing with some printers. But depending on the file that is being printed, results can be unexpected. There should be an option to determine whether the pages are flipped on the long or the short edge of the paper. An educated guess can be made, if the user changes from portrait to landscape; but that's not always a reliable indicator. What is the expected behavior? What went wrong? Did this work before? N/A Chrome version: 68.0.3416.0 Channel: dev OS Version: 10635.0.0 Flash Version:
,
Jun 5 2018
,
Jun 22 2018
,
Jun 22 2018
,
Jun 26 2018
FYI, there's also bug 169120 for print preview in general. Getting the CUPS backend ready separately here is a good start.
,
Jul 9
Looks like we need to do 3 things to get this supported in the backend. 1) Add fields for the duplex modes a printer supports in PrinterSemanticCapsAndDefaults https://cs.chromium.org/chromium/src/printing/backend/print_backend.h?rcl=7b9a39fe9a449fbf02b013254be8ec6f45103b2c&l=41 2) Record this information for CUPS backends https://cs.chromium.org/chromium/src/printing/backend/cups_ipp_util.cc?rcl=18d8323d387ae4d87adacb459c5c74e08c728099&l=322 3) Add the field to PrinterSettings https://cs.chromium.org/chromium/src/printing/print_settings.h?rcl=af8095de02ad6e6b5dff6ffdcb05cef7ffa4a312&l=36 4) Populate the field in PrinterSettings https://cs.chromium.org/chromium/src/printing/print_settings_conversion.cc?rcl=050ec57119ffed2e898b07bd99e30b0188365118&l=78 5) Ensure the value is encoded as a CUPS option when found in PrinterSettings https://cs.chromium.org/chromium/src/printing/printing_context_chromeos.cc?rcl=3eafc7f1009b64dfed21bac94e133e1629e1c8d3&l=97 Separately, the PrintPreview UI needs to be modified so that the correct duplex mode is chosen. Initially, this can be LONG_EDGE in portrait and SHORT_EDGE in landscape.
,
Jul 10
#6 Sean, PTAL at crrev.com/c/1113189 which is an attempt at some of those things.
,
Aug 14
,
Sep 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b043f2afb3bd1d4cbe3f86140c7acbe819f98ec8 commit b043f2afb3bd1d4cbe3f86140c7acbe819f98ec8 Author: Vladislav Kuzkokov <vkuzkokov@chromium.org> Date: Mon Sep 10 11:15:16 2018 Read duplex modes exactly. The previous version just checked whether long edge duplex mode is available. Bug: 842063 Change-Id: Ia36246bdb1bedad04a03c592dd4622264413c7d8 Reviewed-on: https://chromium-review.googlesource.com/1113189 Commit-Queue: Vladislav Kuzkokov <vkuzkokov@chromium.org> Reviewed-by: Sean Kau <skau@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#589884} [modify] https://crrev.com/b043f2afb3bd1d4cbe3f86140c7acbe819f98ec8/chrome/browser/chromeos/arc/print/print_struct_traits.cc [modify] https://crrev.com/b043f2afb3bd1d4cbe3f86140c7acbe819f98ec8/chrome/common/chrome_utility_printing_messages.h [modify] https://crrev.com/b043f2afb3bd1d4cbe3f86140c7acbe819f98ec8/components/printing/common/cloud_print_cdd_conversion.cc [modify] https://crrev.com/b043f2afb3bd1d4cbe3f86140c7acbe819f98ec8/printing/BUILD.gn [modify] https://crrev.com/b043f2afb3bd1d4cbe3f86140c7acbe819f98ec8/printing/backend/cups_helper.cc [modify] https://crrev.com/b043f2afb3bd1d4cbe3f86140c7acbe819f98ec8/printing/backend/cups_helper_unittest.cc [modify] https://crrev.com/b043f2afb3bd1d4cbe3f86140c7acbe819f98ec8/printing/backend/cups_ipp_util.cc [modify] https://crrev.com/b043f2afb3bd1d4cbe3f86140c7acbe819f98ec8/printing/backend/cups_ipp_util_unittest.cc [modify] https://crrev.com/b043f2afb3bd1d4cbe3f86140c7acbe819f98ec8/printing/backend/print_backend.cc [modify] https://crrev.com/b043f2afb3bd1d4cbe3f86140c7acbe819f98ec8/printing/backend/print_backend.h [modify] https://crrev.com/b043f2afb3bd1d4cbe3f86140c7acbe819f98ec8/printing/backend/print_backend_win.cc
,
Sep 13
,
Nov 5
,
Nov 12
Issue 904526 has been merged into this issue. |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by shihuis@google.com
, Jun 1 2018Owner: weifangsun@chromium.org