New issue
Advanced search Search tips

Issue 842060 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

inputcontrol: drop support for X (e.g. tpcontrol_xinput)

Project Member Reported by vapier@chromium.org, May 11 2018

Issue description

is the X code still used by inputcontrol ?  doesn't seem like it as it all relies on an X server being active.

i'd like to kill it as it's the only reason debugd still mounts a /debugd/ path.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/inputcontrol/+/8826acba1c4e13b6318ae6d1d4b49633d1b55aba

commit 8826acba1c4e13b6318ae6d1d4b49633d1b55aba
Author: Mike Frysinger <vapier@chromium.org>
Date: Mon May 14 16:14:47 2018

drop support for X

We aren't using X anywhere in the system anymore, so drop all the
scripts/logic that only works with it.

BUG= chromium:842060 
TEST=precq passes

Change-Id: I63b591fa0daf190e43b3d749377bffdcad8789d3
Reviewed-on: https://chromium-review.googlesource.com/1055307
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Chung-yih Wang <cywang@chromium.org>

[delete] https://crrev.com/ae0b15dc322bab9bf6d7c4fcd5f77d488766a275/mouse.conf
[delete] https://crrev.com/ae0b15dc322bab9bf6d7c4fcd5f77d488766a275/device_added
[delete] https://crrev.com/ae0b15dc322bab9bf6d7c4fcd5f77d488766a275/tpcontrol_xinput
[delete] https://crrev.com/ae0b15dc322bab9bf6d7c4fcd5f77d488766a275/touch_noise_feedback
[delete] https://crrev.com/ae0b15dc322bab9bf6d7c4fcd5f77d488766a275/cmt_feedback
[modify] https://crrev.com/8826acba1c4e13b6318ae6d1d4b49633d1b55aba/Makefile
[delete] https://crrev.com/ae0b15dc322bab9bf6d7c4fcd5f77d488766a275/evdev_feedback
[delete] https://crrev.com/ae0b15dc322bab9bf6d7c4fcd5f77d488766a275/toggle_touch_event_logging
[modify] https://crrev.com/8826acba1c4e13b6318ae6d1d4b49633d1b55aba/99-inputcontrol.rules
[delete] https://crrev.com/ae0b15dc322bab9bf6d7c4fcd5f77d488766a275/xinput.sh
[delete] https://crrev.com/ae0b15dc322bab9bf6d7c4fcd5f77d488766a275/common
[delete] https://crrev.com/ae0b15dc322bab9bf6d7c4fcd5f77d488766a275/tpcontrol_synclient
[delete] https://crrev.com/ae0b15dc322bab9bf6d7c4fcd5f77d488766a275/mousecontrol
[delete] https://crrev.com/ae0b15dc322bab9bf6d7c4fcd5f77d488766a275/send_input_metrics
[delete] https://crrev.com/ae0b15dc322bab9bf6d7c4fcd5f77d488766a275/tpcontrol
[delete] https://crrev.com/ae0b15dc322bab9bf6d7c4fcd5f77d488766a275/input-metrics.conf
[delete] https://crrev.com/ae0b15dc322bab9bf6d7c4fcd5f77d488766a275/inputcontrol

Project Member

Comment 2 by bugdroid1@chromium.org, May 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/16b0ee6daa6b2a66aa8b880bbab2e4d442742752

commit 16b0ee6daa6b2a66aa8b880bbab2e4d442742752
Author: Mike Frysinger <vapier@chromium.org>
Date: Wed May 16 12:08:39 2018

debugd: drop /debugd mount

The only thing using this was inputcontrol, and that code is all
dead now, so drop the /debugd mount.

BUG= chromium:842060 
TEST=precq passes

Change-Id: I741c0db5845c080a313b710d50b6cd8c594bf6f0
Reviewed-on: https://chromium-review.googlesource.com/1054592
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>

[modify] https://crrev.com/16b0ee6daa6b2a66aa8b880bbab2e4d442742752/debugd/src/main.cc

Project Member

Comment 3 by bugdroid1@chromium.org, May 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/49f20338dc4f7d9ec36edf67ddae89402f45a4dc

commit 49f20338dc4f7d9ec36edf67ddae89402f45a4dc
Author: Mike Frysinger <vapier@chromium.org>
Date: Fri May 18 17:05:22 2018

debugd: drop /debugd mount

The only thing using this was inputcontrol, and that code is all
dead now, so drop the /debugd mount.

BUG= chromium:842060 
TEST=precq passes
CQ-DEPEND=CL:1054592

Change-Id: I097454c0370904f1330c95467ac0db37f5554ddc
Reviewed-on: https://chromium-review.googlesource.com/1055309
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>

[modify] https://crrev.com/49f20338dc4f7d9ec36edf67ddae89402f45a4dc/chromeos-base/debugd/debugd-9999.ebuild

Project Member

Comment 4 by bugdroid1@chromium.org, May 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/2ba9b2c094f0fe6f55381ea3f330ee26dc8c336e

commit 2ba9b2c094f0fe6f55381ea3f330ee26dc8c336e
Author: Mike Frysinger <vapier@chromium.org>
Date: Tue May 22 13:17:13 2018

inputcontrol: drop support for X

We don't have any systems still using this X logic, and it's holding
up other cleanups in the system.

BUG= chromium:842060 
TEST=precq passes

Change-Id: Ib3f863e74cd6714c28a12a197c72e58f0aeeb402
Reviewed-on: https://chromium-review.googlesource.com/1054591
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Chung-yih Wang <cywang@chromium.org>

[modify] https://crrev.com/2ba9b2c094f0fe6f55381ea3f330ee26dc8c336e/chromeos-base/inputcontrol/inputcontrol-9999.ebuild

Comment 5 by vapier@chromium.org, May 22 2018

Owner: vapier@chromium.org
Status: Fixed (was: Available)
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/b2fcac21feca5242b395dfae6055686dfc7eba93

commit b2fcac21feca5242b395dfae6055686dfc7eba93
Author: Mike Frysinger <vapier@chromium.org>
Date: Tue Jun 05 00:23:36 2018

debugd: drop old touchpad entries

These programs have been dropped from the build,
so stop trying to run them to gather log data.

BUG= chromium:842060 
TEST=precq passes

Change-Id: I56c7fe7436673eff6e14b1e4c1ac93485e5317a0
Reviewed-on: https://chromium-review.googlesource.com/1079259
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Chung-yih Wang <cywang@chromium.org>

[modify] https://crrev.com/b2fcac21feca5242b395dfae6055686dfc7eba93/debugd/src/log_tool.cc

Project Member

Comment 7 by bugdroid1@chromium.org, Aug 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/fed8307ef0975df8dd3bf2d319de82e82f8b18af

commit fed8307ef0975df8dd3bf2d319de82e82f8b18af
Author: Mike Frysinger <vapier@chromium.org>
Date: Wed Aug 08 17:24:55 2018

crosh: drop support for inputcontrol

We dropped this util in CL:1055307, so drop the code that calls it too.

BUG= chromium:842060 
TEST=precq passes

Change-Id: I060dc66b6eb8286f6217f1946ec738bcc469fd43
Reviewed-on: https://chromium-review.googlesource.com/1166430
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Chung-yih Wang <cywang@chromium.org>

[modify] https://crrev.com/fed8307ef0975df8dd3bf2d319de82e82f8b18af/crosh/crosh

Sign in to add a comment