New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 842046 link

Starred by 2 users
Status: Fixed
Owner:
lijeffrey@chromium.org
Closed: Jun 2018
Cc:
█ robert...@chromium.org
chanli@chromium.org
lijeffrey@chromium.org
liaoyuke@chromium.org
st...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

[Findit] Flake Analyzer - Builders may not have 500 builds available

Project Member Reported by lijeffrey@chromium.org, May 11 2018 
Cap lower bound build at half upper bound build if 500 builds aren't available
Project Member

Comment 1 by bugdroid1@chromium.org, May 14 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/b5781ec722e8edd74205d230ddad658872cb68c0

commit b5781ec722e8edd74205d230ddad658872cb68c0
Author: Jeffrey Li <lijeffrey@chromium.org>
Date: Mon May 14 16:49:49 2018

[Findit] Flake Analyzer - Cap lower bound at half of upper bound for builders with few builds

Some newer builders only have a handful of builds and build 0 is not available as the lower
bound. Instead of the default 500 window, use half of the upper bound in case 500 aren't available
yet.

Bug:  842046 
Change-Id: I6c481721deac71f455bca81f31765b070cf3d7e1
Reviewed-on: https://chromium-review.googlesource.com/1054988
Commit-Queue: Jeffrey Li <lijeffrey@chromium.org>
Reviewed-by: Shuotao Gao <stgao@chromium.org>

[modify] https://crrev.com/b5781ec722e8edd74205d230ddad658872cb68c0/appengine/findit/services/step_util.py
[modify] https://crrev.com/b5781ec722e8edd74205d230ddad658872cb68c0/appengine/findit/services/test/step_util_test.py

Comment 2 by lijeffrey@chromium.org, Jun 6 2018

Status: Fixed (was: Assigned)
Not a true fix, but a temporary workaround

Comment 3 by lijeffrey@chromium.org, Jun 6 2018 

The true fix would be to adapt Findit to use the new build indexing service tracked in  issue 850224
►

Sign in to add a comment