New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 842042 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 22
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Task
Proj-XR

Blocking:
issue 842025



Sign in to add a comment

Call VRDisplayHost::RequestSession() from WebVR

Project Member Reported by ddorwin@chromium.org, May 11 2018

Issue description

https://crrev.com/c/1046107 adds RequestSession() to VRDisplayHost but only calls it for WebXR. The comment says it must be called before other methods, but it is not called from WebVR.

To satisfy the requirement, we should at least call it before the VRDisplay is used for anything. This also makes sense because a VRDisplay essentially always has a non-exclusive session.

To satisfy the requirement, we should at least call it from VRController::OnDisplayConnected(), which will ensure it is called before the application has an opportunity to cause those other methods to be called. This also makes sense because a VRDisplay essentially always has a non-exclusive session.

When RequestSession() is updated to take information about the session type being requested, we will also need to call it from requestPresent().
 
Labels: XR-Device
Owner: offenwanger@chromium.org
Labels: -M-68 M-69
Status: Started (was: Available)
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5d3c459ebda2daf3276b2f278bd2cc3a355d6cfc

commit 5d3c459ebda2daf3276b2f278bd2cc3a355d6cfc
Author: Anna Offenwanger <offenwanger@chromium.org>
Date: Thu Jun 14 21:36:32 2018

Merging WebVR 1.1 RequestPresent into WebXR RequestSession

In the WebVR 1.1 spec, the blink code was informed about devices then sent requests
for pipelines to those devices via the mojo interfaces. In the WebXR spec, the
decision about which device to use is left up to the browser, and not decided
until the pipline request has been made. This CL moves the blink<->device interface
pointers from being call parameters to being return parameters to better align
with WebXR.
As WebVR is being deprecated, as much of the old VR code as is possible
has been cleaned out.

Bug:  842042 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_vr
Change-Id: I67da418829c05479eb3b2a6c5ef1633d8da92564
Reviewed-on: https://chromium-review.googlesource.com/1080967
Commit-Queue: Bill Orr <billorr@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Ian Vollick <vollick@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Reviewed-by: Bill Orr <billorr@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567430}
[modify] https://crrev.com/5d3c459ebda2daf3276b2f278bd2cc3a355d6cfc/chrome/browser/android/vr/arcore_device/arcore_device.cc
[modify] https://crrev.com/5d3c459ebda2daf3276b2f278bd2cc3a355d6cfc/chrome/browser/android/vr/arcore_device/arcore_device.h
[modify] https://crrev.com/5d3c459ebda2daf3276b2f278bd2cc3a355d6cfc/chrome/browser/android/vr/arcore_device/arcore_gl.cc
[modify] https://crrev.com/5d3c459ebda2daf3276b2f278bd2cc3a355d6cfc/chrome/browser/android/vr/arcore_device/arcore_gl.h
[modify] https://crrev.com/5d3c459ebda2daf3276b2f278bd2cc3a355d6cfc/chrome/browser/android/vr/gl_browser_interface.h
[modify] https://crrev.com/5d3c459ebda2daf3276b2f278bd2cc3a355d6cfc/chrome/browser/android/vr/vr_gl_thread.cc
[modify] https://crrev.com/5d3c459ebda2daf3276b2f278bd2cc3a355d6cfc/chrome/browser/android/vr/vr_gl_thread.h
[modify] https://crrev.com/5d3c459ebda2daf3276b2f278bd2cc3a355d6cfc/chrome/browser/android/vr/vr_shell.cc
[modify] https://crrev.com/5d3c459ebda2daf3276b2f278bd2cc3a355d6cfc/chrome/browser/android/vr/vr_shell.h
[modify] https://crrev.com/5d3c459ebda2daf3276b2f278bd2cc3a355d6cfc/chrome/browser/android/vr/vr_shell_delegate.cc
[modify] https://crrev.com/5d3c459ebda2daf3276b2f278bd2cc3a355d6cfc/chrome/browser/android/vr/vr_shell_delegate.h
[modify] https://crrev.com/5d3c459ebda2daf3276b2f278bd2cc3a355d6cfc/chrome/browser/android/vr/vr_shell_gl.cc
[modify] https://crrev.com/5d3c459ebda2daf3276b2f278bd2cc3a355d6cfc/chrome/browser/android/vr/vr_shell_gl.h
[modify] https://crrev.com/5d3c459ebda2daf3276b2f278bd2cc3a355d6cfc/chrome/browser/vr/service/browser_xr_device.cc
[modify] https://crrev.com/5d3c459ebda2daf3276b2f278bd2cc3a355d6cfc/chrome/browser/vr/service/browser_xr_device.h
[modify] https://crrev.com/5d3c459ebda2daf3276b2f278bd2cc3a355d6cfc/chrome/browser/vr/service/vr_display_host.cc
[modify] https://crrev.com/5d3c459ebda2daf3276b2f278bd2cc3a355d6cfc/chrome/browser/vr/service/vr_display_host.h
[modify] https://crrev.com/5d3c459ebda2daf3276b2f278bd2cc3a355d6cfc/device/vr/android/gvr/gvr_delegate_provider.h
[modify] https://crrev.com/5d3c459ebda2daf3276b2f278bd2cc3a355d6cfc/device/vr/android/gvr/gvr_device.cc
[modify] https://crrev.com/5d3c459ebda2daf3276b2f278bd2cc3a355d6cfc/device/vr/android/gvr/gvr_device.h
[modify] https://crrev.com/5d3c459ebda2daf3276b2f278bd2cc3a355d6cfc/device/vr/oculus/oculus_device.cc
[modify] https://crrev.com/5d3c459ebda2daf3276b2f278bd2cc3a355d6cfc/device/vr/oculus/oculus_device.h
[modify] https://crrev.com/5d3c459ebda2daf3276b2f278bd2cc3a355d6cfc/device/vr/oculus/oculus_render_loop.cc
[modify] https://crrev.com/5d3c459ebda2daf3276b2f278bd2cc3a355d6cfc/device/vr/oculus/oculus_render_loop.h
[modify] https://crrev.com/5d3c459ebda2daf3276b2f278bd2cc3a355d6cfc/device/vr/openvr/openvr_device.cc
[modify] https://crrev.com/5d3c459ebda2daf3276b2f278bd2cc3a355d6cfc/device/vr/openvr/openvr_device.h
[modify] https://crrev.com/5d3c459ebda2daf3276b2f278bd2cc3a355d6cfc/device/vr/openvr/openvr_render_loop.cc
[modify] https://crrev.com/5d3c459ebda2daf3276b2f278bd2cc3a355d6cfc/device/vr/openvr/openvr_render_loop.h
[modify] https://crrev.com/5d3c459ebda2daf3276b2f278bd2cc3a355d6cfc/device/vr/orientation/orientation_device.cc
[modify] https://crrev.com/5d3c459ebda2daf3276b2f278bd2cc3a355d6cfc/device/vr/orientation/orientation_device.h
[modify] https://crrev.com/5d3c459ebda2daf3276b2f278bd2cc3a355d6cfc/device/vr/public/mojom/vr_service.mojom
[modify] https://crrev.com/5d3c459ebda2daf3276b2f278bd2cc3a355d6cfc/device/vr/test/fake_vr_device.cc
[modify] https://crrev.com/5d3c459ebda2daf3276b2f278bd2cc3a355d6cfc/device/vr/test/fake_vr_device.h
[modify] https://crrev.com/5d3c459ebda2daf3276b2f278bd2cc3a355d6cfc/device/vr/test/mock_vr_display_impl.cc
[modify] https://crrev.com/5d3c459ebda2daf3276b2f278bd2cc3a355d6cfc/device/vr/test/mock_vr_display_impl.h
[modify] https://crrev.com/5d3c459ebda2daf3276b2f278bd2cc3a355d6cfc/device/vr/vr_device.h
[modify] https://crrev.com/5d3c459ebda2daf3276b2f278bd2cc3a355d6cfc/device/vr/vr_device_base.cc
[modify] https://crrev.com/5d3c459ebda2daf3276b2f278bd2cc3a355d6cfc/device/vr/vr_device_base.h
[modify] https://crrev.com/5d3c459ebda2daf3276b2f278bd2cc3a355d6cfc/device/vr/vr_device_base_unittest.cc
[modify] https://crrev.com/5d3c459ebda2daf3276b2f278bd2cc3a355d6cfc/device/vr/vr_display_impl.cc
[modify] https://crrev.com/5d3c459ebda2daf3276b2f278bd2cc3a355d6cfc/device/vr/vr_display_impl.h
[modify] https://crrev.com/5d3c459ebda2daf3276b2f278bd2cc3a355d6cfc/device/vr/vr_display_impl_unittest.cc
[modify] https://crrev.com/5d3c459ebda2daf3276b2f278bd2cc3a355d6cfc/third_party/WebKit/LayoutTests/vr/resources/mock-vr-service.js
[modify] https://crrev.com/5d3c459ebda2daf3276b2f278bd2cc3a355d6cfc/third_party/WebKit/LayoutTests/xr/resources/xr-device-mocking.js
[modify] https://crrev.com/5d3c459ebda2daf3276b2f278bd2cc3a355d6cfc/third_party/WebKit/LayoutTests/xr/xrDevice_requestSession_exclusive_unsupported.html
[modify] https://crrev.com/5d3c459ebda2daf3276b2f278bd2cc3a355d6cfc/third_party/blink/renderer/modules/vr/vr_display.cc
[modify] https://crrev.com/5d3c459ebda2daf3276b2f278bd2cc3a355d6cfc/third_party/blink/renderer/modules/vr/vr_display.h
[modify] https://crrev.com/5d3c459ebda2daf3276b2f278bd2cc3a355d6cfc/third_party/blink/renderer/modules/xr/xr_device.cc
[modify] https://crrev.com/5d3c459ebda2daf3276b2f278bd2cc3a355d6cfc/third_party/blink/renderer/modules/xr/xr_device.h
[modify] https://crrev.com/5d3c459ebda2daf3276b2f278bd2cc3a355d6cfc/third_party/blink/renderer/modules/xr/xr_frame_provider.cc
[modify] https://crrev.com/5d3c459ebda2daf3276b2f278bd2cc3a355d6cfc/third_party/blink/renderer/modules/xr/xr_frame_provider.h
[modify] https://crrev.com/5d3c459ebda2daf3276b2f278bd2cc3a355d6cfc/third_party/blink/renderer/platform/graphics/gpu/xr_frame_transport.cc
[modify] https://crrev.com/5d3c459ebda2daf3276b2f278bd2cc3a355d6cfc/third_party/blink/renderer/platform/graphics/gpu/xr_frame_transport.h

Project Member

Comment 6 by bugdroid1@chromium.org, Jun 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5cf526457aef261e2b66b913ae3935aa5e12de05

commit 5cf526457aef261e2b66b913ae3935aa5e12de05
Author: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Date: Fri Jun 15 10:54:30 2018

Revert "Merging WebVR 1.1 RequestPresent into WebXR RequestSession"

This reverts commit 5d3c459ebda2daf3276b2f278bd2cc3a355d6cfc.

Reason for revert: Suspected cause of crashes in WebVrTransitionTest

Original change's description:
> Merging WebVR 1.1 RequestPresent into WebXR RequestSession
> 
> In the WebVR 1.1 spec, the blink code was informed about devices then sent requests
> for pipelines to those devices via the mojo interfaces. In the WebXR spec, the
> decision about which device to use is left up to the browser, and not decided
> until the pipline request has been made. This CL moves the blink<->device interface
> pointers from being call parameters to being return parameters to better align
> with WebXR.
> As WebVR is being deprecated, as much of the old VR code as is possible
> has been cleaned out.
> 
> Bug:  842042 
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_vr
> Change-Id: I67da418829c05479eb3b2a6c5ef1633d8da92564
> Reviewed-on: https://chromium-review.googlesource.com/1080967
> Commit-Queue: Bill Orr <billorr@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Ian Vollick <vollick@chromium.org>
> Reviewed-by: Klaus Weidner <klausw@chromium.org>
> Reviewed-by: Bill Orr <billorr@chromium.org>
> Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#567430}

TBR=vollick@chromium.org,dcheng@chromium.org,mthiesse@chromium.org,klausw@chromium.org,billorr@chromium.org,offenwanger@chromium.org,ijamardo@chromium.org

Change-Id: Ic45c3afc5059a6ee9e3b2ef8dcc9b3eebd59b613
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  842042 ,853147
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_vr
Reviewed-on: https://chromium-review.googlesource.com/1102357
Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567602}
[modify] https://crrev.com/5cf526457aef261e2b66b913ae3935aa5e12de05/chrome/browser/android/vr/arcore_device/arcore_device.cc
[modify] https://crrev.com/5cf526457aef261e2b66b913ae3935aa5e12de05/chrome/browser/android/vr/arcore_device/arcore_device.h
[modify] https://crrev.com/5cf526457aef261e2b66b913ae3935aa5e12de05/chrome/browser/android/vr/arcore_device/arcore_gl.cc
[modify] https://crrev.com/5cf526457aef261e2b66b913ae3935aa5e12de05/chrome/browser/android/vr/arcore_device/arcore_gl.h
[modify] https://crrev.com/5cf526457aef261e2b66b913ae3935aa5e12de05/chrome/browser/android/vr/gl_browser_interface.h
[modify] https://crrev.com/5cf526457aef261e2b66b913ae3935aa5e12de05/chrome/browser/android/vr/vr_gl_thread.cc
[modify] https://crrev.com/5cf526457aef261e2b66b913ae3935aa5e12de05/chrome/browser/android/vr/vr_gl_thread.h
[modify] https://crrev.com/5cf526457aef261e2b66b913ae3935aa5e12de05/chrome/browser/android/vr/vr_shell.cc
[modify] https://crrev.com/5cf526457aef261e2b66b913ae3935aa5e12de05/chrome/browser/android/vr/vr_shell.h
[modify] https://crrev.com/5cf526457aef261e2b66b913ae3935aa5e12de05/chrome/browser/android/vr/vr_shell_delegate.cc
[modify] https://crrev.com/5cf526457aef261e2b66b913ae3935aa5e12de05/chrome/browser/android/vr/vr_shell_delegate.h
[modify] https://crrev.com/5cf526457aef261e2b66b913ae3935aa5e12de05/chrome/browser/android/vr/vr_shell_gl.cc
[modify] https://crrev.com/5cf526457aef261e2b66b913ae3935aa5e12de05/chrome/browser/android/vr/vr_shell_gl.h
[modify] https://crrev.com/5cf526457aef261e2b66b913ae3935aa5e12de05/chrome/browser/vr/service/browser_xr_device.cc
[modify] https://crrev.com/5cf526457aef261e2b66b913ae3935aa5e12de05/chrome/browser/vr/service/browser_xr_device.h
[modify] https://crrev.com/5cf526457aef261e2b66b913ae3935aa5e12de05/chrome/browser/vr/service/vr_display_host.cc
[modify] https://crrev.com/5cf526457aef261e2b66b913ae3935aa5e12de05/chrome/browser/vr/service/vr_display_host.h
[modify] https://crrev.com/5cf526457aef261e2b66b913ae3935aa5e12de05/device/vr/android/gvr/gvr_delegate_provider.h
[modify] https://crrev.com/5cf526457aef261e2b66b913ae3935aa5e12de05/device/vr/android/gvr/gvr_device.cc
[modify] https://crrev.com/5cf526457aef261e2b66b913ae3935aa5e12de05/device/vr/android/gvr/gvr_device.h
[modify] https://crrev.com/5cf526457aef261e2b66b913ae3935aa5e12de05/device/vr/oculus/oculus_device.cc
[modify] https://crrev.com/5cf526457aef261e2b66b913ae3935aa5e12de05/device/vr/oculus/oculus_device.h
[modify] https://crrev.com/5cf526457aef261e2b66b913ae3935aa5e12de05/device/vr/oculus/oculus_render_loop.cc
[modify] https://crrev.com/5cf526457aef261e2b66b913ae3935aa5e12de05/device/vr/oculus/oculus_render_loop.h
[modify] https://crrev.com/5cf526457aef261e2b66b913ae3935aa5e12de05/device/vr/openvr/openvr_device.cc
[modify] https://crrev.com/5cf526457aef261e2b66b913ae3935aa5e12de05/device/vr/openvr/openvr_device.h
[modify] https://crrev.com/5cf526457aef261e2b66b913ae3935aa5e12de05/device/vr/openvr/openvr_render_loop.cc
[modify] https://crrev.com/5cf526457aef261e2b66b913ae3935aa5e12de05/device/vr/openvr/openvr_render_loop.h
[modify] https://crrev.com/5cf526457aef261e2b66b913ae3935aa5e12de05/device/vr/orientation/orientation_device.cc
[modify] https://crrev.com/5cf526457aef261e2b66b913ae3935aa5e12de05/device/vr/orientation/orientation_device.h
[modify] https://crrev.com/5cf526457aef261e2b66b913ae3935aa5e12de05/device/vr/public/mojom/vr_service.mojom
[modify] https://crrev.com/5cf526457aef261e2b66b913ae3935aa5e12de05/device/vr/test/fake_vr_device.cc
[modify] https://crrev.com/5cf526457aef261e2b66b913ae3935aa5e12de05/device/vr/test/fake_vr_device.h
[modify] https://crrev.com/5cf526457aef261e2b66b913ae3935aa5e12de05/device/vr/test/mock_vr_display_impl.cc
[modify] https://crrev.com/5cf526457aef261e2b66b913ae3935aa5e12de05/device/vr/test/mock_vr_display_impl.h
[modify] https://crrev.com/5cf526457aef261e2b66b913ae3935aa5e12de05/device/vr/vr_device.h
[modify] https://crrev.com/5cf526457aef261e2b66b913ae3935aa5e12de05/device/vr/vr_device_base.cc
[modify] https://crrev.com/5cf526457aef261e2b66b913ae3935aa5e12de05/device/vr/vr_device_base.h
[modify] https://crrev.com/5cf526457aef261e2b66b913ae3935aa5e12de05/device/vr/vr_device_base_unittest.cc
[modify] https://crrev.com/5cf526457aef261e2b66b913ae3935aa5e12de05/device/vr/vr_display_impl.cc
[modify] https://crrev.com/5cf526457aef261e2b66b913ae3935aa5e12de05/device/vr/vr_display_impl.h
[modify] https://crrev.com/5cf526457aef261e2b66b913ae3935aa5e12de05/device/vr/vr_display_impl_unittest.cc
[modify] https://crrev.com/5cf526457aef261e2b66b913ae3935aa5e12de05/third_party/WebKit/LayoutTests/vr/resources/mock-vr-service.js
[modify] https://crrev.com/5cf526457aef261e2b66b913ae3935aa5e12de05/third_party/WebKit/LayoutTests/xr/resources/xr-device-mocking.js
[modify] https://crrev.com/5cf526457aef261e2b66b913ae3935aa5e12de05/third_party/WebKit/LayoutTests/xr/xrDevice_requestSession_exclusive_unsupported.html
[modify] https://crrev.com/5cf526457aef261e2b66b913ae3935aa5e12de05/third_party/blink/renderer/modules/vr/vr_display.cc
[modify] https://crrev.com/5cf526457aef261e2b66b913ae3935aa5e12de05/third_party/blink/renderer/modules/vr/vr_display.h
[modify] https://crrev.com/5cf526457aef261e2b66b913ae3935aa5e12de05/third_party/blink/renderer/modules/xr/xr_device.cc
[modify] https://crrev.com/5cf526457aef261e2b66b913ae3935aa5e12de05/third_party/blink/renderer/modules/xr/xr_device.h
[modify] https://crrev.com/5cf526457aef261e2b66b913ae3935aa5e12de05/third_party/blink/renderer/modules/xr/xr_frame_provider.cc
[modify] https://crrev.com/5cf526457aef261e2b66b913ae3935aa5e12de05/third_party/blink/renderer/modules/xr/xr_frame_provider.h
[modify] https://crrev.com/5cf526457aef261e2b66b913ae3935aa5e12de05/third_party/blink/renderer/platform/graphics/gpu/xr_frame_transport.cc
[modify] https://crrev.com/5cf526457aef261e2b66b913ae3935aa5e12de05/third_party/blink/renderer/platform/graphics/gpu/xr_frame_transport.h

Project Member

Comment 7 by bugdroid1@chromium.org, Jun 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/08465996879a09600314d070c3a528756b979d7e

commit 08465996879a09600314d070c3a528756b979d7e
Author: Anna Offenwanger <offenwanger@chromium.org>
Date: Mon Jun 18 23:18:49 2018

Reland "Merging WebVR 1.1 RequestPresent into WebXR RequestSession"

This is a reland of 5d3c459ebda2daf3276b2f278bd2cc3a355d6cfc

TBR=dcheng@chromium.org,vollick@chromium.org,klausw@chromium.org,mthiesse@chromium.org,ijamardo@chromium.org

Original change's description:
> Merging WebVR 1.1 RequestPresent into WebXR RequestSession
>
> In the WebVR 1.1 spec, the blink code was informed about devices then sent requests
> for pipelines to those devices via the mojo interfaces. In the WebXR spec, the
> decision about which device to use is left up to the browser, and not decided
> until the pipline request has been made. This CL moves the blink<->device interface
> pointers from being call parameters to being return parameters to better align
> with WebXR.
> As WebVR is being deprecated, as much of the old VR code as is possible
> has been cleaned out.
>
> Bug:  842042 
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:linux_vr
> Change-Id: I67da418829c05479eb3b2a6c5ef1633d8da92564
> Reviewed-on: https://chromium-review.googlesource.com/1080967
> Commit-Queue: Bill Orr <billorr@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Ian Vollick <vollick@chromium.org>
> Reviewed-by: Klaus Weidner <klausw@chromium.org>
> Reviewed-by: Bill Orr <billorr@chromium.org>
> Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#567430}

Bug:  842042 
Change-Id: I6278326460a6c74df6c1c6f414fc826079d8ca27
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:linux_vr
Reviewed-on: https://chromium-review.googlesource.com/1102800
Commit-Queue: Anna Offenwanger <offenwanger@chromium.org>
Reviewed-by: Ian Vollick <vollick@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Bill Orr <billorr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568226}
[modify] https://crrev.com/08465996879a09600314d070c3a528756b979d7e/chrome/browser/android/vr/arcore_device/arcore_device.cc
[modify] https://crrev.com/08465996879a09600314d070c3a528756b979d7e/chrome/browser/android/vr/arcore_device/arcore_device.h
[modify] https://crrev.com/08465996879a09600314d070c3a528756b979d7e/chrome/browser/android/vr/arcore_device/arcore_gl.cc
[modify] https://crrev.com/08465996879a09600314d070c3a528756b979d7e/chrome/browser/android/vr/arcore_device/arcore_gl.h
[modify] https://crrev.com/08465996879a09600314d070c3a528756b979d7e/chrome/browser/android/vr/gl_browser_interface.h
[modify] https://crrev.com/08465996879a09600314d070c3a528756b979d7e/chrome/browser/android/vr/vr_gl_thread.cc
[modify] https://crrev.com/08465996879a09600314d070c3a528756b979d7e/chrome/browser/android/vr/vr_gl_thread.h
[modify] https://crrev.com/08465996879a09600314d070c3a528756b979d7e/chrome/browser/android/vr/vr_shell.cc
[modify] https://crrev.com/08465996879a09600314d070c3a528756b979d7e/chrome/browser/android/vr/vr_shell.h
[modify] https://crrev.com/08465996879a09600314d070c3a528756b979d7e/chrome/browser/android/vr/vr_shell_delegate.cc
[modify] https://crrev.com/08465996879a09600314d070c3a528756b979d7e/chrome/browser/android/vr/vr_shell_delegate.h
[modify] https://crrev.com/08465996879a09600314d070c3a528756b979d7e/chrome/browser/android/vr/vr_shell_gl.cc
[modify] https://crrev.com/08465996879a09600314d070c3a528756b979d7e/chrome/browser/android/vr/vr_shell_gl.h
[modify] https://crrev.com/08465996879a09600314d070c3a528756b979d7e/chrome/browser/vr/service/browser_xr_device.cc
[modify] https://crrev.com/08465996879a09600314d070c3a528756b979d7e/chrome/browser/vr/service/browser_xr_device.h
[modify] https://crrev.com/08465996879a09600314d070c3a528756b979d7e/chrome/browser/vr/service/vr_display_host.cc
[modify] https://crrev.com/08465996879a09600314d070c3a528756b979d7e/chrome/browser/vr/service/vr_display_host.h
[modify] https://crrev.com/08465996879a09600314d070c3a528756b979d7e/device/vr/android/gvr/gvr_delegate_provider.h
[modify] https://crrev.com/08465996879a09600314d070c3a528756b979d7e/device/vr/android/gvr/gvr_device.cc
[modify] https://crrev.com/08465996879a09600314d070c3a528756b979d7e/device/vr/android/gvr/gvr_device.h
[modify] https://crrev.com/08465996879a09600314d070c3a528756b979d7e/device/vr/oculus/oculus_device.cc
[modify] https://crrev.com/08465996879a09600314d070c3a528756b979d7e/device/vr/oculus/oculus_device.h
[modify] https://crrev.com/08465996879a09600314d070c3a528756b979d7e/device/vr/oculus/oculus_render_loop.cc
[modify] https://crrev.com/08465996879a09600314d070c3a528756b979d7e/device/vr/oculus/oculus_render_loop.h
[modify] https://crrev.com/08465996879a09600314d070c3a528756b979d7e/device/vr/openvr/openvr_device.cc
[modify] https://crrev.com/08465996879a09600314d070c3a528756b979d7e/device/vr/openvr/openvr_device.h
[modify] https://crrev.com/08465996879a09600314d070c3a528756b979d7e/device/vr/openvr/openvr_render_loop.cc
[modify] https://crrev.com/08465996879a09600314d070c3a528756b979d7e/device/vr/openvr/openvr_render_loop.h
[modify] https://crrev.com/08465996879a09600314d070c3a528756b979d7e/device/vr/orientation/orientation_device.cc
[modify] https://crrev.com/08465996879a09600314d070c3a528756b979d7e/device/vr/orientation/orientation_device.h
[modify] https://crrev.com/08465996879a09600314d070c3a528756b979d7e/device/vr/public/mojom/vr_service.mojom
[modify] https://crrev.com/08465996879a09600314d070c3a528756b979d7e/device/vr/test/fake_vr_device.cc
[modify] https://crrev.com/08465996879a09600314d070c3a528756b979d7e/device/vr/test/fake_vr_device.h
[modify] https://crrev.com/08465996879a09600314d070c3a528756b979d7e/device/vr/test/mock_vr_display_impl.cc
[modify] https://crrev.com/08465996879a09600314d070c3a528756b979d7e/device/vr/test/mock_vr_display_impl.h
[modify] https://crrev.com/08465996879a09600314d070c3a528756b979d7e/device/vr/vr_device.h
[modify] https://crrev.com/08465996879a09600314d070c3a528756b979d7e/device/vr/vr_device_base.cc
[modify] https://crrev.com/08465996879a09600314d070c3a528756b979d7e/device/vr/vr_device_base.h
[modify] https://crrev.com/08465996879a09600314d070c3a528756b979d7e/device/vr/vr_device_base_unittest.cc
[modify] https://crrev.com/08465996879a09600314d070c3a528756b979d7e/device/vr/vr_display_impl.cc
[modify] https://crrev.com/08465996879a09600314d070c3a528756b979d7e/device/vr/vr_display_impl.h
[modify] https://crrev.com/08465996879a09600314d070c3a528756b979d7e/device/vr/vr_display_impl_unittest.cc
[modify] https://crrev.com/08465996879a09600314d070c3a528756b979d7e/third_party/WebKit/LayoutTests/vr/resources/mock-vr-service.js
[modify] https://crrev.com/08465996879a09600314d070c3a528756b979d7e/third_party/WebKit/LayoutTests/xr/resources/xr-device-mocking.js
[modify] https://crrev.com/08465996879a09600314d070c3a528756b979d7e/third_party/WebKit/LayoutTests/xr/xrDevice_requestSession_exclusive_unsupported.html
[modify] https://crrev.com/08465996879a09600314d070c3a528756b979d7e/third_party/blink/renderer/modules/vr/vr_display.cc
[modify] https://crrev.com/08465996879a09600314d070c3a528756b979d7e/third_party/blink/renderer/modules/vr/vr_display.h
[modify] https://crrev.com/08465996879a09600314d070c3a528756b979d7e/third_party/blink/renderer/modules/xr/xr_device.cc
[modify] https://crrev.com/08465996879a09600314d070c3a528756b979d7e/third_party/blink/renderer/modules/xr/xr_device.h
[modify] https://crrev.com/08465996879a09600314d070c3a528756b979d7e/third_party/blink/renderer/modules/xr/xr_frame_provider.cc
[modify] https://crrev.com/08465996879a09600314d070c3a528756b979d7e/third_party/blink/renderer/modules/xr/xr_frame_provider.h
[modify] https://crrev.com/08465996879a09600314d070c3a528756b979d7e/third_party/blink/renderer/platform/graphics/gpu/xr_frame_transport.cc
[modify] https://crrev.com/08465996879a09600314d070c3a528756b979d7e/third_party/blink/renderer/platform/graphics/gpu/xr_frame_transport.h

Components: Blink>WebXR
Labels: -Proj-XR-AR
Labels: BlinkWebXR
Removing Blink>WebVR component and assigning to Blink>WebXR 
Labels: -BlinkWebXR
Removing Blink>WebVR component and assigning to Blink>WebXR 
Components: -Blink>WebVR
Status: Fixed (was: Started)

Sign in to add a comment