New issue
Advanced search Search tips

Issue 842035 link

Starred by 1 user
Status: Fixed
Owner:
petewil@chromium.org
Closed: May 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

"org.chromium.chrome.browser.offlinepages.OfflinePageBridgeTest#testSavePageNoOrigin" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, May 11 2018 
"org.chromium.chrome.browser.offlinepages.OfflinePageBridgeTest#testSavePageNoOrigin" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 4 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyXgsSBUZsYWtlIlNvcmcuY2hyb21pdW0uY2hyb21lLmJyb3dzZXIub2ZmbGluZXBhZ2VzLk9mZmxpbmVQYWdlQnJpZGdlVGVzdCN0ZXN0U2F2ZVBhZ2VOb09yaWdpbgw.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
Project Member

Comment 1 by bugdroid1@chromium.org, May 11 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1c99bec0b649fa722e4d41d64d07ad0eaba701bb

commit 1c99bec0b649fa722e4d41d64d07ad0eaba701bb
Author: Timothy Loh <timloh@chromium.org>
Date: Fri May 11 03:03:14 2018

Revert "Finch code for OfflinePagesSharing"

This reverts commit f1c154fd8bfb2387b10cb347389e722f0562efeb.

Reason for revert: "org.chromium.chrome.browser.offlinepages.OfflinePageBridgeTest#testSavePageNoOrigin" is flaky	

https://bugs.chromium.org/p/chromium/issues/detail?id=842035

Original change's description:
> Finch code for OfflinePagesSharing
> 
> Ensures that test bots cover OfflinePagesSharing flag scenarios.
> 
> Bug: 758733
> Change-Id: Id73eebc0e9592318ed4d33b95dc169574bc0efc3
> Reviewed-on: https://chromium-review.googlesource.com/1043349
> Reviewed-by: David Trainor <dtrainor@chromium.org>
> Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
> Reviewed-by: Jian Li <jianli@chromium.org>
> Commit-Queue: Peter Williamson <petewil@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#557636}

TBR=petewil@chromium.org,asvitkine@chromium.org,dtrainor@chromium.org,jianli@chromium.org

Change-Id: Ib44d68b435936b2e0f943073fc458c5c7a6a44a9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 758733,  842035 
Reviewed-on: https://chromium-review.googlesource.com/1055167
Reviewed-by: Timothy Loh <timloh@chromium.org>
Commit-Queue: Timothy Loh <timloh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557775}
[modify] https://crrev.com/1c99bec0b649fa722e4d41d64d07ad0eaba701bb/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadActivityTest.java
[modify] https://crrev.com/1c99bec0b649fa722e4d41d64d07ad0eaba701bb/testing/variations/fieldtrial_testing_config.json

Comment 2 by rdevlin....@chromium.org, May 11 2018

Status: Fixed (was: Untriaged)
No flakes after the revert landed; closing.

Comment 3 by petewil@chromium.org, May 12 2018

Owner: petewil@chromium.org
►

Sign in to add a comment