New issue
Advanced search Search tips

Issue 842013 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Toast button should not have hairline

Project Member Reported by namratakannan@chromium.org, May 11 2018

Issue description

The buttons in toasts in Bookmarks should not have a border.
Spec attached.

 
Toast_Current.png
22.2 KB View Download
Snackbar_spec.png
7.8 KB View Download
Owner: hs1217....@samsung.com
Status: Started (was: Untriaged)
i will take this issue.

Comment 2 Deleted

Labels: M-68

Comment 4 by dpa...@chromium.org, May 12 2018

Labels: -PrjMDRefresh

Comment 5 by dpa...@chromium.org, May 12 2018

Labels: Proj-MaterialDesign-Refresh-WebUI
Project Member

Comment 6 by bugdroid1@chromium.org, May 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fba466b8e35478b81b36ca09d7c23bbd80af8425

commit fba466b8e35478b81b36ca09d7c23bbd80af8425
Author: Hwanseung Lee <hs1217.lee@samsung.com>
Date: Mon May 14 05:06:07 2018

[WebUI] Toast button shuld not have hairline

the button in toasts of Bookmarks should not have a border.

Bug:  842013 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I2d431ba60b598125730eaf56b618fe3e9b1d9ccd
Reviewed-on: https://chromium-review.googlesource.com/1055132
Commit-Queue: Hwanseung Lee <hwanseung@chromium.org>
Reviewed-by: calamity <calamity@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558200}
[modify] https://crrev.com/fba466b8e35478b81b36ca09d7c23bbd80af8425/chrome/browser/resources/md_bookmarks/toast_manager.html

Status: Fixed (was: Started)
Cc: phanindra.mandapaka@chromium.org
Able to reproduce the issue on chrome version 68.0.3430.0(build without fix)
Verified the fix on Mac 10.13.3 and Ubuntu 14.04 using Chrome version #68.0.3431.0 as per the comment #0.
Attaching screenshot for reference.
Observed that ""the button in toasts of Bookmarks not having a border.""
Hence, the fix is working as expected. 

Note: Unable to verify the fix on Windows 32 & 64 due to issue: 843012.

Thanks...!
842013.mp4
441 KB View Download

Comment 9 by dpa...@chromium.org, May 22 2018

Cc: aee@chromium.org hs1217....@samsung.com
Owner: ----
Status: Available (was: Fixed)
This still happens in chrome://settings, see attached screenshot. Re-opening.
toast_button.png
6.2 KB View Download

Comment 10 by aee@chromium.org, May 23 2018

Cc: -aee@chromium.org
Owner: aee@chromium.org
Status: Started (was: Available)
Project Member

Comment 11 by bugdroid1@chromium.org, May 23 2018

Comment 12 by aee@chromium.org, May 23 2018

Status: Fixed (was: Started)
Labels: TE-Verified-M68 TE-Verified-68.0.3439.0
Able to reproduce the issue on chrome version 68.0.3435.0(build without fix)
Verified the fix on Windows 10,Mac 10.13.3 and Ubuntu 14.04 using Chrome version #68.0.3439.0 as per the comment #11.
Attaching screencast for reference.
Observed that "the button in toasts of Settings not having a border."
Adding verified labels as fix is working as expected. 

Thanks...!
842013.mp4
2.1 MB View Download

Sign in to add a comment