Mobmonitor - pressing network check before boto key should give nice warning |
||||||
Issue descriptionCurrently the warning is a command error from python, we should give nice warnings or disable the button to check until we have a boto key.
,
May 11 2018
,
Jul 16
,
Jul 26
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/moblab/+/e242064d730235d7e19a7363f8b767549ce46861 commit e242064d730235d7e19a7363f8b767549ce46861 Author: Matt Mallett <mattmallett@chromium.org> Date: Thu Jul 26 22:52:04 2018 [moblab] Better error for mobmonitor gs speed test Don't show a command error pop-up if the user runs the speed test diagnostic before configuring google storage. Just show a message in the results area. BUG= chromium:842011 TEST=Test on local device, cloud_storage_speedtest_unittest.py Change-Id: I0d9d377b8e5568f471223e95596729eeea1aecc9 Reviewed-on: https://chromium-review.googlesource.com/1138988 Commit-Ready: Matt Mallett <mattmallett@chromium.org> Tested-by: Keith Haddow <haddowk@chromium.org> Reviewed-by: Keith Haddow <haddowk@chromium.org> [modify] https://crrev.com/e242064d730235d7e19a7363f8b767549ce46861/src/mobmonitor/diagnostic_checks/cloud_storage_speedtest.py
,
Aug 8
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/moblab/+/298347327d4ff6fcc9bc6bf87ce1a148ea1ef82e commit 298347327d4ff6fcc9bc6bf87ce1a148ea1ef82e Author: Matt Mallett <mattmallett@chromium.org> Date: Tue Aug 07 22:55:40 2018 [moblab] Better error for mobmonitor gs speed test Don't show a command error pop-up if the user runs the speed test diagnostic before configuring google storage. Just show a message in the results area. BUG= chromium:842011 TEST=Test on local device, cloud_storage_speedtest_unittest.py Change-Id: I0d9d377b8e5568f471223e95596729eeea1aecc9 Reviewed-on: https://chromium-review.googlesource.com/1138988 Commit-Ready: Matt Mallett <mattmallett@chromium.org> Tested-by: Keith Haddow <haddowk@chromium.org> Reviewed-by: Keith Haddow <haddowk@chromium.org> (cherry picked from commit e242064d730235d7e19a7363f8b767549ce46861) [modify] https://crrev.com/298347327d4ff6fcc9bc6bf87ce1a148ea1ef82e/src/mobmonitor/diagnostic_checks/cloud_storage_speedtest.py
,
Aug 8
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/moblab/+/dadcb163e7d08718974bd38da47f3c3d09367819 commit dadcb163e7d08718974bd38da47f3c3d09367819 Author: Matt Mallett <mattmallett@chromium.org> Date: Tue Aug 07 22:56:58 2018 [moblab] Better error for mobmonitor gs speed test Don't show a command error pop-up if the user runs the speed test diagnostic before configuring google storage. Just show a message in the results area. BUG= chromium:842011 TEST=Test on local device, cloud_storage_speedtest_unittest.py Change-Id: I0d9d377b8e5568f471223e95596729eeea1aecc9 Reviewed-on: https://chromium-review.googlesource.com/1138988 Commit-Ready: Matt Mallett <mattmallett@chromium.org> Tested-by: Keith Haddow <haddowk@chromium.org> Reviewed-by: Keith Haddow <haddowk@chromium.org> (cherry picked from commit e242064d730235d7e19a7363f8b767549ce46861) [modify] https://crrev.com/dadcb163e7d08718974bd38da47f3c3d09367819/src/mobmonitor/diagnostic_checks/cloud_storage_speedtest.py
,
Aug 8
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by mattmallett@chromium.org
, May 11 2018