New issue
Advanced search Search tips

Issue 842010 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Highlighted tab color to Google Blue 600

Project Member Reported by namratakannan@chromium.org, May 11 2018

Issue description

Change highlight tab color to GB 600 in Clear Browsing Data, Manage certificates etc
 
Owner: hs1217....@samsung.com
Status: Started (was: Untriaged)
i will take this issue.

Comment 2 by dpa...@chromium.org, May 12 2018

Labels: -ProjMDRefresh

Comment 3 by dpa...@chromium.org, May 12 2018

Labels: Proj-MaterialDesign-Refresh-WebUI

Comment 4 by dpa...@chromium.org, May 12 2018

Labels: M-68

Comment 5 by dpa...@chromium.org, May 14 2018

Labels: -Pri-3 Pri-2
We should also drop the uppercase from Certificate manager's tabs, see screenshots where they are currently inconsistent with CBD dialog's tabs.

Also note that a candidate CL for the color exists at https://chromium-review.googlesource.com/c/chromium/src/+/1055229.
tabs1.png
7.8 KB View Download
tabs2.png
22.5 KB View Download
Project Member

Comment 6 by bugdroid1@chromium.org, May 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6941da6007cfc4a2c54617cd689395c43219baa1

commit 6941da6007cfc4a2c54617cd689395c43219baa1
Author: Hwanseung Lee <hs1217.lee@samsung.com>
Date: Tue May 15 19:10:26 2018

[WebUI] highlighted tab color to Google Blue 600

change highlight tab color to GB 600 in Clear Browsing Data, Manage
certificates.
and also drop the uppercase from Certificate manager's tabs
to keep consistent.

Bug:  842010 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I060112a47e9feac1ccba6b9dc20b48d4ca6843d0
Reviewed-on: https://chromium-review.googlesource.com/1055229
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558798}
[modify] https://crrev.com/6941da6007cfc4a2c54617cd689395c43219baa1/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html
[modify] https://crrev.com/6941da6007cfc4a2c54617cd689395c43219baa1/chrome/browser/resources/settings/device_page/display.html
[modify] https://crrev.com/6941da6007cfc4a2c54617cd689395c43219baa1/chrome/browser/resources/settings/settings_vars_css.html
[modify] https://crrev.com/6941da6007cfc4a2c54617cd689395c43219baa1/ui/webui/resources/cr_components/certificate_manager/certificate_manager.html
[add] https://crrev.com/6941da6007cfc4a2c54617cd689395c43219baa1/ui/webui/resources/cr_elements/paper_tabs_style_css.html
[modify] https://crrev.com/6941da6007cfc4a2c54617cd689395c43219baa1/ui/webui/resources/cr_elements_resources.grdp

Status: Fixed (was: Started)
Labels: TE-Verified-68.0.3432.0 TE-Verified-M68
Able to reproduce the issue using chrome version without fix.

Verified the fix on Mac 10.13.3, Win-10 and Ubuntu 17.10 using Chrome version #68.0.3432.0 as per the comment #6.
Attaching screen shot for reference.
Observed that highlight tab color is changed to GB 600 in Clear Browsing Data, Manage
certificates and uppercase is also dropped from Certificate manager's tabs.
Hence, the fix is working as expected. 
Adding the verified labels.

Thanks...!!
842010.png
743 KB View Download

Sign in to add a comment