Bookmarks MD Refresh |
||||||||||||||
Issue description1. Highlighted row background GG50 (E8F0FE) 2. Selection bar on multi row select background color to white 3. Buttons to hairline buttons
,
May 12 2018
,
May 12 2018
,
May 12 2018
,
May 16 2018
Just to make sure, the 1px border mentioned in comment#5 is for border-bottom on the multi-select display on the top.
,
May 21 2018
Yup!
,
May 29 2018
,
May 29 2018
Issue 845573 has been merged into this issue.
,
May 29 2018
Screenshots for https://chromium-review.googlesource.com/c/chromium/src/+/1077498
,
May 29 2018
,
May 30 2018
Hey, Arrows on the right seem really inconsistent with a complex folder tree, looks pretty weird with a wide sidebar, and it's no longer possible to tell which folders have children in a more narrow sidebar. See screenshots. I don't think we should move forward here until these problems are addressed.
,
May 31 2018
Synced with bettes@ about the position of the arrow icons. Let's keep them on the left (meaning as they are on ToT, no change). @aee: Are there any slides that have the arrows on the right? I don't see any changes requested about the arrow icons location on the opening comment of this issue.
,
May 31 2018
The bookmark slide has the folder section cutoff in the picture. The folder style change was from https://crbug.com/842007#c5 I'll leave the folders as they were.
,
Jun 1 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a17e4103e82e75462cb32a066e9c4b532cb4555d commit a17e4103e82e75462cb32a066e9c4b532cb4555d Author: Esmael El-Moslimany <aee@chromium.org> Date: Fri Jun 01 20:19:54 2018 Bookmarks WebUI: refresh selection overlay style This includes history since they share the same component. Bug: 842007 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ic615eb6931ca16c8619c07cb66db8637be93a4ff Reviewed-on: https://chromium-review.googlesource.com/1077498 Reviewed-by: calamity <calamity@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#563769} [modify] https://crrev.com/a17e4103e82e75462cb32a066e9c4b532cb4555d/chrome/browser/resources/md_bookmarks/list.html [modify] https://crrev.com/a17e4103e82e75462cb32a066e9c4b532cb4555d/chrome/browser/resources/md_bookmarks/shared_vars.html [modify] https://crrev.com/a17e4103e82e75462cb32a066e9c4b532cb4555d/chrome/browser/resources/md_bookmarks/toolbar.html [modify] https://crrev.com/a17e4103e82e75462cb32a066e9c4b532cb4555d/chrome/browser/resources/md_history/history_toolbar.html [modify] https://crrev.com/a17e4103e82e75462cb32a066e9c4b532cb4555d/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_selection_overlay.html [modify] https://crrev.com/a17e4103e82e75462cb32a066e9c4b532cb4555d/ui/webui/resources/cr_elements/shared_vars_css.html
,
Jun 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/76b4c3d630828fa25644bebdd6c9bfc0bd31aa83 commit 76b4c3d630828fa25644bebdd6c9bfc0bd31aa83 Author: Esmael El-Moslimany <aee@chromium.org> Date: Sat Jun 02 00:46:11 2018 Bookmarks WebUI: adding import for css var, prefer border-box over manually adjusting height Bug: 842007 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: If04da828d2d9f6a2aeec08b782465741d33b61a1 Reviewed-on: https://chromium-review.googlesource.com/1083593 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#563886} [modify] https://crrev.com/76b4c3d630828fa25644bebdd6c9bfc0bd31aa83/chrome/browser/resources/md_bookmarks/shared_vars.html [modify] https://crrev.com/76b4c3d630828fa25644bebdd6c9bfc0bd31aa83/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_selection_overlay.html
,
Jun 4 2018
,
Jun 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2d16b80465674a158f0c14ecbe16f47744e2c0da commit 2d16b80465674a158f0c14ecbe16f47744e2c0da Author: Christopher Lam <calamity@chromium.org> Date: Wed Jun 06 05:59:13 2018 [cr-toolbar-selection-overlay] Fix animations. This CL fixes animations in the toolbar selection overlay. The elements would originally instantly appear rather than smoothly animate in due to the way dom-if worked. This has been fixed by applying an opacity animation rather than a show/hide. Bug: 842007 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I75598d9048c3b4533a2dd52d003ff5a5d37e615d Reviewed-on: https://chromium-review.googlesource.com/1084391 Reviewed-by: Alan Cutter <alancutter@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#564801} [modify] https://crrev.com/2d16b80465674a158f0c14ecbe16f47744e2c0da/chrome/browser/resources/md_bookmarks/toolbar.html [modify] https://crrev.com/2d16b80465674a158f0c14ecbe16f47744e2c0da/chrome/browser/resources/md_bookmarks/toolbar.js [modify] https://crrev.com/2d16b80465674a158f0c14ecbe16f47744e2c0da/chrome/browser/resources/md_history/history_toolbar.html [modify] https://crrev.com/2d16b80465674a158f0c14ecbe16f47744e2c0da/chrome/browser/resources/md_history/history_toolbar.js [modify] https://crrev.com/2d16b80465674a158f0c14ecbe16f47744e2c0da/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_selection_overlay.html [modify] https://crrev.com/2d16b80465674a158f0c14ecbe16f47744e2c0da/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_selection_overlay.js |
||||||||||||||
►
Sign in to add a comment |
||||||||||||||
Comment 1 by dpa...@chromium.org
, May 12 2018