Rename U2f* -> Fido2* |
||||
Issue descriptionIn v19, the FIDO2 API provides the combined functionality of the U2F and FIDO2 APIs, so calling the U2F API is no longer needed. Existing U2F* things should be renamed to Fido2* things.
,
May 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/85291fb10c4500c215e532de60afcef828b0cb96 commit 85291fb10c4500c215e532de60afcef828b0cb96 Author: Boris Sazonov <bsazonov@chromium.org> Date: Tue May 15 13:03:21 2018 Revert "Rename U2f* to Fido2*" This reverts commit 203117d9b2d50584558e885d1be217574b80806e. Reason for revert: broke downstream and official builders. Builder: http://uberchromegw/i/official.android/builders/official-arm/builds/3216 Original change's description: > Rename U2f* to Fido2* > > In GmsCore v19, the Fido2 APIs will provide the unified functionality > of the U2F and Fido2 APIs so it will no longer be necessary to call > both of them. > > Since the rename spans upstream and downstream, will initially add > all Fido2* classes and then later remove the U2f* classes once > downstream changes have landed. > > Bug: 842006 > Change-Id: I4775682b428c0ffdc4aa6f699136a2c7d15ee40c > Reviewed-on: https://chromium-review.googlesource.com/1054778 > Reviewed-by: Maria Khomenko <mariakhomenko@chromium.org> > Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org> > Cr-Commit-Position: refs/heads/master@{#558479} TBR=mariakhomenko@chromium.org,kpaulhamus@chromium.org Change-Id: I20e10d48e1630d8a084003287f2dda9365d030be No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 843011, 842006 Reviewed-on: https://chromium-review.googlesource.com/1059595 Reviewed-by: Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#558680} [modify] https://crrev.com/85291fb10c4500c215e532de60afcef828b0cb96/chrome/android/java/src/org/chromium/chrome/browser/AppHooks.java [delete] https://crrev.com/218b72e7226a1b9f6c34503d9b986aef38841fc5/chrome/android/java/src/org/chromium/chrome/browser/webauth/Fido2ApiHandler.java [modify] https://crrev.com/85291fb10c4500c215e532de60afcef828b0cb96/chrome/android/java/src/org/chromium/chrome/browser/webauth/U2fApiHandler.java [modify] https://crrev.com/85291fb10c4500c215e532de60afcef828b0cb96/chrome/android/java_sources.gni
,
May 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/01a240270fd3f885185eee2be16193f9ce308af1 commit 01a240270fd3f885185eee2be16193f9ce308af1 Author: Boris Sazonov <bsazonov@chromium.org> Date: Tue May 15 14:10:04 2018 Revert "Rename U2f* to Fido2*" This reverts commit 203117d9b2d50584558e885d1be217574b80806e. Reason for revert: broke downstream and official builders. Builder: http://uberchromegw/i/official.android/builders/official-arm/builds/3216 Original change's description: > Rename U2f* to Fido2* > > In GmsCore v19, the Fido2 APIs will provide the unified functionality > of the U2F and Fido2 APIs so it will no longer be necessary to call > both of them. > > Since the rename spans upstream and downstream, will initially add > all Fido2* classes and then later remove the U2f* classes once > downstream changes have landed. > > Bug: 842006 > Change-Id: I4775682b428c0ffdc4aa6f699136a2c7d15ee40c > Reviewed-on: https://chromium-review.googlesource.com/1054778 > Reviewed-by: Maria Khomenko <mariakhomenko@chromium.org> > Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org> > Cr-Commit-Position: refs/heads/master@{#558479} TBR=mariakhomenko@chromium.org,kpaulhamus@chromium.org Change-Id: I20e10d48e1630d8a084003287f2dda9365d030be No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 843011, 842006 Reviewed-on: https://chromium-review.googlesource.com/1059595 Reviewed-by: Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#558680}(cherry picked from commit 85291fb10c4500c215e532de60afcef828b0cb96) Reviewed-on: https://chromium-review.googlesource.com/1059813 Cr-Commit-Position: refs/branch-heads/3431@{#3} Cr-Branched-From: 5a0c41f5f60be32ed2ca723060bc088af531c89b-refs/heads/master@{#558557} [modify] https://crrev.com/01a240270fd3f885185eee2be16193f9ce308af1/chrome/android/java/src/org/chromium/chrome/browser/AppHooks.java [delete] https://crrev.com/e31e0d95bff1264fe56bfed86ec96c2fc81250c1/chrome/android/java/src/org/chromium/chrome/browser/webauth/Fido2ApiHandler.java [modify] https://crrev.com/01a240270fd3f885185eee2be16193f9ce308af1/chrome/android/java/src/org/chromium/chrome/browser/webauth/U2fApiHandler.java [modify] https://crrev.com/01a240270fd3f885185eee2be16193f9ce308af1/chrome/android/java_sources.gni
,
May 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/83a2d816063fe654334ee8719b02d996df9c78aa commit 83a2d816063fe654334ee8719b02d996df9c78aa Author: Kim Paulhamus <kpaulhamus@chromium.org> Date: Wed May 16 15:27:30 2018 Reland "Rename U2f* to Fido2*" This is a reland of 203117d9b2d50584558e885d1be217574b80806e that adds back U2fApiHandler to java_sources. Original change's description: > Rename U2f* to Fido2* > > In GmsCore v19, the Fido2 APIs will provide the unified functionality > of the U2F and Fido2 APIs so it will no longer be necessary to call > both of them. > > Since the rename spans upstream and downstream, will initially add > all Fido2* classes and then later remove the U2f* classes once > downstream changes have landed. > > Bug: 842006 > Change-Id: I4775682b428c0ffdc4aa6f699136a2c7d15ee40c > Reviewed-on: https://chromium-review.googlesource.com/1054778 > Reviewed-by: Maria Khomenko <mariakhomenko@chromium.org> > Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org> > Cr-Commit-Position: refs/heads/master@{#558479} Bug: 842006 Change-Id: Ib6e5337a25c8ca57c7abe5736a6531975baeda19 Reviewed-on: https://chromium-review.googlesource.com/1059737 Reviewed-by: Maria Khomenko <mariakhomenko@chromium.org> Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org> Cr-Commit-Position: refs/heads/master@{#559108} [modify] https://crrev.com/83a2d816063fe654334ee8719b02d996df9c78aa/chrome/android/java/src/org/chromium/chrome/browser/AppHooks.java [add] https://crrev.com/83a2d816063fe654334ee8719b02d996df9c78aa/chrome/android/java/src/org/chromium/chrome/browser/webauth/Fido2ApiHandler.java [modify] https://crrev.com/83a2d816063fe654334ee8719b02d996df9c78aa/chrome/android/java/src/org/chromium/chrome/browser/webauth/U2fApiHandler.java [modify] https://crrev.com/83a2d816063fe654334ee8719b02d996df9c78aa/chrome/android/java_sources.gni
,
May 16 2018
Hmm, Clank doesn't build anymore:
../../clank/java/src/com/google/android/apps/chrome/webauth/U2fApiHandlerInternal.java:21: error: method does not override or implement a method from a supertype
@Override
^
../../clank/java/src/com/google/android/apps/chrome/webauth/U2fApiHandlerInternal.java:28: error: method does not override or implement a method from a supertype
@Override
^
2 errors
,
May 16 2018
:-( I know what that is. Getting a fix ready right now.
,
May 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/569e4675b938a44f53166af1e3dedafae32e8f19 commit 569e4675b938a44f53166af1e3dedafae32e8f19 Author: Kim Paulhamus <kpaulhamus@chromium.org> Date: Wed May 16 20:59:20 2018 Fix broken clank by undoing method rename upstream. Bug: 842006 Change-Id: Idc7959c00d8ec22b824242db97923c3985f44d2f Reviewed-on: https://chromium-review.googlesource.com/1062365 Reviewed-by: Maria Khomenko <mariakhomenko@chromium.org> Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org> Cr-Commit-Position: refs/heads/master@{#559280} [modify] https://crrev.com/569e4675b938a44f53166af1e3dedafae32e8f19/chrome/android/java/src/org/chromium/chrome/browser/webauth/U2fApiHandler.java
,
May 17 2018
The following revision refers to this bug: https://chrome-internal.googlesource.com/clank/internal/apps/+/0b66e95617bbec69fda9aab51f523dd410585def commit 0b66e95617bbec69fda9aab51f523dd410585def Author: Kim Paulhamus <kpaulhamus@google.com> Date: Thu May 17 20:12:22 2018
,
May 18 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/41a17e7965e735379b35071ab74dc86bb9ee183f commit 41a17e7965e735379b35071ab74dc86bb9ee183f Author: Kim Paulhamus <kpaulhamus@chromium.org> Date: Fri May 18 23:37:28 2018 Complete u2f*=>fido2* rename by removing U2fApiHandler. Bug: 842006 Change-Id: I2bdaed1228b8e411e875bc2b77b023c3294bc374 Reviewed-on: https://chromium-review.googlesource.com/1056390 Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org> Reviewed-by: Maria Khomenko <mariakhomenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#560101} [modify] https://crrev.com/41a17e7965e735379b35071ab74dc86bb9ee183f/chrome/android/java/src/org/chromium/chrome/browser/AppHooks.java [delete] https://crrev.com/4f76d3cd59bbda1bf7414530fff5bc907598089c/chrome/android/java/src/org/chromium/chrome/browser/webauth/U2fApiHandler.java [modify] https://crrev.com/41a17e7965e735379b35071ab74dc86bb9ee183f/chrome/android/java_sources.gni
,
May 22 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by bugdroid1@chromium.org
, May 14 2018